Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

Hi Aditya, It is not possible to fire event in another tab/new browser window. For >>> example, query tool can be open in another tab. And thus, changes are not >>> reflected there. There are solutions available like updating the >>> localStorage of the browser but those are not reliable and

Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11

Hi Khushboo, The following change is allowing the creation of procedures in postgresql versions less then 11 and also GreenPlum --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js +++

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo can you explain a little bit more this while loop? cnt = 0 while 1: if cnt > 1: break # Check the process list response1 = self.tester.get('/misc/bgprocess/?_='.format( random.randint(1, 999))) self.assertEquals(response1.status_code, 200)

[pgAdmin][patch] RM3409 - Retrieving SQL from table throws exception

Hi hackers, Attached is a patch that fixes an exception when trying to view the SQL tab on a GreenPlum database. Sincerely, Joao && Victoria RM3409.patch Description: Binary data

Re: [pgadmin][patch] Electron version 4.X

On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > Hi > > On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find the patch that introduces electron to our code base. >> > Cool. FYI, I'd like to get this into

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

s like this is still being used in web/pgadmin/tools/sqleditor/static/js/sqleditor.js with Datagrid.create_transaction Sincerely, Victoria ​ On Thu, Jun 7, 2018 at 12:35 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Victoria, > > On Wed, Jun 6, 2018 at 8:

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

> > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > > On Sat, Jun 2, 2018 at 12:47 AM, Victoria Henry wrote: > >> Hey Ashesh, >> >> LGTM! The some o

Re: [pgadmin4][Patch]: Test cases for the backup module

ding, these are not tests, >>>>>> are helpers. >>>>>> ​ >>>>>> >>>>>> >>>>>> Thanks >>>>>> Victoria & Joao >>>>>> >>>>>> On Mon, Jun 4, 2018

Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

Hi Akshay, LGTM and passes tests. Sincerely, Victoria On Tue, Jun 5, 2018 at 8:28 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the minor patch to move 'Notifications' tab before "Query > History" in Query Tool. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hey Ashesh, LGTM! The some of the CI tests failed but it looks like a flake. But you can go ahead and merge this. Sincerely, Victoria On Fri, Jun 1, 2018 at 2:36 PM Ashesh Vashi wrote: > On Fri, Jun 1, 2018 at 10:09 PM, Victoria Henry wrote: > >> Hi Ashesh, >> &g

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Ashesh, We just attempted to apply your patch over master but it did not work. We don't want to introduce any bugs or break any functionality. Please update the patch to make sure it is synced up with the master branch. Sincerely, Victoria On Fri, Jun 1, 2018 at 11:18 AM Anthony Emengo

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi there, We've been noticing some issues with the tests on both our CI and local Mac workstations. 1. When the following code blocks are invoked - we get plenty of app.context() issues. It must not be valid when running tests. ​ from pgadmin.utils.driver import get_driver driver =

Re: Container build hanging

Hey Dave, The reason that it was taking so long was because the linter was acting on the javascript in the ycache directory in the container. The fix is to add the ycache directory to the .eslintignore file. We can send a patch file, if you’d like: diff --git a/web/.eslintignore

Re: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Hi Akshay, Thanks for the patch. It looks good to me as long as it also works on windows. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 4:53 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch file to fix RM #3277 Runtime startup error handling > is broken on Windows. I

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hey Murtuza, Thanks for the explanation. That seems fine. This patch can be submitted. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 2:22 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Victoria & Joao, > > > On Thu, May 31, 2018 at 2:17 AM, Joao De Almeida

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Aditya, We made a minor change to make the patch so the python linter can pass. Attached is the change we made. Everything else looks good. Sincerely, Victoria & Anthony On Tue, May 22, 2018 at 4:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > PFA updated

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Hi Aditya, Looks good to us! Sincerely, Anthony & Victoria On Wed, May 16, 2018 at 7:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch to allow server port number below 1024 till 1 in Create Server > dialog. > > Thanks and Regards, > Aditya

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

Hi Aditya, The patch looks fine and the tests are passing. Sincerely, Victoria & Anthony On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch for query tool keyboard issue where arrow keys were not behaving > as expected for

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Khushboo, Could you write tests for this change? These files are actually apart of the ACITree refactoring patch. If this patch was already in master the task of adding tests would be much easier. Victoria & Joao On Wed, May 2, 2018 at 8:33 AM, Ashesh Vashi

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Akshay, Thanks for sending this updated patch. The linter and tests are all passing. > - utils/driver/psycopg2/server_manager.py >> - Do we have Unit Tests around this? > > No. In our opinion, server_manager.py and connection.py should have tests. Are you finding it difficult to add

Re: pgAdmin4 - Issue of unmaintained libraries

Hi Dave, On Wed, Apr 4, 2018 at 5:03 AM, Dave Page wrote: > Hi > > On Tue, Apr 3, 2018 at 9:09 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: >> >>> Hi >>> >>> On

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hi Hackers, We fixed the tests and refactored some of the code. All tests pass now. Attached is the reviewed patch. Sincerely, Joao and Victoria On Tue, Mar 20, 2018 at 10:05 AM, Dave Page wrote: > Hi > > This doesn't pass the Javascript tests for me. Please

Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

Hey Murtuza, This patch passed our test pipelines and it looks good. Do we have any tests around this behavior? Joao and Victoria

Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave, We've made updated our previous patch to fix the error messages. Attached are our updated patches. On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > Hi > > On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi