Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 27, 2022 at 1:55 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch to update the layout Id for the debugger, to resolve the issue > sometime the query tool layout is not loading due to the same layout ID for > the debugger.

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-27 Thread Nikhil Mohite
Hi Akshay, PFA patch to update the layout Id for the debugger, to resolve the issue sometime the query tool layout is not loading due to the same layout ID for the debugger. On Wed, Jun 22, 2022 at 11:24 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Tue, Jun 21, 2022 at 6:09 PM Nik

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-21 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 21, 2022 at 6:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA to fix the following issues: > 1. Fixed issue in set debugger arguments, Debugger is not getting started > if arguments loaded from SQLite database > > On Tue, Ju

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-21 Thread Nikhil Mohite
Hi Akshay, PFA to fix the following issues: 1. Fixed issue in set debugger arguments, Debugger is not getting started if arguments loaded from SQLite database On Tue, Jun 21, 2022 at 10:50 AM Akshay Joshi wrote: > Thanks, the patch applied > > On Tue, Jun 21, 2022 at 9:31 AM Nikhil Mohite < > n

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-20 Thread Akshay Joshi
Thanks, the patch applied On Tue, Jun 21, 2022 at 9:31 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the patch to fix jasmine test cases. > > On Mon, Jun 20, 2022 at 7:08 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch appl

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-20 Thread Nikhil Mohite
Hi Akshay, Please find the patch to fix jasmine test cases. On Mon, Jun 20, 2022 at 7:08 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Jun 20, 2022 at 1:12 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> PFA patch for fixing the following issu

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-20 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 20, 2022 at 1:12 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch for fixing the following issue in debugger. > 1. If debugger arguments are array debugger sets the *null* value to > parameters. > 2. Popup screen is not be

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-20 Thread Nikhil Mohite
Hi Akshay, PFA patch for fixing the following issue in debugger. 1. If debugger arguments are array debugger sets the *null* value to parameters. 2. Popup screen is not being closed if debug Package procedure/Function and select *Null* option. 3. Updated validation for debugger argument of the arr

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 14, 2022 at 6:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch v2, fixed all review comments. > > On Thu, Jun 9, 2022 at 4:53 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> *GUI:

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-09 Thread Akshay Joshi
Hi Nikhil Following are the review comments: *GUI:* - *Parameter dialog*: - Get the warning when parameter dialog gets opened Warning: [JSS] Could not find the referenced rule "disabled" in "makeStyles". - Debug button should not be enabled until all the required param