Re: [pgAdmin4]: Webpacking of static JS/CSS

On Thu, Jul 27, 2017 at 1:32 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > I have removed changes which are not relevant to the moving file to static > directory. > Committed the code for moving the javascript files from 'templates' to 'static' directory for most

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Thu, Jul 27, 2017 at 12:57 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > Please find attached patch 'move_js_files_static_dir' with --binary option. > As discussed, this patch should include changes related to moving the file to static directory only, and not

Re: [pgAdmin4]: Webpacking of static JS/CSS

Ok. I will send rebased patch. On Thu, Jul 27, 2017 at 10:32 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > > On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Surinder, >> >> 'delete_template_files.patch' is applied any more. >>

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Surinder, > > 'delete_template_files.patch' is applied any more. > Please send the rebased patches. > > I have also noticed in the 'move_js_files_to_static_directory.patch', > couple of modules have two

Re: [pgAdmin4]: Webpacking of static JS/CSS

Thanks, applied. On Wed, Jul 19, 2017 at 2:40 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch for few code review comments given by Ashesh. > > Thanks, > Surinder > > > On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: >

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi, PFA patch for few code review comments given by Ashesh. Thanks, Surinder On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: > >> That was a fun one to spot I'm sure! >> >

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: > That was a fun one to spot I'm sure! > ​Indeed, i had setup pgAdmin evn on Linux(as it works on Mac) and then i did `ls path/to/jquery.contextmenu.js`, it was spotted :) > > Thanks, committed. > > On Wed, Jul 19, 2017 at

Re: [pgAdmin4]: Webpacking of static JS/CSS

That was a fun one to spot I'm sure! Thanks, committed. On Wed, Jul 19, 2017 at 11:21 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Fix library path reference for `jquery.contextmenu'. This issue was only > reproducible on Linux machine. > So, i setup pgAdmin4 on Ubuntu

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi Fix library path reference for `jquery.contextmenu'. This issue was only reproducible on Linux machine. So, i setup pgAdmin4 on Ubuntu VM and tested the patch and it works. Please find attached patch. Thanks, Surinder On Tue, Jul 18, 2017 at 9:05 PM, Murtuza Zabuawala

Re: [pgAdmin4]: Webpacking of static JS/CSS

Great job Surinder, Load time ~2 sec on browser :) [image: Inline image 1] -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 18, 2017 at 9:01 PM, Dave Page wrote: > Thanks, applied. > > On Tue, Jul 18,

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi 1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added. 2. Column sorting for collection nodes sometimes failing when clicked on different collection nodes. Please find attached patch. Thanks Surinder On Tue, Jul 18, 2017 at 8:20 PM, Khushboo Vashi <

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 18, 2017 at 7:46 PM, Dave Page wrote: > Thanks - applied! > > Awesome work - on an average of 3 tests on my Mac, load time reduced from > 11.55s with v1.6 to 5.53s with GIT Head. > > Surinder, great work... > On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar < >

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Mon, Jul 17, 2017 at 2:15 PM, Dave Page wrote: > Hi > > On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> While this patch is in review, i have not attached patch for "unvendored >> libs" which is around 10MB in size

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While this patch is in review, i have not attached patch for "unvendored > libs" which is around 10MB in size and needs not to review. > Attached is the patch which can be reviewed. > >

Re: [pgAdmin4]: Webpacking of static JS/CSS

> On 12 Jul 2017, at 02:56, Ashesh Vashi wrote: > >> On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar >> wrote: >> Robert, >> >> I have attached two patches: >> >> 1. webpack_bundles.patch >> >> 2. unvendor_files.patch >>

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Robert, > > I have attached two patches: > > 1. webpack_bundles.patch > > 2. unvendor_files.patch > > in this email chain. > > If you didn't received those patches possibly due to large size of patch, >

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt wrote: > The last email on this chain from Surinder says that it isn't working on > IE and he will submit another patch. Are we missing that patch? Would you > like us to look at the previous patch? > ​Yes previous patch

Re: [pgAdmin4]: Webpacking of static JS/CSS

The last email on this chain from Surinder says that it isn't working on IE and he will submit another patch. Are we missing that patch? Would you like us to look at the previous patch? -- Rob On Jul 11, 2017 11:37 AM, "Dave Page" wrote: > Pivotal team; you guys

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi I found this patch won't work on IE, so i have fixed it and will send updated patch. On Tue, Jul 11, 2017 at 1:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > >> When you say "un-vendorising", do you

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > When you say "un-vendorising", do you mean removing them from the vendor > directory and adding them to packages.json so they're pulled in via > npm/yarn? (if so, good :-) ) > ​Yes.​ > > On Tue, Jul 11, 2017 at 7:34 AM,

Re: [pgAdmin4]: Webpacking of static JS/CSS

When you say "un-vendorising", do you mean removing them from the vendor directory and adding them to packages.json so they're pulled in via npm/yarn? (if so, good :-) ) On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Detailed changes:* > > ​1)

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi All, *​Things to discuss:* How to differentiate between a static and template JS ​​ . ​In Webpack we have to resolve paths to the modules same as in requirejs.config(base.html). but previously we were using 'current_app.javascripts' which holds the the path references for modules registered.

Re: [pgAdmin4]: Webpacking of static JS/CSS

Awesome work. Do you have an ETA for a feature complete test patch? On Fri, Jun 30, 2017 at 11:41 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > So far, I have been able to generate bundled > 'sources/generated/browser.js' which contains only three browser modules >

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi So far, I have been able to generate bundled 'sources/generated/browser.js' which contains only three browser modules (Server-group, Server, Database) and load it from 'browser/index.html'(entry point) and it works(except few JS error present in file). so will fix them. Then I will add one by