Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Thanks, applied. On Thu, Jun 21, 2018 at 4:51 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch to make SQL ASCII related changes compatible with Python 2.6. > Dictionary comprehension is not supported in Python 2.6. > > On Thu, Jun 21, 2018 at 6:27 PM,

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Thanks - patch applied! On Wed, Jun 20, 2018 at 3:17 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > Attached is the updated patch. (Playing with encodings is not at all fun > :( ) > > On Tue, Jun 19, 2018 at 2:23 AM, Dave Page wrote: > >> Hi >> >> On Mon, Jun

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, Attached is the updated patch. (Playing with encodings is not at all fun :( ) On Tue, Jun 19, 2018 at 2:23 AM, Dave Page wrote: > Hi > > On Mon, Jun 18, 2018 at 2:14 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch which includes the

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Mon, Jun 18, 2018 at 2:14 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch which includes the fix for Download CSV fail > in SQL_ASCII database, which is RM3250 > > This should fix

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, Attached is the updated patch which includes the fix for Download CSV fail in SQL_ASCII database, which is RM3250 This should fix RM3289 and RM3250. As they interrelated, sending the combined patch. Kindly review. On Fri, Jun 15, 2018 at

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> I am sorry I missed the attachment. :( >> PFA. >> > > It looks like the encoding names are getting munged somewhere. I see > you've accounted for

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > I am sorry I missed the attachment. :( > PFA. > It looks like the encoding names are getting munged somewhere. I see you've accounted for that to some degree in connection.py (you have both

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

I am sorry I missed the attachment. :( PFA. On Thu, Jun 14, 2018 at 11:34 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA updated patch. > > On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal <

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch. On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote: > Hi > > On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> >> On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 6, 2018 at 2:02 PM, Aditya

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > > On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>>

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: > Hi > > On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch as the previous one was not working as expected. I have >> tried to make it similar to that

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal wrote: > Hi Hackers, > > PFA updated patch as the previous one was not working as expected. I have > tried to make it similar to that of pgAdmin3 and you do not need to change > client_encoding as it is set now based on server encoding. It

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch as the previous one was not working as expected. I have tried to make it similar to that of pgAdmin3 and you do not need to change client_encoding as it is set now based on server encoding. It works fine with "view data" also. The only problem is, I cannot find

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 2:03 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi > > On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote: > >> >> >> On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> The

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote: > > > On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> The problem of SQL ASCII is solved with the patch, and not related to >> setting the client encoding of the sql window. >> > > No it's not. It

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Also, there are limitations in psycopg2 as well related to encoding, which makes it even more difficult to make behaviour similar to pgAdmin3 as there are encodings and decodings done at pyscopg2 end also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions |

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, The problem of SQL ASCII is solved with the patch, and not related to setting the client encoding of the sql window. I can see there is no SET call in pgAdmin3 for client_encoding. I can remove the SET client_encoding='UNICODE'; that will solve the problem. But, can you please let me

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 1:21 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > > On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>>

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch. The sqleditor change is sent separately and removed >> from current patch as suggested. >> The test cases were

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA updated patch. The sqleditor change is sent separately and removed > from current patch as suggested. > The test cases were running fine when the module was specified using --pkg

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch. The sqleditor change is sent separately and removed from current patch as suggested. The test cases were running fine when the module was specified using --pkg but were failing in complete run. Fixed that. Kindly review. Thanks and Regards, Aditya Toshniwal

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Aditya, > >> >> >> There is no change related to notifications in this patch. >> The below code is minor fix related to connection status of sql editor. >> Can you please share the code

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, > > > There is no change related to notifications in this patch. > The below code is minor fix related to connection status of sql editor. > Can you please share the code snippet if it is not the below. > > -# Check for the asynchronous notifies statements. > -

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Victoria/Joao, There is no change related to notifications in this patch. The below code is minor fix related to connection status of sql editor. Can you please share the code snippet if it is not the below. -# Check for the asynchronous notifies statements. -

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Aditya, Looks like there are changes in this patch that are related to notifications, these should go into a separate commit as they are not related to encoding. Also the tests are failing in our pipeline:

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, Please ignore previous patch. Fixed some linter issues. PFA updated patch. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 10:53 AM, Aditya Toshniwal <

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA the updated patch on this. I have tried to add test cases to check for different encoding database. In the test run, it will create a database, fire a query for a string, check if we get the output and drops the database. Kindly review. Thanks and Regards, Aditya Toshniwal

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Thu, May 31, 2018 at 1:20 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Victoria/Joao, > > On Thu, May 31, 2018 at 2:06 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Aditya, >> >> It looks ok and it passes CI. >> >> We have some

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Victoria/Joao, On Thu, May 31, 2018 at 2:06 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Aditya, > > It looks ok and it passes CI. > > We have some recommendations: > - These look like 2 different changes so they should be in separated > commits > If you are

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, It looks ok and it passes CI. We have some recommendations: - These look like 2 different changes so they should be in separated commits - Do we have test coverage for the bug that you are talking about? If not we should, to ensure this problem does not happen again in a future

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch after all the permutations, combinations for encoding for SQL_ASCII database. Also fixed a small glitch for sql editor connection status check. Please note, ERROR: invalid byte sequence for encoding "UTF8": 0xe9 0x73 is a Postgres DB error and not pgAdmin4 error.

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Thank you Victoria, Anthony. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, May 22, 2018 at 7:15 PM, Victoria Henry wrote: > Hi Aditya, > > We made a minor change to make the

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Aditya, We made a minor change to make the patch so the python linter can pass. Attached is the change we made. Everything else looks good. Sincerely, Victoria & Anthony On Tue, May 22, 2018 at 4:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > PFA updated

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi, PFA updated patch. Linter issues are fixed ( we dont have any linter setup for python :-( ) Regarding test cases, they run successfully on my system and the reason it failed for pivotal is timeout exception. I am sorry I can't help with that. Traceback (most recent call last): File

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Pivotal's buildbot is showing problems with this patch: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-linter/builds/66 (linter failed) https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/84 (tests failed) On

[pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA patch for RM#3289 where decode error was thrown on querying a SQL_ASCII database table. Please note, this problem occurs only on windows. Sample insert - insert into test_tab values ('é'); psycopg2 has a encodings dictionary where Postgres Database Encodings are mapped to python