Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Xuri Gong
Thanks! Dave Page 于2018年8月2日周四 下午5:32写道: > Hi > > On Thu, Aug 2, 2018 at 10:30 AM, Xuri Gong wrote: > >> Hi Dave, >> >> I have sent the new patch in a new thread because I thought you have >> missed this email... So please just ignore this patch and review the new >> patch. I also added some te

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Dave Page
Hi On Thu, Aug 2, 2018 at 10:30 AM, Xuri Gong wrote: > Hi Dave, > > I have sent the new patch in a new thread because I thought you have > missed this email... So please just ignore this patch and review the new > patch. I also added some test geo data in the new thread. You can add > postGIS ex

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Xuri Gong
Hi Dave, I have sent the new patch in a new thread because I thought you have missed this email... So please just ignore this patch and review the new patch. I also added some test geo data in the new thread. You can add postGIS extension and then import the data. If you just want to have a quick

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Dave Page
Hi Can you suggest any freely available data sets that can be used to test this with please? I don't have any geo databases. As a quick review-point, I don't see any documentation updates with the patch. Thanks. On Wed, Jul 25, 2018 at 9:13 AM, Xuri Gong wrote: > Hi Anthony and Dave, > > Than

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-07-25 Thread Xuri Gong
Hi Anthony and Dave, Thank you for your suggestions and I have implemented this visualiser:). I add button in the cell and when it's clicked the geometry is shown in a map. Here is the screenshots of it: https://photos.app.goo.gl/fQVBRcmZJ3YcPLcL8 Attached is the patch for this geometry viewer. P

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-25 Thread Anthony DeBarros
> > I agree the map is the ultimate tool. However, I do think that being able > to quickly view a single geometry from within the grid makes a lot of sense > - and for users who want to easily visualise a single geometry, will be a > great deal more convenient than the map. > > Note that I'm not ta

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-25 Thread Dave Page
Hi On Fri, May 25, 2018 at 5:00 AM, Xuri Gong wrote: > Hi Dave, >> >> Thank you very much for your feedback. >> >> That's a good idea to see individual images. But in my opinion, for >> geometry data, user often tend to see not only the individual shapes, but >> also the locations, spatial relat

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-24 Thread Xuri Gong
> > Hi Dave, > > Thank you very much for your feedback. > > That's a good idea to see individual images. But in my opinion, for > geometry data, user often tend to see not only the individual shapes, but > also the locations, spatial relations and distribution in a map. For > example, if the geomet

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-24 Thread Dave Page
Hi On Wed, May 23, 2018 at 1:23 PM, Xuri Gong wrote: > Hi Dave/Team, > > My name is Xuri Gong. I am working on implementing geospatial data viewer > in pgAdmin4. > > I wrote a design document for the viewer[1] according to the related > issue[2] and I am wondering if it is a proper design. It wo

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-24 Thread Xuri Gong
Hi Joao, Thank you very much for these detailed guidelines. I will follow these standards and test both JavaScript and Python code before sending a patch. For the new panel, I am learning React these days and will spend three months implementing this viewer so I think I can do it. Thanks. >

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-23 Thread Joao De Almeida Pereira
Hello Xuri, Welcome to the pgadmin project. Let us give you some guidelines/pointers to help you out starting. As a general rule of thumb all the new development should be done in a separate file that contain the functionality itself. For Javascript, - Has you might have notice we started some tim

Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-23 Thread Xuri Gong
Hi Dave/Team, My name is Xuri Gong. I am working on implementing geospatial data viewer in pgAdmin4. I wrote a design document for the viewer[1] according to the related issue[2] and I am wondering if it is a proper design. It would be great if there are any suggestions. I have read the #pgAdmin

Re: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-23 Thread Xuri Gong
Hi Anthony, Thank you for your suggestion. I received some feedback from PostGIS community and wrote a design document for the viewer[1]. I plan to create a new panel beside the output data grid in the sqleditor to show map. It would be great if there are any suggestions. It's necessary for me to

Re: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-22 Thread Anthony DeBarros
Xuri, This is a fabulous idea and congratulations on being selected for GSoC! Personally, I would find this functionality very helpful. Have you received any feedback, and are you still looking for more? Also, if you have not already, I would highly recommend you coordinate with Dave Page and hi

GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-05-10 Thread Xuri Gong
Hi everyone, My name is Xuri Gong from PostGIS community. I am selected for Google Summer of Code(GSoC) 2018 and will be working on implementing geospatial data viewer in pgAdmin4 for PostGIS. I find the related feature "Support map view for PostGIS query result sets" in this link: https://redmi