Thanks, applied.
On Mon, May 4, 2020 at 10:59 AM Akshay Joshi
wrote:
> Hi Dave
>
> Patch looks good to me except the below line gets commented by mistake (if
> i am not wrong)
>
> # ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo
> complete-bundle.sh failed; exit 1; }
>
>
> On
Hi Dave
Patch looks good to me except the below line gets commented by mistake (if
i am not wrong)
# ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo
complete-bundle.sh failed; exit 1; }
On Mon, May 4, 2020 at 3:02 PM Dave Page wrote:
> Here's a rebased version.
>
> On Mon, Ma
Here's a rebased version.
On Mon, May 4, 2020 at 7:33 AM Akshay Joshi
wrote:
> Hi Dave
>
> On Fri, May 1, 2020 at 5:21 PM Dave Page wrote:
>
>> Akshay, are you happy with this patch?
>>
>
>The patch is not applied to the latest code.
>
>>
>> On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote:
Hi Dave
On Fri, May 1, 2020 at 5:21 PM Dave Page wrote:
> Akshay, are you happy with this patch?
>
The patch is not applied to the latest code.
>
> On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote:
>
>>
>>
>> On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.co
Akshay, are you happy with this patch?
On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote:
>
>
> On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> The code looks good to me. The package building was tested by Neel and we
>> found that the venv
On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> The code looks good to me. The package building was tested by Neel and we
> found that the venv was built with Python 3+ but the runtime was built
> against Python 2.7.
> As per Dave, Neel may have n
Hi,
The code looks good to me. The package building was tested by Neel and we
found that the venv was built with Python 3+ but the runtime was built
against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is
working fine on Dav'e system. So, we can commit the pa
On Mon, Apr 27, 2020 at 3:28 PM Dave Page wrote:
>
>
> On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote:
>>
>>>
>>>
>>> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <
>>> khushboo.va...@enter
On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
>
> On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote:
>
>>
>>
>> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> As we support PostgreSQL
On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote:
>
>
> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> As we support PostgreSQL >=9.5, do we need to maintain SQL templates for
>> older versions?
>>
>
> Yes, for now. We're not activel
On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Dave,
>
> As we support PostgreSQL >=9.5, do we need to maintain SQL templates for
> older versions?
>
Yes, for now. We're not actively removing support for old PostgreSQL
versions, just not testing the
Hi Dave,
As we support PostgreSQL >=9.5, do we need to maintain SQL templates for
older versions?
Thanks,
Khushboo
On Mon, Apr 27, 2020 at 3:16 PM Dave Page wrote:
> The attached patch removes support for Python 2.7 in general from the
> macOS appbundle build, thus also removing special handli
The attached patch removes support for Python 2.7 in general from the macOS
appbundle build, thus also removing special handling for use of the system
Python installation.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise
13 matches
Mail list logo
