Re: [pgAdmin][RM-7149]: [React] Port preferences dialog to React.

2022-04-03 Thread Akshay Joshi
Thanks, the patch applied. On Fri, Apr 1, 2022 at 5:29 PM Nikhil Mohite wrote: > Hi Akshay, > > PFA patch to fix the issue with maximize button on preferences dialog. > > On Tue, Mar 29, 2022 at 3:35 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> PFA updated pa

Re: [pgAdmin][RM-7149]: [React] Port preferences dialog to React.

2022-04-01 Thread Nikhil Mohite
Hi Akshay, PFA patch to fix the issue with maximize button on preferences dialog. On Tue, Mar 29, 2022 at 3:35 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA updated patch resolved the following issues in the preferences dialog: > >1. Show a single note in the

Re: [pgAdmin][RM-7149]: [React] Port preferences dialog to React.

2022-03-29 Thread Nikhil Mohite
Hi Akshay, PFA updated patch resolved the following issues in the preferences dialog: 1. Show a single note in the binary path. 2. Resolved issue in the keyboard shortcut. On Wed, Mar 23, 2022 at 12:14 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please fin

Re: [pgAdmin][RM-7149]: [React] Port preferences dialog to React.

2022-03-21 Thread Akshay Joshi
Thanks, the patch applied. Screenshots are still not the latest. Take all the screenshots with the latest changes and send them back. On Mon, Mar 21, 2022 at 10:00 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch v2 resolved all the review comments. > > On Wed,

Re: [pgAdmin][RM-7149]: [React] Port preferences dialog to React.

2022-03-09 Thread Akshay Joshi
Hi Nikhil Below are the review comments: *GUI:* - By default, all nodes should be expanded, and at least one node should be selected (Check existing behavior). - Reduce the space between the expand/collapse (>) icon and the tress node label. It is most likely icons that are taking up