Re: [pgAdmin][RM5050] Language node code coverage.

Thanks, patch applied. On Mon, Jan 20, 2020 at 11:43 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > I have accommodated all the changes mentioned in the review. > > On Thu, Jan 16, 2020 at 5:54 PM Akshay Joshi < > akshay.jo...@enterpr

Re: [pgAdmin][RM5050] Language node code coverage.

Hi Akshay, Please find the updated patch. I have accommodated all the changes mentioned in the review. On Thu, Jan 16, 2020 at 5:54 PM Akshay Joshi wrote: > Hi Pradip > > Below are the review comments: > >- Format the JSON file. Rename the JSON file from >'language_testcases.json' to 'l

Re: [pgAdmin][RM5050] Language node code coverage.

Hi Pradip Below are the review comments: - Format the JSON file. Rename the JSON file from 'language_testcases.json' to 'language_test_data.json'. - For consistency please follow the naming convention used in ' *cast_test_data.json*' file. For example, in Cast we have used 'name' a