Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Thanks, applied. On Wed, Jul 3, 2019 at 2:30 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch with corrections in the print messages. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Murtuza Zabuawala
Hi, PFA updated patch with corrections in the print messages. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 3, 2019 at 5:36 PM Dave Page wrote: > Hi > > On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi > wrote: > >> Hi Murtu

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Hi On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi wrote: > Hi Murtuza > > I have tested the patch and I think below string should be modified: > Server(Type: #ppas) is not supported for the Resource Groups module - > Skipped > Server version(12) is not supported for the Resource Groups module -

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Akshay Joshi
Hi Murtuza I have tested the patch and I think below string should be modified: Server(Type: #ppas) is not supported for the Resource Groups module - Skipped Server version(12) is not supported for the Resource Groups module - Skipped It misleads, that server type 'ppas' is not supported for

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-02 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. Please note that our framework considers test cases from all the modules as one single test case, If we need module wise detailed summary report for the reverse engineered SQL tests then we may have to change the framework. Regards, Murtuza On Tue, Jul 2, 2019 at 5

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-02 Thread Dave Page
Hi On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ++ Attaching patch > > On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the updated patch, >> >> - Added a mechanism t

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-02 Thread Dave Page
I think you missed attaching the patch! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 2 Jul 2019, at 08:16, Murtuza Zabuawala > wrote: > > Hi Dave, > > Please find the updated patch, > > -

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-02 Thread Murtuza Zabuawala
++ Attaching patch On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find the updated patch, > > - Added a mechanism to check for supported minimum/maximum version and a > server type in the framework. > > Please review. > > > Tha

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-02 Thread Murtuza Zabuawala
Hi Dave, Please find the updated patch, - Added a mechanism to check for supported minimum/maximum version and a server type in the framework. Please review. Thanks, Murtuza On Mon, Jul 1, 2019 at 7:55 PM Dave Page wrote: > Hi > > On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala < > murtuza

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-01 Thread Dave Page
Hi On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add RE-SQL tests for Roles & Resource Group nodes. > Resource Groups don't exist in PG =Running the test cases for 'Regression - PG 11'= runTest (r