Re: Windows build system cleanup

2020-06-01 Thread Dave Page
Thanks - committed. I've updated the Jenkins jobs that run Make.bat with the new variable names. I'll keep an eye out for any failures and fix anything that pops up. Once it's stable I'll remove all the old variables. On Mon, Jun 1, 2020 at 8:53 AM Akshay Joshi wrote: > Hi Dave > > Patch looks g

Re: Windows build system cleanup

2020-06-01 Thread Akshay Joshi
Hi Dave Patch looks good to me, did eyeball review. On Fri, May 29, 2020 at 1:43 PM Dave Page wrote: > Stupid line endings confusing git :-(. Here's another attempt. > > On Fri, May 29, 2020 at 7:30 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> Unable to apply the

Re: Windows build system cleanup

2020-05-28 Thread Akshay Joshi
Hi Dave Unable to apply the patch. Can you please rebase and send it again. On Thu, May 28, 2020 at 9:04 PM Dave Page wrote: > Here's a patch to cleanup the windows build system and make sure 64 bit > builds work with modern tools. It also updates the README with a new > from-scratch setup proc

Windows build system cleanup

2020-05-28 Thread Dave Page
Here's a patch to cleanup the windows build system and make sure 64 bit builds work with modern tools. It also updates the README with a new from-scratch setup process that makes it much easier to setup a Windows build/dev machine. Please review, but don't apply as I'll need to do that in conjunct