Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Sarah McAlear]

Hi!

We fixed that issue and created a new patch

.

Thanks!

On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng  wrote:

> Here's the Redmine link
>
> https://redmine.postgresql.org/issues/2644
>
> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng  wrote:
>
>> Hi Surinder!
>>
>> Are you referring to the green message popup? If so, it also appears to
>> be happening on master. We'll log a bug in our backlog and Redmine and
>> prioritize it. We agree that it needs to be fixed, but don't think it's
>> unrelated to this patch.
>>
>> Thanks!
>> Violet & Sarah
>>
>> On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Please find attached screenshot.
>>>
>>> On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Sarah,

 We noticed that due to this patch, the alert style of "Database
 connected" message is changed.
 Can you please look into this?

 Thanks,
 Surinder

 On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> ​Hi,
>
> ​The updated patch looks good to me.
>
> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear 
> wrote:
>
>> As discussed with Surinder, we have created a Redmine ticket for his
>> 4th comment regarding the error message not showing up when the app can't
>> be reached. This issue existed prior to this patch and should be
>> prioritized.
>>
>> https://redmine.postgresql.org/issues/2640
>>
>> Thanks!
>> Matt & Sarah
>>
>> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear 
>> wrote:
>>
>>> Hi Surinder!
>>>
>>> I am not able to see anything different from what I see on Master
>>> with or without the patch applied. I tried adjusting the preferences. I 
>>> did
>>> update the dashboard.js to instantiate a new object, great idea!
>>>
>>> Thanks,
>>> Sarah
>>>
>>>
>>>
>>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Wenlin,

 On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang 
 wrote:

> Hi Surinder,
>
>Thanks for your review.
>
>We have changed the indentation for _dashboard.scss file and
> also removed the style about icon-postgres:before, like
> margin-top,etc, but we are not sure if it is perfectly aligned now, 
> you can
> add further change to it.
>
> As the second comment, I'm sorry I'm not sure what's the
> problem, could you please clarify it? Because we replace css with scss
> right now, dashboard.css doesn't exist. So maybe you are looking at 
> the css
> file that are complied by the scss?
>
 ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
 ​In dashboard.js can we change `return DashboardAlert;` to `return
 new DashboardAlert();`
 and then we can remove the instances being created(var
 alertDashboard = new AlertDashboard();) from dashboard.js, and simply
 use `AlertDashboard.info('message')`.


> For the fourth comment, we tried the steps you suggested on
> master branch, the error is not shown either. So it should be an 
> existing
> issue. But if you want to see the error message, navigate to 
> "Servers" at
> the top of browser, then navigate back to postgresql server, then you 
> will
> see the error message.
>
 ​The error in console will appear when you selected a database
 which is connected and stop the backend Python server because the 
 request
 for graphs for database level will fail and there is no response 
 returned
 from server.
 It might be not reproducible to you If you set the refresh rate to
 higher value (i.e. Preferences > Graphs) in preferences. Just set 
 refresh
 rate to 1 for all dashboard graphs and repeat the steps.

>
>
> Thanks,
>
> Wenlin 
>
>
>
> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>> Review comments:
>>
>>1.
>>
>>For consistency, we use two spaces for indentation in CSS
>>files. Four spaces are used in _dashboard.scss file. The
>>configurations are defined in web/.editorconfig file.
>>2.
>>
>>In,dashboard.css Can we return 

Re: [pgAdmin4][RM2586] Cleanup feature test

[Harshal Dhumal]

Hi,

Please find attached updated patch. In this patch I have removed unused
imports.
Regarding ajax calls on slow network/computer I have already taken care of
those.
Before sending first version of patch I tested this on Murtuza's machine
and also
tested on slow machine as well.


Thanks,
Harshal

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Aug 7, 2017 at 8:55 AM, Sarah McAlear  wrote:

> Hi Harshal!
>
> There are a few files in which there are leftover imports that are not
> needed anymore:
>
>- PGDataypeFeatureTest
>- PgadminPage
>- CheckForXssFeatureTest
>- CheckDebuggerForXssFeatureTest
>
>
> We also noticed that there were quite a few time.sleep functions that
> were removed. This seems great overall, but we think that some of them were
> in place because of varying network and computer speeds. So for example, in
> QueryToolFeatureTest, there is an ajax call that was followed by a
> time.sleep to ensure that it had finished executing before continuing to
> execute. Removing this may reintroduce some flakiness. If there are no
> issues with flakiness after this patch, it seems like a great idea. We ran
> the tests a few times and didn't notice any flakiness, but we're unsure if
> it will be a problem on a different system.
>
> Thanks!
> Wenlin & Sarah
>
>
> On Wed, Aug 2, 2017 at 9:32 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch to improve feature test execution time.
>> Now on my machine overall execution time is cut down to 280 seconds from
>> 400+ seconds
>>
>> Changes:
>>
>> 1. Removed fixed python time.sleeps where ever possible.
>> 2. Removed connect to server test cases.
>> 3. Query tool test cases:
>>  i. Merged 3 test cases On demand result on scroll, grid select all
>> and column select all.
>>  ii. Merged 3 test cases Explain query, Explain query with verbose
>> and Explain query with cost.
>>  iii. Merged 3 test cases Explain analyze query, Explain analyze with
>> buffers and Explain analyze with timing.
>> 4. Improved debugger XSS test case execution time.
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/pgadmin/feature_tests/connect_to_server_feature_test.py b/web/pgadmin/feature_tests/connect_to_server_feature_test.py
deleted file mode 100644
index 97e96f2..000
--- a/web/pgadmin/feature_tests/connect_to_server_feature_test.py
+++ /dev/null
@@ -1,84 +0,0 @@
-##
-#
-# pgAdmin 4 - PostgreSQL Tools
-#
-# Copyright (C) 2013 - 2017, The pgAdmin Development Team
-# This software is released under the PostgreSQL Licence
-#
-##
-
-import time
-from selenium.webdriver import ActionChains
-
-import config as app_config
-from regression.feature_utils.base_feature_test import BaseFeatureTest
-from regression.python_test_utils import test_utils
-
-
-class ConnectsToServerFeatureTest(BaseFeatureTest):
-"""
-Tests that a database connection can be created from the UI
-"""
-scenarios = [
-("Test database connection", dict())
-]
-
-def before(self):
-connection = test_utils.get_db_connection(self.server['db'],
-  self.server['username'],
-  self.server['db_password'],
-  self.server['host'],
-  self.server['port'],
-  self.server['sslmode'])
-test_utils.drop_database(connection, "acceptance_test_db")
-test_utils.create_database(self.server, "acceptance_test_db")
-test_utils.create_table(self.server, "acceptance_test_db", "test_table")
-
-def runTest(self):
-"""This function tests that a database connection can be created from
-the UI"""
-self.assertEqual(app_config.APP_NAME, self.page.driver.title)
-self.page.wait_for_spinner_to_disappear()
-
-self._connects_to_server()
-self._tables_node_expandable()
-
-def after(self):
-self.page.remove_server(self.server)
-
-connection = test_utils.get_db_connection(self.server['db'],
-  self.server['username'],
-  self.server['db_password'],
-  self.server['host'],
-  self.server['port'],
-  self.server['sslmode'])
-test_utils.drop_database(connection, "acceptance_test_db")
-
-  

Is there a CLI for creating the object tree?

[Tim Uckun]

Hi.

I want to write a tool for PG and I would like to recreate the object tree
in pgadmin on the disk.  For example.

db
   schemas
   public
  tables
  some_table.sql
I looked at the source code and it seems like you guys read the definitions
from the DB and then apply a template. This is great and I could rewrite
all that in my own code but I was hoping it would be possible to avoid all
that work.   Do you guys know of any type of CLI or a library that would
help me accomplish this? I also thought of just calling out to pg_dump and
then writing a parser for that file but again I would rather take a
shortcut if one exists.

Thanks.

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Violet Cheng]

Here's the Redmine link

https://redmine.postgresql.org/issues/2644

On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng  wrote:

> Hi Surinder!
>
> Are you referring to the green message popup? If so, it also appears to be
> happening on master. We'll log a bug in our backlog and Redmine and
> prioritize it. We agree that it needs to be fixed, but don't think it's
> unrelated to this patch.
>
> Thanks!
> Violet & Sarah
>
> On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Please find attached screenshot.
>>
>> On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Sarah,
>>>
>>> We noticed that due to this patch, the alert style of "Database
>>> connected" message is changed.
>>> Can you please look into this?
>>>
>>> Thanks,
>>> Surinder
>>>
>>> On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 ​Hi,

 ​The updated patch looks good to me.

 On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear 
 wrote:

> As discussed with Surinder, we have created a Redmine ticket for his
> 4th comment regarding the error message not showing up when the app can't
> be reached. This issue existed prior to this patch and should be
> prioritized.
>
> https://redmine.postgresql.org/issues/2640
>
> Thanks!
> Matt & Sarah
>
> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear 
> wrote:
>
>> Hi Surinder!
>>
>> I am not able to see anything different from what I see on Master
>> with or without the patch applied. I tried adjusting the preferences. I 
>> did
>> update the dashboard.js to instantiate a new object, great idea!
>>
>> Thanks,
>> Sarah
>>
>>
>>
>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Wenlin,
>>>
>>> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang 
>>> wrote:
>>>
 Hi Surinder,

Thanks for your review.

We have changed the indentation for _dashboard.scss file and
 also removed the style about icon-postgres:before, like
 margin-top,etc, but we are not sure if it is perfectly aligned now, 
 you can
 add further change to it.

 As the second comment, I'm sorry I'm not sure what's the
 problem, could you please clarify it? Because we replace css with scss
 right now, dashboard.css doesn't exist. So maybe you are looking at 
 the css
 file that are complied by the scss?

>>> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
>>> ​In dashboard.js can we change `return DashboardAlert;` to `return
>>> new DashboardAlert();`
>>> and then we can remove the instances being created(var
>>> alertDashboard = new AlertDashboard();) from dashboard.js, and simply
>>> use `AlertDashboard.info('message')`.
>>>
>>>
 For the fourth comment, we tried the steps you suggested on
 master branch, the error is not shown either. So it should be an 
 existing
 issue. But if you want to see the error message, navigate to "Servers" 
 at
 the top of browser, then navigate back to postgresql server, then you 
 will
 see the error message.

>>> ​The error in console will appear when you selected a database which
>>> is connected and stop the backend Python server because the request for
>>> graphs for database level will fail and there is no response returned 
>>> from
>>> server.
>>> It might be not reproducible to you If you set the refresh rate to
>>> higher value (i.e. Preferences > Graphs) in preferences. Just set 
>>> refresh
>>> rate to 1 for all dashboard graphs and repeat the steps.
>>>


 Thanks,

 Wenlin 



 On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi
> Review comments:
>
>1.
>
>For consistency, we use two spaces for indentation in CSS
>files. Four spaces are used in _dashboard.scss file. The
>configurations are defined in web/.editorconfig file.
>2.
>
>In,dashboard.css Can we return function object in return
>instead of function class itself, this will eliminate the need of 
> creating
>function object every time we use info and error?
>3.
>
>On Dashboard, I can see Postgres icon is misaligned compared
>to other icons in Getting Started section. It is not related
>to this patch. adjusting margin 

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Violet Cheng]

Hi Surinder!

Are you referring to the green message popup? If so, it also appears to be
happening on master. We'll log a bug in our backlog and Redmine and
prioritize it. We agree that it needs to be fixed, but don't think it's
unrelated to this patch.

Thanks!
Violet & Sarah

On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Please find attached screenshot.
>
> On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Sarah,
>>
>> We noticed that due to this patch, the alert style of "Database
>> connected" message is changed.
>> Can you please look into this?
>>
>> Thanks,
>> Surinder
>>
>> On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> ​Hi,
>>>
>>> ​The updated patch looks good to me.
>>>
>>> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear 
>>> wrote:
>>>
 As discussed with Surinder, we have created a Redmine ticket for his
 4th comment regarding the error message not showing up when the app can't
 be reached. This issue existed prior to this patch and should be
 prioritized.

 https://redmine.postgresql.org/issues/2640

 Thanks!
 Matt & Sarah

 On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear 
 wrote:

> Hi Surinder!
>
> I am not able to see anything different from what I see on Master with
> or without the patch applied. I tried adjusting the preferences. I did
> update the dashboard.js to instantiate a new object, great idea!
>
> Thanks,
> Sarah
>
>
>
> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Wenlin,
>>
>> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang 
>> wrote:
>>
>>> Hi Surinder,
>>>
>>>Thanks for your review.
>>>
>>>We have changed the indentation for _dashboard.scss file and
>>> also removed the style about icon-postgres:before, like
>>> margin-top,etc, but we are not sure if it is perfectly aligned now, you 
>>> can
>>> add further change to it.
>>>
>>> As the second comment, I'm sorry I'm not sure what's the
>>> problem, could you please clarify it? Because we replace css with scss
>>> right now, dashboard.css doesn't exist. So maybe you are looking at the 
>>> css
>>> file that are complied by the scss?
>>>
>> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
>> ​In dashboard.js can we change `return DashboardAlert;` to `return
>> new DashboardAlert();`
>> and then we can remove the instances being created(var alertDashboard
>> = new AlertDashboard();) from dashboard.js, and simply
>> use `AlertDashboard.info('message')`.
>>
>>
>>> For the fourth comment, we tried the steps you suggested on
>>> master branch, the error is not shown either. So it should be an 
>>> existing
>>> issue. But if you want to see the error message, navigate to "Servers" 
>>> at
>>> the top of browser, then navigate back to postgresql server, then you 
>>> will
>>> see the error message.
>>>
>> ​The error in console will appear when you selected a database which
>> is connected and stop the backend Python server because the request for
>> graphs for database level will fail and there is no response returned 
>> from
>> server.
>> It might be not reproducible to you If you set the refresh rate to
>> higher value (i.e. Preferences > Graphs) in preferences. Just set refresh
>> rate to 1 for all dashboard graphs and repeat the steps.
>>
>>>
>>>
>>> Thanks,
>>>
>>> Wenlin 
>>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi
 Review comments:

1.

For consistency, we use two spaces for indentation in CSS
files. Four spaces are used in _dashboard.scss file. The
configurations are defined in web/.editorconfig file.
2.

In,dashboard.css Can we return function object in return
instead of function class itself, this will eliminate the need of 
 creating
function object every time we use info and error?
3.

On Dashboard, I can see Postgres icon is misaligned compared to
other icons in Getting Started section. It is not related to
this patch. adjusting margin top will fix it.
4.

I tried to test out Error message displayed, but I encounter an
error(screenshot attached).
Steps to reproduce:
   - Open pgAdmin4 in browser
   - Connect to PostgreSQL Server, Keep dashboard tab open.
 

Re: Can someone tell me what this code does ?

[Murtuza Zabuawala]

Hi,

On Wed, Aug 9, 2017 at 8:19 PM, Dave Cramer  wrote:

> So what is the policy of the project? Ideally the cruft should be removed.
>
> Would a patch doing so be committed?
>
​Yes, I guess.​

Dave Cramer
>
> On 9 August 2017 at 00:28, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Yes, you are correct, at a moment that's all it does.
>>
>> On Tue, Aug 8, 2017 at 6:37 PM, Dave Cramer  wrote:
>>
>>> Hi,
>>>
>>> I guess my question was a bit vague. I get that it loads drivers. But
>>> note it does not actually put them anywhere.
>>>
>>> First it creates a dict
>>> sets the attribute in the app
>>> loads the drivers dynamically
>>> and returns an empty dict.
>>>
>>> From what I can tell this:
>>>
>>> DriverRegistry.load_drivers()
>>>
>>> is all it does?
>>>
>>>
>>>
>>>
>>>
>>>
>>> Dave Cramer
>>>
>>> On 7 August 2017 at 23:35, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 This piece of code allow us to dynamically import all the available
 driver modules from '../utils/driver/' directory into our application.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Tue, Aug 8, 2017 at 4:20 AM, Dave Cramer 
 wrote:

> I'm fairly new to Python so excuse my naiveté.
>
> This code: in web/pgadmin/utils/driver/__init__.py  does not appear
> to load the drivers into the drivers dictionary ? Or am I missing 
> something
>
> def init_app(app):
> drivers = dict()
>
> setattr(app, '_pgadmin_server_drivers', drivers)
> DriverRegistry.load_drivers()
>
> return drivers
>
>
>
> Dave Cramer
>


>>>
>>
>

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Surinder Kumar]

Hi Sarah,

We noticed that due to this patch, the alert style of "Database connected"
message is changed.
Can you please look into this?

Thanks,
Surinder

On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> ​Hi,
>
> ​The updated patch looks good to me.
>
> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear  wrote:
>
>> As discussed with Surinder, we have created a Redmine ticket for his 4th
>> comment regarding the error message not showing up when the app can't be
>> reached. This issue existed prior to this patch and should be prioritized.
>>
>> https://redmine.postgresql.org/issues/2640
>>
>> Thanks!
>> Matt & Sarah
>>
>> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear 
>> wrote:
>>
>>> Hi Surinder!
>>>
>>> I am not able to see anything different from what I see on Master with
>>> or without the patch applied. I tried adjusting the preferences. I did
>>> update the dashboard.js to instantiate a new object, great idea!
>>>
>>> Thanks,
>>> Sarah
>>>
>>>
>>>
>>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Wenlin,

 On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang  wrote:

> Hi Surinder,
>
>Thanks for your review.
>
>We have changed the indentation for _dashboard.scss file and also
> removed the style about icon-postgres:before, like margin-top,etc,
> but we are not sure if it is perfectly aligned now, you can add further
> change to it.
>
> As the second comment, I'm sorry I'm not sure what's the problem,
> could you please clarify it? Because we replace css with scss right now,
> dashboard.css doesn't exist. So maybe you are looking at the css file that
> are complied by the scss?
>
 ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
 ​In dashboard.js can we change `return DashboardAlert;` to `return new
 DashboardAlert();`
 and then we can remove the instances being created(var alertDashboard =
 new AlertDashboard();) from dashboard.js, and simply
 use `AlertDashboard.info('message')`.


> For the fourth comment, we tried the steps you suggested on master
> branch, the error is not shown either. So it should be an existing issue.
> But if you want to see the error message, navigate to "Servers" at the top
> of browser, then navigate back to postgresql server, then you will see the
> error message.
>
 ​The error in console will appear when you selected a database which is
 connected and stop the backend Python server because the request for graphs
 for database level will fail and there is no response returned from server.
 It might be not reproducible to you If you set the refresh rate to
 higher value (i.e. Preferences > Graphs) in preferences. Just set refresh
 rate to 1 for all dashboard graphs and repeat the steps.

>
>
> Thanks,
>
> Wenlin 
>
>
>
> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>> Review comments:
>>
>>1.
>>
>>For consistency, we use two spaces for indentation in CSS files.
>>Four spaces are used in _dashboard.scss file. The configurations
>>are defined in web/.editorconfig file.
>>2.
>>
>>In,dashboard.css Can we return function object in return instead
>>of function class itself, this will eliminate the need of creating 
>> function
>>object every time we use info and error?
>>3.
>>
>>On Dashboard, I can see Postgres icon is misaligned compared to
>>other icons in Getting Started section. It is not related to this
>>patch. adjusting margin top will fix it.
>>4.
>>
>>I tried to test out Error message displayed, but I encounter an
>>error(screenshot attached).
>>Steps to reproduce:
>>   - Open pgAdmin4 in browser
>>   - Connect to PostgreSQL Server, Keep dashboard tab open.
>>   - Navigate to the database which is connected.
>>   - Now disconnect pgAdmin4 python server.
>>   ​
>>
>> ​Here I mean Stop Python server. I​


>
>>1.
>>   - ​
>>   - No error message is displayed on Dashboard because it breaks
>>   in JS as xhr.responseText is empty.
>>   However, it might be an existing issue.
>>
>> Thanks,
>> Surinder
>>
>> On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang 
>> wrote:
>>
>> Hi Ashesh,
>>>
>>> That's correct. This patch just changed alert style in the
>>> 'tabs', such as Dependency and Dependents.
>>>
>>> Thanks
>>>
>>> Wenlin
>>>
>>> On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi <
>>>