Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-06-21 Thread Shirley Wang
Hi all, We've updated the borders around alerts so that they are more prominent. [image: error alert (1).png] [image: success alert (2).png] [image: Neutral alert.png] Everything else stays the same. Let me know your thoughts if any. Shirley & Shruti On Wed, May 31, 2017 at 3:02 PM Shirley

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-21 Thread Dave Page
Hi Looking good. The only issue I found so far occurs if you open the query tool, then immediately click on the history tab: TypeError: Cannot read property 'CodeMirror' of undefined at Object. (sqleditor.js:882) at triggerEvents (backbone.js:208) at Object.trigger (backbone.js:148)

pgAdmin 4 commit: Maintain a client-side cache of preference values, po

2017-06-21 Thread Dave Page
Maintain a client-side cache of preference values, populated using an async call. Fixes #2487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67fd119de834afd022f95c8c153a3b0c8c7b7fae Author: Khushboo Vashi

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

2017-06-21 Thread Dave Page
Thanks, applied. On Wed, Jun 21, 2017 at 11:25 AM, Murtuza Zabuawala wrote: > Apologies disregard my previous patch also, > > I missed changes in "pga_job.js". > > Thanks to Harshal pointing that out. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

pgAdmin 4 commit: Update MatView and pgAgent modules to work with recen

2017-06-21 Thread Dave Page
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9f6fb95456a540287ef7aca02ff885068b64cd5 Author: Murtuza Zabuawala

pgAdmin 4 commit: Handle missing/dropped synonyms gracefully. Fixes #25

2017-06-21 Thread Dave Page
Handle missing/dropped synonyms gracefully. Fixes #2503 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9736cbd74c723ce914fa3beaafe03fd284daf45 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-21 Thread Sarah McAlear
Hello! Thank you for committing the patch! We are currently looking into CEF ( https://bitbucket.org/chromiumembedded/cef) as an alternative to QTWebKit. So far it looks promising. It works on all platforms. It is the base for Google Chrome, so it should be maintained for some time to come.

pgAdmin 4 commit: Vendorize React. This is required at this time becaus

2017-06-21 Thread Dave Page
Vendorize React. This is required at this time because we need to modify it to work with QtWebKit. The patch to do that has been submitted upstream; if accepted, we can un-vendorize again. Branch -- master Details ---

Re: [pgAdmin4][PATCH] Consolidating Selection Colors

2017-06-21 Thread Dave Page
Thanks, patch applied. On Tue, Jun 20, 2017 at 9:39 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a patch that consolidates selection colors in the drop down menu > and browser tree to match the light blue agreed upon in the styleguide. > > Thanks, > Shirley and Shruti

pgAdmin 4 commit: Consolidate selection colors in the drop down menu an

2017-06-21 Thread Dave Page
Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=281b67952a94bc1599536c2b6c469252f233aa69 Author: Shruti B Iyer