Re: Windows testing required: Updated runtime

2017-07-06 Thread Melvin Davidson
Dave, The good and the ugly. The good.I download and installed the patch from https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe I restarted Windows and it now starts in 15 secs, down from 20 secs. The ugly.The version is not usable. The screen/menu is incomprehensible. System

[pgadmin-hackers][patch] delete icon width in security labels form

2017-07-06 Thread Joao De Almeida Pereira
Hello Hackers, We found a discrepancy with the width of inserted columns in some backform tables. It is at least present in Create Table -> Security [tab] -> clicking [+] for new rows under each of Privileges and Security Labels. In this case, the cell containing the delete icon is spaced

[pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

2017-07-06 Thread Sarah McAlear
Hi Hackers! Attached is a minor patch that enables pretty html output of our karma test results. While running yarn test:karma, visit localhost:9876/debug.html to see test output. Thanks, Matt and Sarah diff --git a/web/karma.conf.js b/web/karma.conf.js index 39697ca7..e9b0e062 100644 ---

Fix clear history option [pgAdmin4][RM2535]

2017-07-06 Thread Harshal Dhumal
Hi, Please find attached patch to fix clear history functionality in query tool. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/history/history_collection.js

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
Maybe, but it's pretty clearly broken, so whilst you're fixing the template for that value, it would make sense to fix the UI too :-) On Thu, Jul 6, 2017 at 1:42 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > This behaviour is from beginning I think and it is

Build failed in Jenkins: pgadmin4-master-python26 #339

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add some useful make targets for bundling and linting. [Dave Page] Remove unused minimisation code [Dave Page] UI tweaks for the query history. [Dave Page] In subnodes

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi Dave, This behaviour is from beginning I think and it is inherited from pgAdmin3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 6, 2017 at 5:58 PM, Dave Page wrote: > Hi > > On Thu, Jul 6, 2017 at

Build failed in Jenkins: pgadmin4-master-python35 #219

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add some useful make targets for bundling and linting. [Dave Page] Remove unused minimisation code [Dave Page] UI tweaks for the query history. [Dave Page] In subnodes

Re: [pgAdmin4][Patch] Fix the issue in save password checkbox in "Create - Server" dialog.

2017-07-06 Thread Dave Page
Thanks, applied. On Thu, Jul 6, 2017 at 1:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue, where user is not able to save the > password even if config.py has option "ALLOW_SAVE_PASSWORD = True". > RM#2540 > > -- > Regards, >

pgAdmin 4 commit: Ensure the save password option is enabled when creat

2017-07-06 Thread Dave Page
Ensure the save password option is enabled when creating a server. Fixes #2540 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca7fe9a520468b7452a1efa44e1575bb0bb8c22d Author: Murtuza Zabuawala Modified

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 12:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in Function, Procedure & Trigger Function > modules where user was not able to update object if user changes the code > definition. > RM#2537 > This still

Re: make subnode rows the same height for rows without dropdowns

2017-07-06 Thread Dave Page
Thanks, applied. On Wed, Jul 5, 2017 at 8:34 PM, George Gelashvili wrote: > Hello Hackers, > > We found that in subnodes without dropdowns, the rows had smaller height, > making them appear unintentionally different than those with dropdowns. An > example place in the

pgAdmin 4 commit: In subnodes without dropdowns, the rows had smaller h

2017-07-06 Thread Dave Page
In subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. Make them the same. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5bedf088e880de8949d68f0b0564fff62f3d5a7

pgAdmin 4 commit: UI tweaks for the query history.

2017-07-06 Thread Dave Page
UI tweaks for the query history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2cbaaef7124b41be91bf34d704f0d3f61cf7b0c Author: Matthew Kleiman Modified Files --

pgAdmin 4 commit: Remove unused minimisation code

2017-07-06 Thread Dave Page
Remove unused minimisation code Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1291841d988050d99804e0a0f30396bee20675cf Modified Files -- Makefile | 3 --- web/tools/minimise.py | 65

Re: Tree view icon samples

2017-07-06 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 12:30 PM, Anthony DeBarros wrote: > > > Hi, > > Looking forward to this and the other design updates coming! Regarding the > PNG examples, I was wondering whether that is meant to show all the new > icons being developed or no? When I expand the

[pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Function, Procedure & Trigger Function modules where user was not able to update object if user changes the code definition. RM#2537 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git