Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

On 20 Jul 2017, at 23:02, Shirley Wang wrote: >> >> Iirc, we did some back and forth over that about 18 months ago, as dialogues >> didn't look quite right without the bold - and I do think that it looks a >> little light on your mockup. I don't think there's a hard

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

> > > Iirc, we did some back and forth over that about 18 months ago, as > dialogues didn't look quite right without the bold - and I do think that it > looks a little light on your mockup. I don't think there's a hard > requirement they match table headers; they are distinct types of header. > >

Build failed in Jenkins: pgadmin4-master-python34 #244

See Changes: [Dave Page] Improve the history UI. -- [...truncated 336.15 KB...] ResourceGroupsAddTestCase (Add resource groups)

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hello, Attached is a refactor that extracts the keyAction function in the sqlEditor and placed it into a keyboard_shortcuts file. The extracted code is unit tested. I did not look at the feature tests. We are planning on diving into it a bit more but maybe not immediately. Up next we will be

Re: [pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

Thanks, applied. On Thu, Jul 20, 2017 at 8:23 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > This patch updates the SCSS files of the styleguide to move all the colors > into variables to be easier to use in the application. > > Thanks > Joao && Matt > --

Re: Request a feature

Nick, We were looking at adding this feature but ran into the same problem you are describing, e.g. when to include and when to not include headers. Honestly we were waiting for people to start using the new UX for the differing copy and paste functionality and waiting to see what people said.

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Murtuza, Is there a particular reason you choose the keyboard shortcuts that you choose. When we were looking at this earlier to see what was being used elsewhere we discovered: jetbrains cmd+/ pycharmcmd+/ SublimeCtrl+/ Toggle line comment Ctrl+Shift+/ Toggle

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Ah, OK - I was working on them one at a time. Thanks, patches applied! On Thu, Jul 20, 2017 at 7:01 PM, Matthew Kleiman wrote: > Hi Dave, > > In our previous email, the second patch fixed the linting issue from the > first patch. > However, we've remade these two patches

[pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

Hi Hackers, This patch updates the SCSS files of the styleguide to move all the colors into variables to be easier to use in the application. Thanks Joao && Matt diff --git a/pgaweb/static/css/styleguide/_alert.scss b/pgaweb/static/css/styleguide/_alert.scss index 26680b7..2c85514 100644 ---

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi Dave, In our previous email, the second patch fixed the linting issue from the first patch. However, we've remade these two patches so they both pass the linting test. Thanks, Matt and João On Thu, Jul 20, 2017 at 12:56 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find patch attached, There were two issues, >> 1) We removed the default button to clear the

pgAdmin 4 commit: Add the Flask-Paranoid module for a little extra, wel

Add the Flask-Paranoid module for a little extra, well, paranoia in web mode. Fixes #2584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64f3a559abadd62b9c49b78e1a937191fb0253ef Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find patch attached, There were two issues, > 1) We removed the default button to clear the editor window, it > broke _clear_query_tool() functionality. > 2) The buttons

Re: Unified server/desktop config

LOL! On Thu, Jul 20, 2017 at 5:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Oops sorry my bad, I did not removed it. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 20, 2017 at 10:22

Re: Unified server/desktop config

Oops sorry my bad, I did not removed it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Partial patch for feature test got

Re: Unified server/desktop config

Hi Dave, Partial patch for feature test got included in you patch :) On Thu, Jul 20, 2017 at 9:33 PM, Dave Page wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does

Unified server/desktop config

All, Attached is a patch that aims to allow us to have a standardised config that will work out of the box for both web and desktop modes. It does this by doing two things: 1) The runtime sets SERVER_MODE in the Python environment before starting the app. If this value is set, then it overrides

pgAdmin 4 commit: Remove debug logging of the URL map which is extremel

Remove debug logging of the URL map which is extremely long now, and not of a great deal of use. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83ac1f3555066322077b1cdc212ee7ff74cf3322 Modified Files -- web/pgadmin/__init__.py |

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Surinder & Murtuza! We are actually working on that right now. We should be sending a patch soon. Thanks! Shruti & Sarah On Thu, Jul 20, 2017 at 7:52 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Can the code related to Menu KeyEvents be moved out into a

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Murtuza, Can the code related to Menu KeyEvents be moved out into a separate file say 'menu_actions.js' if feasible ? As the more functionality will be added to sqleditor, codemirror and its file menu in future, the codebase will eventually increase. It will ease writing jasmine test cases as

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hello Dave, Did you use the latest one patch we sent? We realised that this was an issue in the second email we sent. Thanks Joao On Thu, Jul 20, 2017, 8:15 AM Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > >> Hi again! >>

Re: [pgAdmin4][Patch]: To make session more secure in web mode

On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > It is based on Flask-Login module but > 1) Flask-Login will mark a user as logged out when it detects that an > existing session suddenly appears to come from a different originating IP > address or