Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Sarah McAlear
Hi! We fixed that issue and created a new patch . Thanks! On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng wrote: > Here's the Redmine link > >

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-10 Thread Harshal Dhumal
Hi, Please find attached updated patch. In this patch I have removed unused imports. Regarding ajax calls on slow network/computer I have already taken care of those. Before sending first version of patch I tested this on Murtuza's machine and also tested on slow machine as well. Thanks,

Is there a CLI for creating the object tree?

2017-08-10 Thread Tim Uckun
Hi. I want to write a tool for PG and I would like to recreate the object tree in pgadmin on the disk. For example. db schemas public tables some_table.sql I looked at the source code and it seems like you guys read the definitions from the

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Violet Cheng
Here's the Redmine link https://redmine.postgresql.org/issues/2644 On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: > Hi Surinder! > > Are you referring to the green message popup? If so, it also appears to be > happening on master. We'll log a bug in our backlog and

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Violet Cheng
Hi Surinder! Are you referring to the green message popup? If so, it also appears to be happening on master. We'll log a bug in our backlog and Redmine and prioritize it. We agree that it needs to be fixed, but don't think it's unrelated to this patch. Thanks! Violet & Sarah On Thu, Aug 10,

Re: Can someone tell me what this code does ?

2017-08-10 Thread Murtuza Zabuawala
Hi, On Wed, Aug 9, 2017 at 8:19 PM, Dave Cramer wrote: > So what is the policy of the project? Ideally the cruft should be removed. > > Would a patch doing so be committed? > ​Yes, I guess.​ Dave Cramer > > On 9 August 2017 at 00:28, Murtuza Zabuawala

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Surinder Kumar
Hi Sarah, We noticed that due to this patch, the alert style of "Database connected" message is changed. Can you please look into this? Thanks, Surinder On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > ​The updated patch looks good to me. > >