Re: pgAdmin4 v4.12 candidate builds

2019-08-19 Thread Fahar Abbas
Thanks for sharing candidate builds and will update the testing status. Kind Regards, On Tue, Aug 20, 2019 at 11:21 AM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.12 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-08-20-1/ > > Fahar, can you please ve

pgAdmin4 v4.12 candidate builds

2019-08-19 Thread Akshay Joshi
Hi All, pgAdmin4 v4.12 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-08-20-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +9

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Thanks everyone for working it out. On Tue, Aug 20, 2019, 6:54 AM Akshay Joshi wrote: > Thanks Khushboo, patch applied. > > It works, I have tested for multiple database servers. > > On Tue, Aug 20, 2019 at 10:03 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please

pgAdmin 4 commit: Update version for release

2019-08-19 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c8aefc01e72545be1fb667fbbebc770aadacb4d Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files c

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Thanks Khushboo, patch applied. It works, I have tested for multiple database servers. On Tue, Aug 20, 2019 at 10:03 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the test cases. > > Thanks, > Khushboo > > On Tue, Aug 20, 2019 at 9:52

pgAdmin 4 commit: Fix the Transaction Status failed test cases.

2019-08-19 Thread Akshay Joshi
Fix the Transaction Status failed test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed76787b763542540d4b200ec0fae9c3d2022ad1 Author: Khushboo Vashi Modified Files -- .../sqleditor/tests/test_transaction_status.py | 1

Re: Transaction Status Python Tests

2019-08-19 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the test cases. Thanks, Khushboo On Tue, Aug 20, 2019 at 9:52 AM Akshay Joshi wrote: > Hi Yosry > > Not able to figure out the cause today as well, I have comment out the > disable auto commit test cases for Transaction Status. Please look into it > on

pgAdmin 4 commit: Added missing file for function selectivity feature.

2019-08-19 Thread Akshay Joshi
Added missing file for function selectivity feature. Fixes #4333 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3e4721a909b72a2cfad67359b5640e6710260a2 Modified Files -- .../functions/ppas/sql/12_plus/get_support_functions.sql

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Not able to figure out the cause today as well, I have comment out the disable auto commit test cases for Transaction Status. Please look into it once you will have some time. On Mon, Aug 19, 2019 at 6:05 PM Yosry Muhammad wrote: > This behaviour is very strange. Maybe another test run

pgAdmin 4 commit: 1) Ensure compound triggers should be displayed under

2019-08-19 Thread Akshay Joshi
1) Ensure compound triggers should be displayed under Views. Fixes #4638. 2) Ensure Truncate option should be available for Compound Triggers. Fixes #4641. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d6f07a035e68555154c5a1f7764c855db12e38

pgAdmin 4 commit: Comment out the failed Transaction Status API test ca

2019-08-19 Thread Akshay Joshi
Comment out the failed Transaction Status API test cases for successful Jenkins build Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=624f229ce752f533f8d38adba69ab5329d406249 Modified Files -- .../sqleditor/tests/test_transaction_

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Test cases with auto commit disabled gets failed for following scenario only: - Run all test cases on more than one server "*--pkg all* *--exclude feature_tests"*. For first sever all the tests passed and for second onwards fail for all. - If you run only sqleditor test case

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
This behaviour is very strange. Maybe another test running in parallel is enabling auto-commit or commiting the transaction? There is a problem with my machine right now, can you skip this test for this release if the issue is not resolved? Sorry for the inconvenience. On Mon, Aug 19, 2019, 2:30

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Can you send me the error message? Unfortunately there is a problem with my machine right now I am unable to investigate it myself, I am very sorry for the inconvenience. On Mon, Aug 19, 2019, 2:08 PM Akshay Joshi wrote: > Hi Yosry > > We have tried a lot to figure out the issue but didn't find

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry We have tried a lot to figure out the issue but didn't find the actual cause. Can you please figure out and send the patch asap, I'll have to create candidate build tomorrow. On Mon, Aug 19, 2019 at 1:22 PM Yosry Muhammad wrote: > Hi Akshay, > > I am sorry I do not have access to my ma

Re: Query Tool JS Minimal Refactoring

2019-08-19 Thread Yosry Muhammad
Jasmine tests passed on my machine, I will take another look once I have access to my machine. On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi wrote: > Hi Yosry > > Jasmine tests are failing, can you please fix those and resend the patch. > > On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad > wrote:

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Hi Akshay, I am sorry I do not have access to my machine right now. I will try to work on it (and the JS patch) once I get the chance to. On Mon, Aug 19, 2019, 9:49 AM Akshay Joshi wrote: > Hi Yosry > > Test cases are failing on our build machines. When I reviewed your patch I > have run test c

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Test cases are failing on our build machines. When I reviewed your patch I have run test cases with paramaster "*--pkg tools.sqleditor.tests*" on multiple database servers and every time test case has been passed. But on build machines we run test cases with parameter "*--pkg all* *--exc

Re: [RM#3605] View Data: Deleting N number of rows makes first N number of rows disable

2019-08-19 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 14, 2019 at 1:18 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where using view data, when we try to > delete N row, it will make the first N row from the grid disabled, you try > to double click on t