[pgAdmin4][Patch]: RM #3798 Unable to launch query tool window through Browser if user select any language except English under preferences section

2018-12-06 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3798 Unable to launch query tool window through Browser if user select any language except English under preferences section. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explain plan as JPEG/SVG format

2018-12-06 Thread Akshay Joshi
Hi Dave On Thu, Dec 6, 2018 at 2:45 PM Dave Page wrote: > Hi > > On Thu, Dec 6, 2018 at 6:51 AM Akshay Joshi > wrote: > >> Hi Hackers >> >> I didn't find the solution to show embedded SVG in Internet Explorer, so >> I have disabled the "

[pgAdmin4][Patch]: RM #3805 Result table cell view/edit popup dialog stopped resizing horizontally

2018-12-10 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #*3805* Result table cell view/edit popup dialog stopped resizing horizontally. This fix will work for RM #*3083* as well. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3805

pgAdmin 4 commit: Update release notes.

2018-12-10 Thread Akshay Joshi
Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90b2d2e5360b0816354d8cc3f9b32be6c09c383e Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + 1 file changed, 1 insertion(+)

[pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-17 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify NULL values in CSV export. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3780.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-18 Thread Akshay Joshi
On Tue, Dec 18, 2018 at 2:49 PM Dave Page wrote: > Hi > > On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify >> NULL

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-18 Thread Akshay Joshi
Hi Dave Attached is the modified patch to fix review comments. On Tue, Dec 18, 2018 at 3:00 PM Akshay Joshi wrote: > > > On Tue, Dec 18, 2018 at 2:49 PM Dave Page wrote: > >> Hi >> >> On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < >> akshay.jo...@ent

pgAdmin 4 commit: Fix an issue when user define Cast from smallint->tex

2018-12-19 Thread Akshay Joshi
Fix an issue when user define Cast from smallint->text is created. Fixes #3753 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7515e08578e7e586350407adaef2bd2eaebae165 Modified Files -- docs/en_US/release_notes_3_7.rst

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-20 Thread Akshay Joshi
On Thu, Dec 20, 2018 at 4:48 PM Dave Page wrote: > Hi > > On Thu, Dec 20, 2018 at 10:09 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Thu, Dec 20, 2018 at 3:08 PM Dave Page wrote: >> >>> Hi >>> >

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-21 Thread Akshay Joshi
ackages/werkzeug/wrappers.py", > line 82, in _iter_encoded > for item in iterable: > File > "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py", > line 848, in gen > csv_writer.writerows(results) > File "/Users/dpage/git/pgadm

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-21 Thread Akshay Joshi
hat behaviour and will commit the current patch. > > Thanks! > > On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have modified the condition, it won't through any exception. Attached >>

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2018-12-23 Thread Akshay Joshi
On Fri, 21 Dec 2018, 19:45 Dave Page > > On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Fri, 21 Dec 2018, 18:52 Dave Page > >>> Hi >>> >>> Looks good - I just found one issue;

pgAdmin 4 commit: Ensure that null values handled properly in CSV downl

2019-01-01 Thread Akshay Joshi
Ensure that null values handled properly in CSV download. Fixes #3780 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41c028f944806b34fbfb06a0a146672aa1e18d2b Modified Files -- Make.bat |

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

2019-01-01 Thread Akshay Joshi
Hi Dave/Hackers On Mon, Dec 24, 2018 at 7:47 AM Akshay Joshi wrote: > > > On Fri, 21 Dec 2018, 19:45 Dave Page >> >> >> On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>&

pgAdmin 4 commit: Fixed following:

2019-01-02 Thread Akshay Joshi
Fixed following: - Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem. - Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter - Alignment

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-02 Thread Akshay Joshi
ular.ttf| Bin >>>> 0 -> 171676 bytes >>>> >> >> > >> > web/pgadmin/static/img/collapse_expand.svg | 15 + >>>> >> >> > >> > web/pgadmin/static/img/forgot_password.svg | 283 >>>>

pgAdmin 4 commit: Update copyright notices for 2019

2019-01-02 Thread Akshay Joshi
Update copyright notices for 2019 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e23d307c56e92453dc5ea108214c52bdb2409705 Author: Murtuza Zabuawala Modified Files -- docs/en_US/code_review.rst

Re: [pgAdmin] [RM#3839] Update copyright notices for 2019

2019-01-02 Thread Akshay Joshi
e tool. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure auto complete should works when first identifi

2019-01-03 Thread Akshay Joshi
Ensure auto complete should works when first identifier in the FROM clause needs quoting. Fixes #3809 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a130d68c5760e584d9d0fe7a6e9760aaf890639 Modified Files -- docs/en_US/release_no

pgAdmin 4 commit: Ensure auto complete should works for columns from a

2019-01-03 Thread Akshay Joshi
Ensure auto complete should works for columns from a schema-qualified table. Fixes #3810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c455dda3ce2731fe0e603b96f640fb64623ff85c Modified Files -- docs/en_US/release_notes_3_7.rst

[pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server

2019-01-04 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3549.patch Description

pgAdmin 4 commit: Further style tweaks.

2019-01-07 Thread Akshay Joshi
Further style tweaks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d361e604c1a0191f81c2e47a709d569bcbc441c7 Author: Aditya Toshniwal Modified Files -- runtime/splash.png | Bin 13559 -> 19406 byte

pgAdmin 4 commit: Update message catalogs

2019-01-07 Thread Akshay Joshi
Update message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2857332b7a54862654df2879485f541bb155ab8 Modified Files -- web/pgadmin/messages.pot | 6907 ++--- .../translations/de/LC_M

pgAdmin 4 commit: Update version for release

2019-01-07 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=561ee7556f5eff32e7d10f0c8769a80ef332f345 Modified Files -- docs/en_US/{release_notes_3_7.rst => release_notes_4_0.rst} | 2 +- web/config.py

pgAdmin 4 commit: Update the release note version in toctree

2019-01-07 Thread Akshay Joshi
Update the release note version in toctree Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea514115c36b8439060d00bbfe15ece934a3cd39 Modified Files -- docs/en_US/release_notes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin4 v4.0 candidate builds

2019-01-07 Thread Akshay Joshi
Hi All, pgAdmin4 v4.0 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-01-07-1 Fahar, can you please verify it for release on Thursday. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue while creating export job. Fixes #3856

2019-01-07 Thread Akshay Joshi
Fixed an issue while creating export job. Fixes #3856 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c7742f3b2f7885386df9a77bf2ea18e7c9af98a Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_0.rst

Re: pgAdmin4 v4.0 candidate builds

2019-01-08 Thread Akshay Joshi
Hi All We have rewrap the installers as we fixed RM #3856. New candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-01-08-1 On Mon, Jan 7, 2019 at 5:57 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.0 candidate builds and source can be found a

[pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab

2019-01-09 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3842 pg_catalogs schema should not displayed in properties tab. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3842.patch Description: Binary data

[pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11

2019-01-09 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11. Order of commands has been changed in PostgreSQL 11 "https://github.com/postgres/postgres /commit/921059bd66c7fb1230c705d3b1a65940800c4cbb" Please review it. -- *Ak

Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11

2019-01-09 Thread Akshay Joshi
Hi Attached is the modified patch. I have fixed the similar code for Backup and Restore as well along with this patch. On Thu, Jan 10, 2019 at 12:26 PM Dave Page wrote: > Hi > > On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi > wrote: > >> Hi Hackers, >> >> Atta

[pgAdmin4][Patch] - RM 3505 Incorrect SQL generated for tables created using inherited columns

2019-01-10 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3505 Incorrect SQL generated for tables created using inherited columns. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* diff --git a/web/pgadmin/browser/server_groups/servers

pgAdmin 4 v4.0 released

2019-01-10 Thread Akshay Joshi
for Windows and macOS are available now, along with a Python Wheel, Docker Container and source code tarball from: https://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Tag REL-4_0 has been created.

2019-01-10 Thread Akshay Joshi
Tag REL-4_0 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_0 Log Message --- Tag v4.0

pgAdmin 4 commit: Ensure that last row of table data should be visible

2019-01-11 Thread Akshay Joshi
Ensure that last row of table data should be visible and user will be able to add new row. Fixes #3866 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4a2f1b8cd8d880f3b365445211b448f217085dc Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin4][RM3866] No way to add row to a table in v4.0

2019-01-11 Thread Akshay Joshi
> Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Update message catalog and version for release.

2019-01-11 Thread Akshay Joshi
Update message catalog and version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b135f2932357d189de1479811c2385dc11bb2c5 Modified Files -- runtime/Info.plist | 4 +- runtime/pgAdmin4

pgAdmin4 v4.1 candidate builds

2019-01-11 Thread Akshay Joshi
Hi All, pgAdmin4 v4.1 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-01-12-1 Fahar, can you please verify it ASAP for release on Tuesday. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 v4.1 released

2019-01-15 Thread Akshay Joshi
/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Tag REL-4_1 has been created.

2019-01-15 Thread Akshay Joshi
Tag REL-4_1 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_1 Log Message --- Tag v4.1

Re: [pgAdmin4][RM3837] Trigger when option syntax error

2019-01-15 Thread Akshay Joshi
gt; > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure long string should be wrap in alertify dialogs

2019-01-15 Thread Akshay Joshi
Ensure long string should be wrap in alertify dialogs. Fixes #3695 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b0c81126c3246f93a68c72eb6e29dd111548b33 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rs

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-15 Thread Akshay Joshi
gineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Proper error should be thrown when server group is cr

2019-01-15 Thread Akshay Joshi
Proper error should be thrown when server group is created with existing name. Fixes #3693 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a359d9d774c8170d5e128fd05825e977409313f Author: Aditya Toshniwal Modified Files -- docs/e

Re: [pgAdmin4][RM3693] Message "Error saving properties Click on Detail" displayed if user create server group with same name

2019-01-15 Thread Akshay Joshi
| Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed following issues:

2019-01-15 Thread Akshay Joshi
Fixed following issues: - Process watcher made fixed width with header changes, time details rounded to 2 decimals - Query history will show "No query history" if no query fired. Query editor default size increased. - Fixed a bug where New folder create button not working when in List mode and

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-15 Thread Akshay Joshi
;> you please share the screenshot. >>> >> >> >>> >> >> >>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >>> >> >> >>> >> >> -- >>> >> >> Dave Page >>> >> >> Blog: http://pgsnake.blogspot.com >>> >> >> Twitter: @pgsnake >>> >> >> >>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> >> The Enterprise PostgreSQL Company >>> >> > >>> >> > >>> >> > >>> >> > -- >>> >> > Thanks and Regards, >>> >> > Aditya Toshniwal >>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> >> > "Don't Complain about Heat, Plant a tree" >>> >> >>> >> >>> >> >>> >> -- >>> >> Dave Page >>> >> Blog: http://pgsnake.blogspot.com >>> >> Twitter: @pgsnake >>> >> >>> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> The Enterprise PostgreSQL Company >>> > >>> > >>> > >>> > -- >>> > Thanks and Regards, >>> > Aditya Toshniwal >>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> > "Don't Complain about Heat, Plant a tree" >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed SQL for foreign table options. Fixes #3453

2019-01-15 Thread Akshay Joshi
Fixed SQL for foreign table options. Fixes #3453 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7b050830553e50332a01122e097bcf98e5ed789 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rst

Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab

2019-01-15 Thread Akshay Joshi
ftware Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed execution time to show Hours part for long runn

2019-01-15 Thread Akshay Joshi
Fixed execution time to show Hours part for long running queries in Query Tool. Fixes #3475 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dec43d98dc589010b91bb40512fe0f026d6f004f Author: Aditya Toshniwal Modified Files -- docs/

Re: [pgAdmin4][RM3475] Execution time for a query or function shows only minutes part and not hour part

2019-01-15 Thread Akshay Joshi
added. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM3837] Trigger when option syntax error

2019-01-16 Thread Akshay Joshi
1:19 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the updated patch. Kindly review. >> >> On Tue, Jan 15, 2019 at 6:05 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >>

pgAdmin 4 commit: Fixed SQL for when clause while creating Trigger. Fix

2019-01-16 Thread Akshay Joshi
Fixed SQL for when clause while creating Trigger. Fixes #3837 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6bbcaf6b27682f37e13d653c95a92f2ba7c646be Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rst

pgAdmin 4 commit: 1) Proper SQL should be generated when creating/chang

2019-01-16 Thread Akshay Joshi
1) Proper SQL should be generated when creating/changing column with custom type argument. Fixes #3838 2) Proper SQL should be generated when create procedure with custom type arguments. Fixes #3846 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

pgAdmin 4 commit: Add right border on selected tree item.

2019-01-16 Thread Akshay Joshi
Add right border on selected tree item. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f779378e8a1089e33697fcf716c1c5f95d766139 Author: Aditya Toshniwal Modified Files -- .../databases/schemas/functions/static/js/procedure.js

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-16 Thread Akshay Joshi
indly review. > > On Wed, Jan 16, 2019 at 8:30 PM Dave Page > wrote: > >> >> >> On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks patch applied without Tree Changes. >>> >>>

pgAdmin 4 commit: Fixed controls alignment responsiveness to docker siz

2019-01-17 Thread Akshay Joshi
Fixed controls alignment responsiveness to docker size change. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48660508ce52a34a94b41baceb3ff49bb134f22c Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/js/panel

pgAdmin 4 commit: Inline edbspl trigger functions should not be visible

2019-01-17 Thread Akshay Joshi
Inline edbspl trigger functions should not be visible in Grant Wizard. Fixes #3740 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a163edec7ab014032dc652673917510fc907cc99 Modified Files -- docs/en_US/release_notes_4_2.rst

pgAdmin 4 commit: Proper SQL should be generated when create function w

2019-01-18 Thread Akshay Joshi
Proper SQL should be generated when create function with return type as custom type argument. Fixes #3774 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69f689522446c3581a80e198736deeea6d0cc488 Modified Files -- docs/en_US/releas

pgAdmin 4 commit: Handle text wrapping in alertify dialog only when it

2019-01-18 Thread Akshay Joshi
Handle text wrapping in alertify dialog only when it is required. Regression of #3695 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06ae799d0285dca9f5bdb0e01d4f4b6f48bfa7f1 Author: Aditya Toshniwal Modified Files -- web/pgadmin

pgAdmin 4 commit: Correct order of Save and Cancel button for json/json

2019-01-18 Thread Akshay Joshi
Correct order of Save and Cancel button for json/jsonb editing. Fixes #3891 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27cdb835cb2f40f873bd09de1c352c4d519c8b57 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_not

pgAdmin 4 commit: Data should be updated properly for FTS Configuration

2019-01-21 Thread Akshay Joshi
Data should be updated properly for FTS Configurations, FTS Dictionaries, FTS Parsers and FTS Templates. Fixes #3897 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7cbe0ff4a03d2b076b53dcda6e8dc1632fd3c1f Modified Files -- docs/e

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

2019-01-21 Thread Akshay Joshi
853 - Incorrect SQL > generated for create script of domain type interval with precision. ERROR: > syntax error at or near "[" > > The patch includes the fix as well as the API test case to verify the > reverse Engineered SQL. > > Thanks, > Khushboo > -- *Akshay

pgAdmin 4 commit: Ensure that Backup/Restore button should work on sing

2019-01-21 Thread Akshay Joshi
Ensure that Backup/Restore button should work on single click. Fixes #3811 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aedb3997b05fcd85d055b89cb55ae279937b79ee Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin4][Patch] - RM 3811 - Backup / restore job launch button needs two click

2019-01-21 Thread Akshay Joshi
Thanks patch applied On Mon, Jan 21, 2019 at 2:44 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3811 - Backup / restore job > launch button needs two click > > Thanks, > Khushboo > -- *Akshay J

pgAdmin 4 commit: Ensure that file format combo box value should not re

2019-01-21 Thread Akshay Joshi
Ensure that file format combo box value should not retained when hidden files checkbox is toggled. Fixes #3840 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9794d8ab45db83f220a6fa95a08a87e03930d3f Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox

2019-01-21 Thread Akshay Joshi
review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-21 Thread Akshay Joshi
. >> Also I have added jasmine test cases for the same >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

2019-01-21 Thread Akshay Joshi
> *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields

2019-01-21 Thread Akshay Joshi
The root cause of the issue is bootstrap switch, which has been replaced > with bootstrap4-toggle application wide. > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

2019-01-21 Thread Akshay Joshi
e rows. So, now the rows will be pushed > in the backgrid collection in bunches on scroll event to fix this issue. > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - RM 3800 - User can not add database with special characters under DB restriction for add server

2019-01-21 Thread Akshay Joshi
> Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure that database restriction of server dialog sho

2019-01-21 Thread Akshay Joshi
Ensure that database restriction of server dialog should work with special characters. Fixes #3800 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ffeb4be457beb44ea086956495bb137a8fc7d2c Author: Khushboo Vashi Modified Files --

Re: [pgAdmin4][RM3871] Alignment issue with IE Browser

2019-01-21 Thread Akshay Joshi
Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed alignment of tree arrow icons for Internet Expl

2019-01-21 Thread Akshay Joshi
Fixed alignment of tree arrow icons for Internet Explorer. Fixes #3871 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fc2e032f3ed1e166d955af1c3fa4e6f834f7c04 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_

pgAdmin 4 commit: 1. Proper alignment of help message with date time co

2019-01-21 Thread Akshay Joshi
1. Proper alignment of help message with date time control. 2. Added help-block class for helpMessageClassName. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0d2c4536111a08dffbe94941b897c33bf239750 Author: Ganesh Jaybhay Modified Files ---

Re: [pgAdmin4][patch] Few UI improvements and fixes

2019-01-21 Thread Akshay Joshi
helpMessageClassName > > Kindly review. > > Regards, > Ganesh Jaybhay > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

2019-01-21 Thread Akshay Joshi
is the patch to throw alert warning when user reloads or closes > the browser. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --

pgAdmin 4 commit: Remove session from the grid on the dashboard when it

2019-01-22 Thread Akshay Joshi
Remove session from the grid on the dashboard when it is terminated. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd311ca8a951743b9e3696aa297ce5d6be8aab3a Author: Murtuza Zabuawala Modified Files -- web/pgadmin/dashboard/static

Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session

2019-01-22 Thread Akshay Joshi
abuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Drop-down should be closed when click on any other to

2019-01-22 Thread Akshay Joshi
Drop-down should be closed when click on any other toolbar button. Fixes #3858 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e7381414ff12fe1541d71de501b3c3dee97365f Modified Files -- docs/en_US/release_notes_4_2.rst

pgAdmin 4 commit: Fixed keyboard navigation for dialog tabs. Fixes #386

2019-01-22 Thread Akshay Joshi
Fixed keyboard navigation for dialog tabs. Fixes #3862 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f731ab730bb74be12d5bf5e8658de04992fcb4fe Author: Harshal Dhumal Modified Files -- docs/en_US/release_notes_4_2.rst

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-22 Thread Akshay Joshi
Thanks patch applied. On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > The patch looks good to me. > > On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> &g

pgAdmin 4 commit: Fixed keyboard navigation for Select2 and Privilege c

2019-01-22 Thread Akshay Joshi
Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea87d6da8f8bcd76bff8737c3d311cb2254668cc Author: Harshal Dhumal Modified Files -- docs/en_US/release_

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

2019-01-22 Thread Akshay Joshi
3919 has been created by Harshal. > > Thanks, > Khushboo > > > On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Thu, Jan 17, 2019 at 7:22 PM Har

pgAdmin 4 commit: Proper SQL should be generated when create domain of

2019-01-22 Thread Akshay Joshi
Proper SQL should be generated when create domain of type interval with precision. Fixes #3853 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6bae69b6f71ee68886aae5db895952af067fff1 Author: Khushboo Vashi Modified Files -- docs

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

2019-01-22 Thread Akshay Joshi
Thanks patch applied On Tue, Jan 22, 2019 at 5:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >>

pgAdmin 4 commit: Fixed domain sql regression test for EPAS

2019-01-22 Thread Akshay Joshi
Fixed domain sql regression test for EPAS Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11ab1918eae1759d5f1c34cd1a7b216c6b45cf5e Modified Files -- .../servers/databases/schemas/domains/tests/test_domain_sql.py | 7 --- 1 f

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

2019-01-22 Thread Akshay Joshi
closure of the browser or browser tab is intended >> >> before proceeding." >> > >> > It also warns on refresh. >> >> Name: "Confirm on close or refresh" >> Desc: "Confirm closure or refresh of the browser or browser tab is >&

pgAdmin 4 commit: Ensure that browser should warn before close or refre

2019-01-22 Thread Akshay Joshi
Ensure that browser should warn before close or refresh. Fixes #3849 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcfe0929d3935f94882d82c665a94b467a8f315f Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

2019-01-22 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 23, 2019 at 11:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA revised patch as per review. > > On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > &

pgAdmin 4 commit: Improve application level exception handling for unha

2019-01-22 Thread Akshay Joshi
Improve application level exception handling for unhandled exceptions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f298590400cf5d2921a07e200086e16cc22f72c Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py

Re: [pgAdmin4][patch] pgAdmin4 better exception handling

2019-01-22 Thread Akshay Joshi
EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
; incorrect syntax: ERROR: syntax error at or near. > > Thanks, > Khushboo > > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
Sorry, it's working. I'll review and commit it. On Wed, Jan 23, 2019 at 2:16 PM Akshay Joshi wrote: > Hi Khushboo > > Patch not working when procedure is created with arguments. Can you please > verify it. > > On Wed, Jan 23, 2019 at 12:59 PM Khushboo Vashi < &g

pgAdmin 4 commit: Fixed EXEC script for procedures. Fixes #3850

2019-01-23 Thread Akshay Joshi
Fixed EXEC script for procedures. Fixes #3850 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=406ada10f54c6ccc86660a77d6d1ef0f0752efc3 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_2.rst |

Re: [pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-23 Thread Akshay Joshi
Thanks patch applied. On Wed, Jan 23, 2019 at 2:23 PM Akshay Joshi wrote: > Sorry, it's working. I'll review and commit it. > > On Wed, Jan 23, 2019 at 2:16 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >>

pgAdmin 4 commit: 1) Messages tab of query tool should be clear on subs

2019-01-23 Thread Akshay Joshi
1) Messages tab of query tool should be clear on subsequent execution of table/view using View/Edit Data. Fixes #3608 2) Clear drop-down menu should be disabled for View/Edit Data. Fixes #3609 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3

pgAdmin 4 commit: Fix syntax error on python 2.7 for the feature test.

2019-01-23 Thread Akshay Joshi
Fix syntax error on python 2.7 for the feature test. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4fe31404c82129e567aa0a350f03fa0151c329c Author: Khushboo Vashi Modified Files -- web/pgadmin/feature_tests/xss_checks_panels_and

Re: [pgAdmin4][Patch]: Fix syntax error on pytthon 2.7 for the feature test

2019-01-23 Thread Akshay Joshi
tible with python 2.7 > which has been fixed. > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

<    1   2   3   4   5   6   7   8   9   10   >