Re: pgAdmin 4: Russian translation

2017-11-01 Thread Dave Page
Thanks - committed! On Wed, Nov 1, 2017 at 5:08 PM, Alexander Lakhin wrote: > Please update the Russian translation for the current messages. > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company >

pgAdmin 4 commit: Update Russian translation.

2017-11-01 Thread Dave Page
Update Russian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2dcd2cc77f1a44f64dd97d16efd9624aecdc53c4 Author: Alexander Lakhin Modified Files -- .../translations/ru/LC_MESSAGES/messages.mo| Bin 161826 -> 164

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

2017-11-01 Thread Dave Page
_.py", line 574, in properties estimated_row_count = int(res['rows'][0].get('reltuples', 0)) ValueError: invalid literal for int() with base 10: '1e+06' On Wed, Nov 1, 2017 at 4:28 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: &

pgAdmin 4 commit: Fix counted rows display in table properties. Fixes #

2017-11-02 Thread Dave Page
Fix counted rows display in table properties. Fixes #2836 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=897bf4857afe2f55aa5204f604b85417fb93c8c3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

2017-11-02 Thread Dave Page
Thanks - patch applied. On Thu, Nov 2, 2017 at 5:09 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Oops..that was due to float4->text (rel.reltuples::text) datatype casting > in postgres. > > Please find updated patch. > > > On Thu, Nov 2, 201

pgAdmin 4 commit: Ensure estimated rows are included correctly in CREAT

2017-11-02 Thread Dave Page
Ensure estimated rows are included correctly in CREATE script for functions. Fixes #2651 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f73ce2dfc38d6c0ff86dc304580f3e5a971c993f Author: Khushboo Vashi Modified Files -- .../server

Re: [pgAdmin4][Patch]: RM #2651 : "Create Script" view of functions always shows "ROWS 0"

2017-11-02 Thread Dave Page
lays ROWS 0 in case of empty ROWS field. Now it > will display correct value of the filed. This has been fixed in > Create/Update/View function. > > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix a number of cases where strings were not properly

2017-11-03 Thread Dave Page
Fix a number of cases where strings were not properly marked for translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f23838a4c2c4919499bb07f41efab7202843016 Author: Alexander Lakhin Modified Files -- .../foreign_servers/

Re: Fixes for pgAdmin4 messages

2017-11-03 Thread Dave Page
respro.com > The Russian Postgres Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Revert "Fix a number of cases where strings were not

2017-11-03 Thread Dave Page
Revert "Fix a number of cases where strings were not properly marked for translation." This reverts commit 1f23838a4c2c4919499bb07f41efab7202843016 due to unintended side effects it caused - specifically, expanding Databases on the treeview displayed Servers again Branch -- master Details

Re: Fixes for pgAdmin4 messages

2017-11-03 Thread Dave Page
I'm travelling from tomorrow AM, and will have limited availability). On Fri, Nov 3, 2017 at 1:14 PM, Dave Page wrote: > Thanks, patch applied. > > On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin > wrote: > >> Hello, >> I have another patch for the better locali

Re: [pgAdmin4][Patch]: Fixed RM 2844 Tree View Icons

2017-11-03 Thread Dave Page
Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > > The Postgres Database Company > > P: +91 86981 57146 <+91%2086981%2057146> > www.enterprisedb.com > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: [pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data

2017-11-03 Thread Dave Page
517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Tag some translations that were not, well, tagged. Cu

2017-11-05 Thread Dave Page
Tag some translations that were not, well, tagged. Current stats: 1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1472 of 1777 messages (82%) translated in pgadmin

pgAdmin 4 commit: Update Polish translation.

2017-11-05 Thread Dave Page
Update Polish translation. 1748 of 1750 messages (99%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62e70f3c4f27779eb995126240da95d5af40f663 Author: Begina Felicysym Modified

Re: Fixes for pgAdmin4 messages

2017-11-05 Thread Dave Page
That looks like it - thanks, applied! On Sat, Nov 4, 2017 at 2:25 AM, Alexander Lakhin wrote: > Hello, > > 04.11.2017 07:05, Ashesh Vashi wrote: > > Looks like - the patch has introduced syntax error in database.js. > > On Nov 3, 2017 22:19, "Dave Page" wrote: &

Re: Polish translation for current version of pgadmin4

2017-11-05 Thread Dave Page
; > Cheers > > Begina > > > > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Dave Page
Hi I think you forgot to attach the patch. Thanks, Dave On Mon, Nov 6, 2017 at 9:00 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed

pgAdmin 4 commit: Further missing translation fixes. Stats now:

2017-11-06 Thread Dave Page
Further missing translation fixes. Stats now: 1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_

Re: Fixes for pgAdmin4 messages

2017-11-06 Thread Dave Page
Thanks, applied with some wording tweaks. On Mon, Nov 6, 2017 at 9:13 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed onText/offTe

Re: [pgAdmin4][Patch]: To fix the issues in Explain module

2017-11-06 Thread Dave Page
. >> RM#2842 >> >> 3) Node label was incorrect if we run "Explain Analyze" on a query that >> invokes a function. >> RM#2824 >> >> Please review. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.ent

pgAdmin 4 commit: Fix a number of graphical explain rendering issues. F

2017-11-06 Thread Dave Page
Fix a number of graphical explain rendering issues. Fixes #2824. Fixes #2842. Fixes #2843. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b543a58fe516ed0a35a22b1dad57eef93e52c98 Author: Murtuza Zabuawala Modified Files -- web/p

Re: [pgAdmin4][patch][runtime]: RM#2443 - No prompt while exiting application

2017-11-07 Thread Dave Page
Thanks, applied. On Tue, Nov 7, 2017 at 12:49 AM, Neel Patel wrote: > Hi, > > Please find attached patch to fix RM#2443 - No prompt while existing from > main pgAdmin4 runtime browser window. > > Do review it and let me know for comments. > > Thanks, > Neel Patel &g

pgAdmin 4 commit: Confirm with the user before exiting the runtime. Fix

2017-11-07 Thread Dave Page
Confirm with the user before exiting the runtime. Fixes #2443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a4b2ea95383b1505cab5b5b93220c211f71c674 Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 17 +++

pgAdmin 4 commit: Add an option to manually count rows in tables to ren

2017-11-07 Thread Dave Page
Add an option to manually count rows in tables to render the properties. Fixes #2846 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88cd68c2b9a626eee0e29242aa8ca4401a3999b6 Author: Khushboo Vashi Modified Files -- .../servers/da

Re: [pgAdmin4][Patch]: RM #2846: Add a context menu option to manually (re)count rows in tables

2017-11-07 Thread Dave Page
gt; > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To fix overlapping of validation error on Create/Edit dialog

2017-11-07 Thread Dave Page
; validation alert on dialog. > RM#2850 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Prevent error messages covering the last row in a gri

2017-11-07 Thread Dave Page
Prevent error messages covering the last row in a grid. Fixes #2850 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be0e637718fe09a1b0915db2db12279a19c693f4 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/pgadmi

pgAdmin 4 commit: Remove data grid icon for consistency with other menu

2017-11-07 Thread Dave Page
Remove data grid icon for consistency with other menu options. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35b57477dec0a3d3a2fd4c0b1d33270f14e17aa5 Modified Files -- web/pgadmin/tools/datagrid/static/js/datagrid.js | 2 +- 1 fil

pgAdmin 4 commit: Russian translation update.

2017-11-09 Thread Dave Page
Russian translation update. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e1caa61e1ddf1d54a708ecf04d3e99d94c53e17 Author: Alexander Lakhin Modified Files -- .../translations/ru/LC_MESSAGES/messages.mo| Bin 169715 -> 172

Re: pgAdmin 4: Russian translation

2017-11-09 Thread Dave Page
Thanks, patch applied. On Thu, Nov 9, 2017 at 2:00 AM, Alexander Lakhin wrote: > Hello, > > Please update Russian translation for pgAdmin4. > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company

pgAdmin 4 commit: Fix utility output capture encoding. Fixes #2854

2017-11-09 Thread Dave Page
Fix utility output capture encoding. Fixes #2854 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f070f6095ac555df835fb90c291ab817ed7118c Author: Alexander Lakhin Modified Files -- web/pgadmin/misc/bgprocess/processes.py | 2 ++ 1

Re: PGAdmin Restore dialog

2017-11-13 Thread Dave Page
or message would work? > Can you log this at https://redmine.postgresql.org/projects/pgadmin4/issues/new, and include a screenshot or two highlighting the issue? I'm not 100% clear I understand what the issue is. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-15 Thread Dave Page
ain ball is back in Dave's courtyard :-). > pgAdmin 3 didn't allow selection of the foreground colour, and I don't recall anyone ever asking for it. It's clearly up to the user to not select colours that won't work. I'm fine with just setting the background colour to satisfy this requirement, though if it's trivial to do, I have no objection to allowing changes to the foreground colour. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Check and attempt to fir the registry on Windows, if

2017-11-15 Thread Dave Page
Check and attempt to fir the registry on Windows, if the text/css type is misconfigured. Fixes #2716 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96df3147d632d9bc385df1c6d62b4f0242b650c6 Author: Neel Patel Modified Files -- ru

Re: [pgAdmin4][Patch]: RM#2716 - Automatic detect and fix value of "HKEY_CLASSES_ROOT\.css\Content Type"

2017-11-15 Thread Dave Page
me. > > Do review it and let me know for comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Properly set the hostname for SSL use in containers.

2017-11-16 Thread Dave Page
Properly set the hostname for SSL use in containers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf1440f41d1c8f6352b7a563ec8fcf62af86b4e1 Modified Files -- pkg/docker/pgadmin4.conf.j2 | 2 +- 1 file changed, 1 insertion(+), 1 de

pgAdmin 4 commit: Focus on the filter textarea when opening filter opti

2017-11-16 Thread Dave Page
Focus on the filter textarea when opening filter options in the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af2722faa3a083ebb3fb0004901b162353cc8fde Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sql

Re: [pgAdmin4][Patch]: Set focus on Filter window when opened by user

2017-11-16 Thread Dave Page
com> wrote: > Hi, > > PFA minor patch to set proper cursor & focus on Filter editor window in > view data mode. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog:

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

2017-11-16 Thread Dave Page
y an improvement, but the dialogue title needs work: Error saving properties: GONE Why does it have : GONE on the end? That seems unhelpful. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Display long names appropriately in dialogue headers.

2017-11-16 Thread Dave Page
Display long names appropriately in dialogue headers. Fixes #2278 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=537f6f0ab1fccaae80b1e0300d66190dc525ce48 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alerti

Re: [pgAdmin4][Patch]: Display long object name on alertify dialog header

2017-11-16 Thread Dave Page
2278 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Python tests don't need to have JS dependencies insta

2017-11-16 Thread Dave Page
Python tests don't need to have JS dependencies installed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c27d2fd7eeb08fc3dd0b27a48db1f3f947eaa33 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Current versions of Chrome need a newer driver for se

2017-11-16 Thread Dave Page
Current versions of Chrome need a newer driver for selenium tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=afd65018db1048fa703cb0a2a37ed60fc65a2f98 Modified Files -- web/regression/requirements.txt | 2 +- 1 file changed, 1

Re: Fix for minor issue RM2868

2017-11-16 Thread Dave Page
*Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix a referenced before assignment bug in connection

2017-11-16 Thread Dave Page
Fix a referenced before assignment bug in connection management. Fixes #2868 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=051788d040049682cbde78c4bb5343f92b4eb5a2 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/ser

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-16 Thread Dave Page
gt; On Wed, Nov 15, 2017 at 4:58 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch.​ >> >> On Wed, Nov 15, 2017 at 3:01 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Nov 15, 2017 at 9:26 AM, Ashe

Re: Next release

2017-11-16 Thread Dave Page
On Fri, Aug 25, 2017 at 9:34 AM, Dave Page wrote: > > > On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> One more thing that this will only work for future pgAdmin4 versions >> > > > Yeah :-( > Hmm, can

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

2017-11-16 Thread Dave Page
in which I detailed what the settings should be and what they should do. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update selenium version

2017-11-16 Thread Dave Page
Update selenium version Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f17ecba760dcb210b6bf70b259860dd569a7888 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pgAdmin4][Patch]: To upgrade Selenium

2017-11-16 Thread Dave Page
egards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-16 Thread Dave Page
load the results from a 300K row query, it basically hung showing the Downloading File progress indicator. It let me cancel it and carried on working, but hung again the next time I tried the CSV download. Each time it seems to download some data - from the same query I've seen 2.8MB, 5.1MB and 1.5MB. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Dave Page
solved for me. I have run make bundle, and restarted the runtime multiple times. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-16 Thread Dave Page
On Thu, Nov 16, 2017 at 4:30 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Nov 16, 2017 at 8:59 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@en

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel wrote: > Hi Dave, > > On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel >> wrote: >> >>> Hi, >>> >>> Adding

Re: Next release

2017-11-17 Thread Dave Page
g via alembic downgrade > command. > The only way I know is to manually update 'alembic_version' table in > pgAdmin4.db to current revision which is 'ef590e979b0d' > > ​-- Murtuza​ > > > On Thu, Nov 16, 2017 at 6:58 PM, Dave Page wrote: > >> >&g

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 9:36 AM, Neel Patel wrote: > Hi Dave, > > On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: > >> >> >> On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Thu, Nov 16, 20

Re: Next release

2017-11-17 Thread Dave Page
On Fri, Nov 17, 2017 at 10:04 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On Fri, Nov 17, 2017 at 2:46 PM, Dave Page wrote: > >> Hi >> >> The entire point of this patch was to allow an older version of pgAdmin >> to run again

pgAdmin 4 commit: Display relevant error messages when access is denied

2017-11-20 Thread Dave Page
Display relevant error messages when access is denied creating a schema. Fixes #2094 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fd3a7dd3da1c108b12527ec29f4577c57b00eb2 Author: Murtuza Zabuawala Modified Files -- .../browser

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

2017-11-20 Thread Dave Page
Thanks, applied. On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated. > > On Thu, Nov 16, 2017 at 5:12 PM, Dave Page wrote: > >> >> >> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawa

pgAdmin 4 commit: Fix support for time without timezone. Fixes #2881

2017-11-20 Thread Dave Page
Fix support for time without timezone. Fixes #2881 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25794580915c1da92c4583c2833a54ca71423698 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py

Re: [pgAdmin4][Patch]: Add support for time without time zone

2017-11-20 Thread Dave Page
enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow configuration of CSV and clipboard formatting o

2017-11-20 Thread Dave Page
Allow configuration of CSV and clipboard formatting of query results. Fixes #2781 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c566f132e19ab4476f570664647683f97361cb0 Author: Khushboo Vashi Modified Files -- docs/en_US/images

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

2017-11-20 Thread Dave Page
Thanks, applied. On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Thu, Nov 16, 2017 at 7:42 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

2017-11-20 Thread Dave Page
te_char File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py", line 670, in __init__ self.writer = writer(f, dialect, *args, **kwds) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py", line 185, in __init__

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

2017-11-20 Thread Dave Page
e console output if possible ? >> >> Thanks, >> Neel Patel >> >> On Fri, Nov 17, 2017 at 3:13 PM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Fri, Nov 17, 2017 at 3:09 PM, Dave Page wrote: >>> >

pgAdmin 4 commit: Ensure we can download large files and keep the user

2017-11-20 Thread Dave Page
Ensure we can download large files and keep the user informed about progress. Fixes #2829. Fixes #2491. Fixes #2715 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 Author: Neel Patel Modified Files --

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-20 Thread Dave Page
the problem. We link to external sites such as postgresql.org - what happens if that tries to open something with target="_new"? It should be expected to work as well. I think we need to fix the underlying problem, not try to work around it. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

2017-11-20 Thread Dave Page
eproduce > the issue on Python 2.7 or Python 3.5. > > Thanks, > Khushboo > > > > On Mon, Nov 20, 2017 at 8:05 PM, Dave Page wrote: > >> >> >> On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

2017-11-20 Thread Dave Page
virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py", line 185, in __init__ raise TypeError(*e.args) TypeError: "delimiter" must be a 1-character string On Mon, Nov 20, 2017 at 4:09 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, &

pgAdmin 4 commit: Decode the field separator and quote char if needed.

2017-11-20 Thread Dave Page
Decode the field separator and quote char if needed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4568fe22f7e50cc9e782839c3ca35607d651b4b3 Author: Khushboo Vashi Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py |

pgAdmin 4 commit: Prevent the Windows installer accepting paths contain

2017-11-20 Thread Dave Page
Prevent the Windows installer accepting paths containing invalid characters. Fixes #1365 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ff753deb8cd49fde8fea25b9b676a45461ba7e9 Author: Paresh More Modified Files -- Make-MinGW.ba

Re: [Patch]: Installer: pgAdmin4 should not install in special character path

2017-11-20 Thread Dave Page
t; For both (1) and (2) common error message will be used. > > > Attached is the patch > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > www.enterprisedb.com > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Build failed in Jenkins: pgadmin4-master-python26 #510

2017-11-20 Thread Dave Page
in 4 Jenkins > wrote: > >> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/51 >> 0/display/redirect?page=changes> >> >> Changes: >> >> [Dave Page] Update selenium version >> >> -- >>

pgAdmin 4 commit: Stop Python 2.6 barfing on newer versions of Selenium

2017-11-20 Thread Dave Page
Stop Python 2.6 barfing on newer versions of Selenium Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce246ecce40fd97810c2120c10029ff328e66bc8 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 3 ++- 1 f

pgAdmin 4 commit: Fix /NOICONS switch in the windows installer. Fixes #

2017-11-20 Thread Dave Page
Fix /NOICONS switch in the windows installer. Fixes #1366 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a539147a0e8b4b8852289909b2bcb268d7908887 Author: Paresh More Modified Files -- pkg/win32/installer.iss.in | 3 ++- 1 file cha

Re: [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer.

2017-11-20 Thread Dave Page
Start Menu Folder* wizard page. > > User still have a option at runtime whether he want to create or not > create Start Menu folder on runtime. NOICONS will just uncheck the checkbox. > > > Attached is the patch. > > -- > > Thanks & Regards > > *Paresh More*

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-20 Thread Dave Page
sh (changing to a different foreground colour seems to work fine though). > > On Mon, Nov 20, 2017 at 6:48 PM, Dave Page wrote: > >> Hi >> >> On Fri, Nov 17, 2017 at 9:30 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>

pgAdmin 4 commit: Add missing semicolons.

2017-11-20 Thread Dave Page
Add missing semicolons. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be8d3604fbc3cc53bf088fd06873fdfe14fc6545 Modified Files -- web/regression/requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: Build failed in Jenkins: pgadmin4-master-python34 #376

2017-11-20 Thread Dave Page
p://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Mon, Nov 20, 2017 at 10:32 PM, pgAdmin 4 Jenkins > wrote: > >> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/37 >> 6/display/redirect?page=changes> >> >> Changes: >

pgAdmin 4 commit: And remove the extra semicolons. Sigh.

2017-11-20 Thread Dave Page
And remove the extra semicolons. Sigh. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=182369cbab90ab7f7fe651609afa19238e8b7d73 Modified Files -- web/regression/requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Dave Page
On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel wrote: > Hi Dave, > > On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel >> wrote: >> >>> Hi, >>> >>> Please find attached p

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
Hi On Mon, Nov 20, 2017 at 5:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Mon, Nov 20, 2017 at 10:40 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.

pgAdmin 4 commit: _blank is the correct HTML target for anchors, not _n

2017-11-21 Thread Dave Page
_blank is the correct HTML target for anchors, not _new. Fixes #2679. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b5363e2c4c0d00bf215aa9f3c5369801fe39ae4 Author: Neel Patel Modified Files -- web/pgadmin/dashboard/templates/da

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Dave Page
Hi On Tue, Nov 21, 2017 at 9:33 AM, Neel Patel wrote: > Hi Dave, > > > On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: > >> >> >> On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Mon,

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
ot; LINE 3: ; Table: CREATE TABLE public.bools ( id integer NOT NULL DEFAULT nextval('bools_id_seq'::regclass), b1 boolean, b2 boolean, b3 boolean, CONSTRAINT bools_pkey PRIMARY KEY (id) ) Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

pgAdmin 4 commit: Remove the artificial limit of 4000 characters from t

2017-11-21 Thread Dave Page
Remove the artificial limit of 4000 characters from text areas. Fixes #2877 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a85538a1fcc6a9c40c3b0f46d111b16e56974819 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js

Re: [pgAdmin4][Patch]: Remove limit of 4000 characters from Textarea

2017-11-21 Thread Dave Page
gt; limit input unless and until maxlength is provided in particular field. > RM#2877 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsn

pgAdmin 4 commit: Quote the owner name when creating types. Fixes #2787

2017-11-21 Thread Dave Page
Quote the owner name when creating types. Fixes #2787 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd8e2fe8a6cd88421a0aca9cb7abcdd28d2bfbc5 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/types/templates/type/

Re: [pgAdmin4][Patch]: Properly quote owner in Type definition

2017-11-21 Thread Dave Page
Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Fix for issue RM2760

2017-11-21 Thread Dave Page
//www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2017-11-21 Thread Dave Page
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=921269993645205c1667ab116e4c4201cacf55df Author: Harshal Dhumal Modified Fi

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2017-11-21 Thread Dave Page
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b284572afee33196aa4b41adaf33a399e985b4b7 Author: Murtuza Zabuawala Modified Files -- docs/e

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
gt; > PFA updated patch with changes suggested by Ashesh. > Hopefully the last revision :) > > > On Tue, Nov 21, 2017 at 4:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> >> On Tue, Nov 21, 2017 at 2:

pgAdmin 4 commit: Some browsers don't properly support tri-state checkb

2017-11-21 Thread Dave Page
Some browsers don't properly support tri-state checkboxes, so create our own control to handle true/false/null. Fixes #2848 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=930dd8af1fac500749c7a9efa2302b5f3f52b4d4 Author: Murtuza Zabuawala Mo

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
Hi On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. > > On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: > >> HI >> >> On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterpr

pgAdmin 4 commit: Fix a yarn warning: "warning From Yarn 1.0 onwards, s

2017-11-21 Thread Dave Page
Fix a yarn warning: "warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts." Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=888082

pgAdmin 4 commit: Improve clarity of the boolean checkbox.

2017-11-22 Thread Dave Page
Improve clarity of the boolean checkbox. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0db93cefd80d7671aa3434c1cfb45295b437983 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap.overrides.css | 11

pgAdmin 4 commit: Ensure newly added rows cannot be editted until we ha

2017-11-22 Thread Dave Page
Ensure newly added rows cannot be editted until we have key values. Fixes #RM2886 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bc318f0913dd4b960bb113fe7a3b0d0ec2e6771 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/to

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-22 Thread Dave Page
Thanks, both applied! On Wed, Nov 22, 2017 at 5:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > >> Hi >> >> On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala <

<    2   3   4   5   6   7   8   9   10   11   >