Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

>> On Thu, Apr 23, 2020 at 10:13 AM navnath gadakh < >> navnath.gad...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> I'm reviewing this patch. >>> >>> On Wed, Apr 22, 2020 at 6:54 PM Satish V >>> wrote: >>

[pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hi Hackers, In the attached patch, newly created columns in a table are sorted according to their creation order rather than the alphanumerical order. Previously this was not happening without context refresh. Please review. Thanks Sathish V diff --git

RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Hackers, In the patch attached, we are gracefully informing the end user, using an alert message, that the database is already connected when they click "Connect Database..." after right clicking on a disconnected database. As this problem deals with racing conditions, it is highly complex to

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

; > Thanks, > Khushboo > > > > > > On Thu, Apr 30, 2020 at 1:59 PM Satish V > wrote: > >> Hi, >> >> I made the changes to the code such that conn.connect() will happen only >> when there is no prior connection exist. In short, connection via c

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

the patch remain the same. Thanks, Sathish V On Mon, May 4, 2020 at 12:04 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Satish, > > On Thu, Apr 30, 2020 at 8:29 PM Satish V > wrote: > >> Hi Khushboo, >> >> In the attached patch, >>

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

; >>>> Hi, >>>> >>>> On Thu, Apr 30, 2020 at 10:48 AM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Thu, Apr 30, 2020 at 10:14 AM Aditya Toshniw

RM-5434 (New table added is not alphabetically added to the tree)

Hi Hackers, In the patch attached, 1.Creation or updation of Tables and all other entities will be sorted according to their names. 2.Exception- Columns will be sorted according to their creation order(position ID). This Patch also resolves RM 5450. Kindly review and share the suggestions if

Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Hi Hackers, Attached is the patch which alerts the users when they try to consume the options in the context menu of the deleted node. -fixed the opening of an empty query tool window for non existing nodes.(create/delete/update..) - handles the error like "list index out of range" with a

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

2020 at 2:16 PM Satish V wrote: > >> Hi Hackers, >> >> Attached is the patch which alerts the users when they try to consume the >> options in the context menu of the deleted node. >> > Can you please specify the context menu options which you handled, so it >

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

e them at some places. (Example: on Database > expansion ) > - Please follow basic JS coding standards. Ex: A space is required > after/before any operator. I have seen 1 or 2 places where a space is > missing in your patch. > > Thanks, > Khushboo > > On Tue, Jun 2, 2020 at 1

[pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects

Hi Hackers, Please find the patch which improves the code coverage for Schema alone. Kindly create another RM for the Catalog Objects. Please review the patch. Thanks, Sathish V RM5327v1.patch Description: Binary data

Re- [SonarQube][patch]- codesmell

Hi Hackers, Please find the patch which fixes the code smell issues related to the rule "Variables should not be shadowed". Thanks, Sathish V Variables_should_not_be_shadowed.patch Description: Binary data

Re- [pgAdmin][SonarQube] Variables should not be shadowed

Hi Hackers, Please find the patch which fixes 10 issues related to the Variables should not be shadowed. Kindly review and share the comments. Thanks, Sathish V variable_shadow2.patch Description: Binary data

Re- Patch for SonarQube issues

Hi Hackers, I have fixed some issues related to variable shadowing. Please find the patch in the attachments. Files changed import_export.js and maintenance.js Thanks, Sathish V variable_shadow.patch Description: Binary data

Re-[pgAdmin][RM-5323]

Hi Hackers, Please find the patch which improves the API test cases for Foreign Data Wrappers. Before patch - 46% After Patch - 73% Kindly review and share the changes if required. Thanks, Sathish V RM5323s1.patch Description: Binary data

[pgAdmin4][Patch] - SonarQube Fixes

Hi Hackers, Please find the patch which fixes sonarQube issues related to variable shadowing. Files altered - backgird.js, backgrid.pgadmin.js Kindly review and share your feedback. Thanks, Sathish V variableShadowing.patch Description: Binary data

Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty

Hi Hackers, Please find the patch in the attachment which resolves the issue of error messages not getting displayed in the dialog boxes of *backup, restore *and *import/export.* Kindly review the patch. Thanks, Sathish V RM3814vs1.patch Description: Binary data

Reg-[Sonarqube]CodeSmell issues

Hi Hackers, Please find the patch in the attachment which resolves below issues 1.Replace this if-then-else statement by a single return statement.(clumsy) 2."switch" statements should have at least 3 "case" clauses. (bad practise) Kindly review and share the changes, if required. Thanks

Re: Re-[Sonarqube]- Clumsy code

rly. > > On Thu, Jun 18, 2020 at 11:27 AM Satish V > wrote: > >> Hi Hackers, >> >> Please find the patch in the attachment which resolves below issue. >> 1.Replace this if-then-else statement by a single return statement. >> >> Kindy review and

Reg-[pgAdmin4][Patch] - SonarQube - Extra semicolons should be removed and Method names should comply with a naming convention

Hi Hackers, Please find the patch which solves the problem related to extra semicolons and function naming convention. Please review. Thanks, Sathish V scss_and_function_name.patch Description: Binary data

Re- [SonarQube][patch]- tagged suspicious, convention

Hi Hackers, Please find the patch which resolves the SonarQube scan issue stated below. 1.Method/Field names should comply with a naming convention. 2.Conditionals should start on new lines conditionals_and_rename.patch Description: Binary data

Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

Hi Hackers, Please find the patch in the attachment which clears the sonarqube error, related to expressions evaluated to true/false always. Kindly review the patch and share the changes required Thanks, Sathish V refactor_always_evaluate_to_true.patch Description: Binary data

[pgAdmin][patch]SonarQube tagged clumsy

Hi Hackers, Please find the patch in the attachment which solves the problem related to reducing if else statement to single return expression. Kindly review and share the changes required.. Thanks, Sathish V if_else_reduction.patch Description: Binary data

Re-[Sonarqube]- Clumsy code

Hi Hackers, Please find the patch in the attachment which resolves below issue. 1.Replace this if-then-else statement by a single return statement. Kindy review and share the changes, if required Thanks, Sathish V if_else_reduction.patch Description: Binary data

Reg - RM-5325[Code Coverage] Improve API test cases for Collations

Hi Hackers, Please find the attached patch which improves the code coverage for Collations. Without patch - 43% With patch - 64% Kindly review the patch and share the changes or improvements, if required. Thanks, Sathish V RM5325v1.patch Description: Binary data

Reg-[Sonarqube] - expects 4 arguments, but 5 were provided.

Hi Hackers, Attached is the patch which fixes the sonar issue of supplying more parameters. Kindly review and share the comments. Thanks, Sathish V no_of_arg_fix.patch Description: Binary data

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Tue, Jun 2, 2020 at 6:36 PM Satish V wrote: > >> Hi Khushboo, >> >> The Reason for checking status==410 is to show error dialog to the user >> which will not go unnoticed at any situation. For closing the empty query >> tool we need this error dialog pop which shows

[pgAdmin 4 - Bug #5137] Focussing in and then out of numeric input enables the save button in dialog

Hi Hackers, Please find the patch which fixes the bug related to save-button getting enabled on hitting tab key/focusing in and out of the numeric field(empty/non-empty). Kindly review the patch. Thanks, Sathish V RM5137s1.patch Description: Binary data

[pgAdmin 4 - Housekeeping #5336][Code Coverage] Improve API test cases for Types

Hi Hackers, Please find the patch attached which improves the code coverage percentage of Types from 53% to 76%. Kindly review the patch. Thanks, Sathish V RM5336s1.patch Description: Binary data

Re- SonarQube[Variables should not be shadowed]

Hi Hackers, Please find the patch which fixes some of the sonar qube issues related to variable shadowing. Thanks, Sathish V variable_shadow1.patch Description: Binary data

Autovacuum on Toast table

Hi, We deleted the old data around 300GB from a table.i can see the auto vacuum performing on base table but not on toast table.due to this db size is growing rapidly. I am using the Azure PostgreSQL service. In the base/parent table dead tuples are zero. Is it possible to run the vacuum on