GSoC Student - Help needed

Dear pgadmin developers, I am a student applying to GSoC this year, specifically the query tool automatic mode switching project. I just finished my exams so I am short in time. I would very much appreciate it if anyone is willing to contact me privately to give me an overview of how the sql

GSoC Proposal - pgAdmin4 Query Tool Automatic Mode Detection

feedback and any comments you have? I know it's too late but I still have a chance to do modifications in the next 15 hours. Thanks. Regards. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https

[GSoC][Patch] Automatic Mode Detection V1

button for saving the query to a file? - What documentations or unit tests should I write? any guidelines here would be appreciated. Thanks a lot! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https

[GSoC] Check if a query resultset is update-able

-class.html [3] https://www.postgresql.org/docs/current/catalog-pg-attribute.html [4] https://www.postgresql.org/docs/current/catalog-pg-constraint.html -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https

Re: [GSoC] Check if a query resultset is update-able

Hi, On Tue, Jun 11, 2019 at 10:21 AM Dave Page wrote: > Hi > > On Mon, Jun 10, 2019 at 10:51 PM Yosry Muhammad > wrote: > >> Dear all, >> >> After some research and review of the code, I have arrived at this method >> to check whether a query results

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi, I have been working all day to try to make this patch applicable. On Tue, Jun 18, 2019 at 3:05 PM Dave Page wrote: > Hi > > [please keep the maililng list CC'd] > > On Mon, Jun 17, 2019 at 3:05 PM Yosry Muhammad wrote: > >> >>> Do you want me

Re: [GSoC][Patch] Automatic Mode Detection V1

he tests once the patch is complete. The patch passes all the existing tests except for 3 feature tests that fail due to a TimeoutException in selenium. I do not know what this is about I hope Aditya will help me with it. Also, do you mean code documentation or documentation for the users? Co

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi, On Wed, Jun 19, 2019, 1:54 PM Dave Page wrote: . - We need to add a "do you want to continue" warning before actions like Execute or EXPLAIN are run, if there are unsaved changes in the grid. - I think we should make the text in any cells that has been edited bold until saved, so the user

Re: [GSoC][Patch] Automatic Mode Detection V1

uot; option instead if they don't know SQL, but that would > still require the Sort/Filter options. > > What do other folks think? > Waiting for other people's opinion on that matter. Oh, and icon attached! > Will work on adding the new icon and switching the save functionality t

Re: [GSoC][Patch] Automatic Mode Detection V1

at. What do you think? These changes (together with other changes that I am working on) will be included in the next version of this patch. Thanks ! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: GSoC Project Timeline and Proposal

My proposal: https://docs.google.com/document/d/1cQssYfPWLSCKAmFwnN-jEPjlldGQtr5fbPaU788UrwM/edit?usp=sharing On Fri, May 24, 2019 at 8:40 AM Yosry Muhammad wrote: > Dear all, > > The official coding phase for GSoC starts by May 27th. As I have stated in > my previ

GSoC Project Timeline and Proposal

to evaluate my timeline and plan and make any necessary corrections, create milestones, etc. I would really appreciate it if you all took the time (especially my mentor, Mr. Page) to go through my project proposal and timeline and give me your suggestions and feedback. Thanks, *Yosry Muhammad Yosry

GSoC Project Introduction - Automatic Mode Detection

the time I didn't work in. I am looking forward to starting to contribute to this project. Regards. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: [GSoC] Finalized First Patch

Sounds good ! Looking forward to any feedback. Thanks. On Fri, Jul 5, 2019, 1:01 PM Dave Page wrote: > Hi > > On Fri, Jul 5, 2019 at 6:28 AM Yosry Muhammad wrote: > >> - The patch won't apply with "git apply" and only partially applies with >>> patch -

Re: [GSoC][Patch] Automatic Mode Detection V1

chromedriver --version >> ChromeDriver 75.0.3770.8 >> (681f24ea911fe754973dda2fdc6d2a2e159dd300-refs/branch-heads/3770@{#40}) >> >>> >>> >>> The version I have is actually 75.0.3770.90. Could the more recent version be causing the problem ? Thanks and regards. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: [GSoC][Patch] Automatic Mode Detection V1

se check for others that > need updating), as well as updates to at least: > > editgrid.rst > query_tool.rst > query_tool_toolbar.rst > > Great work! > > I will disable the generated queries for now, then for the next patch I will work on (optionally) including them (mogrified). Should I send a patch with the completed work then start working on the tests and documentation (for it to get reviewed)? or wait until the patch is complete with tests and documentation? Thanks all ! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: [GSoC] Finalized First Patch

Hi Khushboo, Please find an updated patch attached with the mentioned import line removed. On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote: > >> Hi, >> &g

Re: [GSoC] Finalized First Patch

I will look into it and get back to you. Thanks ! On Fri, Jul 12, 2019, 11:20 AM Dave Page wrote: > > > On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> On Thu, Jul 11, 2019 at 6:50 PM Yosry

Re: [GSoC] Help with Jasmine Tests

Thanks for your help, I will see what I can do. On Mon, Jul 1, 2019, 8:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > On Sat, Jun 29, 2019 at 8:54 PM Yosry Muhammad wrote: > >> Hi all, >> >> I am writing tests for my initi

Re: [GSoC] Help with Jasmine Tests

o what is done in - > web/regression/javascript/sqleditor/execute_query_spec.js for btn-flash. > The problem is not with checking the button. How do I mimic the user editing the grid? I cannot create a grid with all its options in the test. -- *Yosry Muhammad Yosry* Computer Engineering student, The Facult

[GSoC] Ideas for the remaining of the project

Hi Dave, The core patch for this project is being finalized and I am unable to work for the current few days due to issues mentioned in the previous email. Therefore, I have been thinking of what can be done in the project after this patch is done. Below are the features I have been thinking of

[GSoC] Help with Jasmine Tests

. In the sqleditor test I have seen, a spy is created for the SqlEditor to see if specific functions are called, but I want the actual _render() function to run (to call render_grid() of the gridView). In other words, I need to test the code inside_render() function. Thanks a lot. -- *Yosry Muhammad Yosry

Re: [GSoC] Query History Upgrade

Great! thanks everyone. On Wed, Aug 14, 2019, 10:08 AM Akshay Joshi wrote: > Hi Yosry > > > On Tue, Aug 13, 2019 at 6:33 PM Yosry Muhammad wrote: > >> Any more suggestions or comments on the patch? >> > > I am reviewing it. > >> >>

Working on issues #4530, #4529, #4520, #4524

is working on them? Thanks ! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: Working on issues #4530, #4529, #4520, #4524

In addition, #4476 was already resolved in later versions. I commented on that too, please check. On Tue, Jul 30, 2019, 1:38 AM Yosry Muhammad wrote: > > > On Tue, Jul 30, 2019, 1:22 AM Akshay Joshi > wrote: > >> Hi Yosry >> >> On Tue, Jul 30, 2019 at

Re: [GSoC] Query History Upgrade

Thanks all for the thorough review. On Fri, Aug 16, 2019, 1:48 PM Akshay Joshi wrote: > Thanks patch applied. > > On Wed, Aug 14, 2019 at 7:24 PM Yosry Muhammad wrote: > >> Hi, >> >> On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad >> wrote:

Query Tool JS Minimal Refactoring

Hi hackers, Please find attached a patch with minimal refactoring of: web/pgadmin/tools/sqleditor/static/js/sqleditor.js This includes merging 2 redundant functions into one and renaming some functions to have more expressive and consistent names. Please review ! Thanks. -- *Yosry Muhammad

Transaction Status Python Tests

Hi Hackers, Please find attached a patch including new python test that checks the transaction status after executing queries and saving data when auto-commit is on/off. It also includes some refactoring of previously written python tests. Please review ! Thanks. Regards. -- *Yosry Muhammad

Re: Transaction Status Python Tests

t; > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Sat, Aug 17, 2019 at 6:22 PM Yosry Muhammad >> wrote: >> >>> Hi Hackers, >>> >>> Please find attached a patch including new python test that check

Re: Query Tool JS Minimal Refactoring

Jasmine tests passed on my machine, I will take another look once I have access to my machine. On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi wrote: > Hi Yosry > > Jasmine tests are failing, can you please fix those and resend the patch. > > On Fri, Aug 16, 2019 at 11:23 PM Yosry Mu

[GSoC][New Feature] Editable and Read-only Columns

to your thoughts and feedback! Also, do you think the editable/read-only icons should apply in both View/Edit Data and Query Tool for consistency? or hidden from View/Edit Data as all columns are editable anyway? Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty

Re: [GSoC] Query History Upgrade

Hi, On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi wrote: > Hi Yosry > > I have found following issues: > >- Jasmine test cases are failing. >- Browser error when applying the patch and open the query tool. >Previously saved queries are there: >- [image: Screenshot 2019-08-14 at

Re: [GSoC] Query History Upgrade

Hi, On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad wrote: > Please find an updated patch with the mentioned issue fixed. I am sorry > you spent so much time reviewing this and finding bugs. > > On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi < > akshay.jo...@enterprisedb.com>

Re: Transaction Status Python Tests

; >>> Not able to figure out the cause today as well, I have comment out the >>> disable auto commit test cases for Transaction Status. Please look into it >>> once you will have some time. >>> >>> On Mon, Aug 19, 2019 at 6:05 PM Yosry Mu

Re: [GSoC] Query History Upgrade

Any more suggestions or comments on the patch? On Tue, Aug 13, 2019 at 2:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Aug 13, 2019 at 5:35 PM Yosry Muhammad wrote: > >> Please find attached an updated patch with a small modificatio

Re: [GSoC] Query History Upgrade

Is it always the same error when it fails? On Tue, Aug 13, 2019 at 1:50 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > The test cases fails intermittently. It passes sometimes. > > On Tue, Aug 13, 2019 at 5:15 PM Yosry Muhammad wrote: > >> Hi Adity

Re: [GSoC] Query History Upgrade

ot;UPDATE public.test_editable_table2293 SET normal_column = > '10'::numeric WHERE pk_column = '1';" not found in 'COMMIT;\n15:00:40' > > On Tue, Aug 13, 2019 at 5:03 AM Yosry Muhammad wrote: > >> The test failed after merging with master. A previously written test >&g

Re: Transaction Status Python Tests

dn't find the actual > cause. Can you please figure out and send the patch asap, I'll have to > create candidate build tomorrow. > > On Mon, Aug 19, 2019 at 1:22 PM Yosry Muhammad wrote: > >> Hi Akshay, >> >> I am sorry I do not have access to my machine right no

Re: Transaction Status Python Tests

ed_data() > self._check_transaction_status(self.transaction_status) > > > On Mon, Aug 19, 2019 at 5:50 PM Yosry Muhammad wrote: > >> Can you send me the error message? Unfortunately there is a problem with >> my machine right now I am unable to investigate it myself, I a

Re: [GSoC][New Feature] Editable and Read-only Columns

I updated the patch for backwards compatibility anyway. On Fri, Aug 23, 2019 at 10:45 AM Dave Page wrote: > > > On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad wrote: > >> Hi Aditya, >> >> On Fri, Aug 23, 2019 at 7:33 AM Aditya Toshniwal < >> aditya.toshn

Re: Query Tool JS Minimal Refactoring

js:3347) > at triggerCallback (alertify.js:1220) > at Object.buttonsClickHandler (alertify.js:1241) > at HTMLDivElement.eval (alertify.js:299) > > On Thu, Aug 22, 2019 at 11:44 PM Yosry Muhammad > wrote: > >> Please find an updated patch attached. &g

Re: Query Tool JS Minimal Refactoring

rver_groups/servers/databases/schemas/views/__init__.py >> >> Looks like some other patch got mixed up. >> Anyway, I've removed these changes and have attached the updated patch >> (v4) ready for commit. Everything looks good to me. >> > > Like the editable colu

Re: [GSoC][New Feature] Editable and Read-only Columns

erence: element is not attached to the page document > (Session info: chrome=76.0.3809.100) > (Driver info: chromedriver=76.0.3809.126 > (d80a294506b4c9d18015e755cee48f953ddc3f2f-refs/branch-heads/3809@{#1024}),platform=Mac > OS X 10.14.5 x86_64) > > Without the patch,

Re: Query Tool JS Minimal Refactoring

tch, as the > JS tests fail if I apply it to the current GIT head? > > On Fri, Aug 23, 2019 at 1:07 PM Yosry Muhammad wrote: > >> Please find an updated patch attached. >> >> On Fri, Aug 23, 2019 at 1:23 PM Dave Page wrote: >> >>> Hi >>&

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Mon, Aug 19, 2019 at 9:54 AM Yosry Muhammad wrote: > Jasmine tests passed on my machine, I will take another look once I have > access to my machine. > > On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi > wrote: > >> Hi Yosry >>

Re: [GSoC][New Feature] Editable and Read-only Columns

Makes sense. Thanks a lot for your help :) On Sat, Aug 24, 2019, 8:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > My guess is because selenium is running faster on our machine. Depends on > machine. > > On Sat, Aug 24, 2019, 12:

Re: [GSoC][New Feature] Editable and Read-only Columns

xception. Adding below code > solved the problem for me. Attached is the patch. > > import time > time.sleep(0.5) > for column_index, should_be_editable in enumerated_should_be_editable: > > > On Sat, Aug 24, 2019 at 4:08 AM Yosry Muhammad wrote: > >> Hi Da

Query Tool Fix

rows not shown in the query result messages (#4525 and #4529 - duplicates). Note that: #4524 and #4522 are feature requests for already existing features. Please review ! Thanks -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Wed, Aug 7, 2019, 10:31 AM Dave Page wrote: > Hi > > On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad wrote: > >> Hi, >> >> On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: >> >>> Hi >>> >>> Seems to work well :-). A few comments

Re: New versions "What's new"

Thanks, Avin ! On Wed, Aug 7, 2019, 8:09 AM Avin Kavish wrote: > If this were github, I'd press the thumbs up button, but here is the next > best thing.  > > On Wed, Aug 7, 2019 at 11:35 AM Yosry Muhammad wrote: > >> Hi Hackers, >> >> I have noticed a lot of

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

ouble > click does nothing. If the data is JSON, there is no way to see the > content. It should show the editor without the Save button if the result > set is not updatable. > > On Wed, Aug 7, 2019 at 2:05 PM Yosry Muhammad wrote: > >> Hi, >> >> On Wed, Aug 7, 201

New versions "What's new"

Hi Hackers, I have noticed a lot of users are unaware of new features or changes that are made from one version to another. Maybe a "What's new" pop up window can be added, showing when the user opens the app for the first time after an upgrade? Does something similar already exist? Thanks.

Re: Query Tool Fix

ch easier to understand changes, especially after some time. > Having a stated dependency between patches is fine if that's necessary. > > Can you split the changes up please? > > Thanks. > > >> >> On Tue, Jul 30, 2019 at 8:10 PM Yosry Muhammad >> wrote: >> &g

Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536.

Hi all, Please find a patch attached that: Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536. Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021

[Help] Modifying get_columns.sql template

Hi hackers! I was wondering if modifying the query in: get_columns.sql @ pgadmin/tools/sqleditor/templates/sql/default/ to also SELECT attnum (attribute number) in addition to the already SELECTed columns will break any code or tests? I know this template is used in multiple places throughout

Re: [Help] Modifying get_columns.sql template

Alright, thanks a lot ! On Fri, Aug 2, 2019, 10:01 AM Dave Page wrote: > Hi Yosry, > > On Fri, Aug 2, 2019 at 7:51 AM Yosry Muhammad wrote: > >> Hi hackers! >> >> I was wondering if modifying the query in: get_columns.sql @ >> pgadmin/tools/sqleditor/temp

Re: [GSoC] Support editing resultsets from tables with OIDs

On Mon, Jul 29, 2019, 4:26 AM Dave Page wrote: > Hi Yosry and Akshay > > On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> >> On the subject of the regression test - I assume at

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > Hi > > Seems to work well :-). A few comments: > > - Should we have an icon by the non-generated queries (the lightning > flash) and the COMMITs etc (the commit/rollback icon as appropriate) as > well? I think just having the icon for

[GSoC] Query History Integration with updatable query resultsets and improvements

, I will start working on tests and documentation updates for this. Looking forward to your feedback and comments ! P.S I have done a lot of refactoring especially in save_data_changes.py, I would really appreciate it if someone reviewed these changes. Thanks! -- *Yosry Muhammad Yosry* Compu

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >>

Query Tool - Cell Double Click Fix

Hi hackers, Please find attached a fix of a bug where users could not double click to expand the contents of a cell if the resultset was not editable. Please review. Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class

Re: pgAdmin 4 commit: Ensure command tags are shown in the messages tab of

web?p=pgadmin4.git;a=commitdiff;h=76e658ee129a49afc74152b57330cf2c2e653e2e > Author: Yosry Muhammad > > Modified Files > -- > docs/en_US/release_notes_4_12.rst | 3 ++- > web/pgadmin/tools/sqleditor/__init__.py| 23 > +++--- >

JavaScript Errors in the Query Tool Leads to a False Message

oes anybody have any idea why this happens? This doesn't seem right. Thanks. *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: JavaScript Errors in the Query Tool Leads to a False Message

: > Is there a way to reproduce this? i.e force a js error during query > execution? One reason I can think of is using $.ajax({ async: false }) so > the ajax request gets handled on the main thread and anything that throws > on to the main thread gets caught. > > On Tue, Aug 6, 2019 at 4:07

Re: JavaScript Errors in the Query Tool Leads to a False Message

On Tue, Aug 6, 2019, 6:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > Yes, I have experienced the same but missed to log a bug. You can log a > bug so that someone can work on it. > To simulate the issue, just add some JS code that will cause error. > >> >>

Creating control sliders

someone guide me through this? Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/

Re: Bug in Database Nodes in the Tree

Thanks for making things clear. On Tue, Jul 23, 2019, 10:01 AM Dave Page wrote: > > > On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad >> wr

Re: Bug in Database Nodes in the Tree

gt; Hi >> >> On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad >> wrote: >> >>> Hi, >>> >>> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> Hi Yosry, >>>

Bug in Database Nodes in the Tree

Hi Khushboo, There's a minor bug that I noticed a while back that when you right click a disconnected database (to drop it for example) it automatically connects to the database and expands the node. This behaviour is a little annoying to users (me too), I am trying to fix it. I looked around

Re: Bug in Database Nodes in the Tree

Hi, On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad > wrote: > >> Hi Khushboo, >> >> There's a minor bug that I noticed a while back that when you

Re: Subtle test problem

Working on it right now. On Wed, Jul 17, 2019, 2:35 PM Dave Page wrote: > Hi Yosry, > > Now that your patch is committed we're seeing a subtle failure on our > internal (at EDB) CI/CD system. Essentially we have multiple tests running > concurrently, and it looks like you're using a fixed table

[GSoC] Support editing resultsets from tables with OIDs

"CREATE TABLE". Just letting you know about this. Thanks and regards! -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/ diff --git a/docs/en_

Re: [GSoC][Patch] Automatic Mode Detection V1

does not exist - it produces an error message to the user). Waiting for your feedback. Thanks ! On Sat, Jun 15, 2019 at 8:48 AM Yosry Muhammad wrote: > Dear all, > > This is my first patch of my GSoC project, query tool automatic mode > detection. > > In this patch, the initi

Re: [GSoC] Finalized First Patch

Hi, On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Some points I missed: > 1. I assumed that in this patch modification in case of OIDs= True > (without primary key) has not considered as that is not working. > This is not implemented yet. I will work

Re: [GSoC] Finalized First Patch

Hi Khushboo, On Wed, Jul 10, 2019, 8:33 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > I liked the way you have refactored the code at some places in the JS file > and made it cleaner. > Thanks ! I am doing my best. Here are some points: > > 1. The table (including