Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Thanks everyone for working it out. On Tue, Aug 20, 2019, 6:54 AM Akshay Joshi wrote: > Thanks Khushboo, patch applied. > > It works, I have tested for multiple database servers. > > On Tue, Aug 20, 2019 at 10:03 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >>

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Thanks Khushboo, patch applied. It works, I have tested for multiple database servers. On Tue, Aug 20, 2019 at 10:03 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the test cases. > > Thanks, > Khushboo > > On Tue, Aug 20, 2019 at

Re: Transaction Status Python Tests

2019-08-19 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the test cases. Thanks, Khushboo On Tue, Aug 20, 2019 at 9:52 AM Akshay Joshi wrote: > Hi Yosry > > Not able to figure out the cause today as well, I have comment out the > disable auto commit test cases for Transaction Status. Please look into it >

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Not able to figure out the cause today as well, I have comment out the disable auto commit test cases for Transaction Status. Please look into it once you will have some time. On Mon, Aug 19, 2019 at 6:05 PM Yosry Muhammad wrote: > This behaviour is very strange. Maybe another test

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Test cases with auto commit disabled gets failed for following scenario only: - Run all test cases on more than one server "*--pkg all* *--exclude feature_tests"*. For first sever all the tests passed and for second onwards fail for all. - If you run only sqleditor test

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
This behaviour is very strange. Maybe another test running in parallel is enabling auto-commit or commiting the transaction? There is a problem with my machine right now, can you skip this test for this release if the issue is not resolved? Sorry for the inconvenience. On Mon, Aug 19, 2019,

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Can you send me the error message? Unfortunately there is a problem with my machine right now I am unable to investigate it myself, I am very sorry for the inconvenience. On Mon, Aug 19, 2019, 2:08 PM Akshay Joshi wrote: > Hi Yosry > > We have tried a lot to figure out the issue but didn't find

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry We have tried a lot to figure out the issue but didn't find the actual cause. Can you please figure out and send the patch asap, I'll have to create candidate build tomorrow. On Mon, Aug 19, 2019 at 1:22 PM Yosry Muhammad wrote: > Hi Akshay, > > I am sorry I do not have access to my

Re: Transaction Status Python Tests

2019-08-19 Thread Yosry Muhammad
Hi Akshay, I am sorry I do not have access to my machine right now. I will try to work on it (and the JS patch) once I get the chance to. On Mon, Aug 19, 2019, 9:49 AM Akshay Joshi wrote: > Hi Yosry > > Test cases are failing on our build machines. When I reviewed your patch I > have run test

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Hi Yosry Test cases are failing on our build machines. When I reviewed your patch I have run test cases with paramaster "*--pkg tools.sqleditor.tests*" on multiple database servers and every time test case has been passed. But on build machines we run test cases with parameter "*--pkg all*

Re: Transaction Status Python Tests

2019-08-19 Thread Akshay Joshi
Thanks patch applied. On Sat, Aug 17, 2019 at 6:22 PM Yosry Muhammad wrote: > Hi Hackers, > > Please find attached a patch including new python test that checks the > transaction status after executing queries and saving data when auto-commit > is on/off. It also includes some refactoring of

Transaction Status Python Tests

2019-08-17 Thread Yosry Muhammad
Hi Hackers, Please find attached a patch including new python test that checks the transaction status after executing queries and saving data when auto-commit is on/off. It also includes some refactoring of previously written python tests. Please review ! Thanks. Regards. -- *Yosry Muhammad