Re: [pgadmin-hackers] Missing make files, etc

2006-01-23 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Susemail Sent: 22 January 2006 21:08 To: pgadmin-hackers@postgresql.org Subject: Re: [pgadmin-hackers] Missing make files, etc On Sunday 22 January 2006 00:53, Dave Page wrote: -Original

[pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Magnus Hagander
Hi! Seems the config files are read as ASCII but written as UTF8. I don't think you'd normally see non-ascii characters in the values, but I definitly have them in the comments somewhere. And things should at least be consistent. Attached patch reads the file as UTF8, and doesn't change the

[pgadmin-hackers] Text/HTML files

2006-01-23 Thread Dave Page
Hi Raph, I finally got round to converting the pgAdmin files like BUGS.txt to plain text as you requested some time back. I also renamed them to BUGS, LICENSE, README, CHANGELOG etc. for consistency with other packages. Dunno if you need to tweak any of the Debian packing to accommodate the

[pgadmin-hackers] SVN Commit by dpage: r4951 - in branches/REL-1_4_0_PATCHES/pgadmin3: . src/frm

2006-01-23 Thread svn
Author: dpage Date: 2006-01-23 13:39:29 + (Mon, 23 Jan 2006) New Revision: 4951 Modified: branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmConfig.cpp Log: Read config files as uTF-8 [Magnus Hagander] Modified:

[pgadmin-hackers] SVN Commit by dpage: r4952 - in trunk/pgadmin3: . src/frm

2006-01-23 Thread svn
Author: dpage Date: 2006-01-23 13:48:10 + (Mon, 23 Jan 2006) New Revision: 4952 Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/src/frm/frmConfig.cpp Log: Read config files as uTF-8 [Magnus Hagander] Replace some missing changelog entries that I seem to have lost Modified:

Re: [pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Dave Page
Thanks, patch applied to 1.4.x and 1.6. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Magnus Hagander Sent: 23 January 2006 11:33 To: pgadmin-hackers@postgresql.org Subject: [pgadmin-hackers] bugfix: Encoding of config files Hi! Seems

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Dave Page
Patch discussed with Magnus on IM. To be reposted with fixes for the following: - Undo button doesn't undo a delete. - There is no delete button on the dialogue - Help button on the main editor window doesn't work. Regards, Dave. -Original Message- From: [EMAIL PROTECTED]

Re: [pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Andreas Pflug
Dave Page wrote: Thanks, patch applied to 1.4.x and 1.6. Hm, this certainly should be consistent, but I'd guess most files will use a 1-byte system charset, not UTF8, thus wxConvLibc not wxConvUTF8 is the right one. Regards, Andreas ---(end of

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Magnus Hagander
Attached patch implements an editor for pgpass.conf/.pgpass modeled on the HBA editor. In doing so it also: Do we need this? .pgpass is maintained automatically from pgAdmin. No it's not :-) Not if you want to use wildcards, for example. Or did I miss some way of doing that? * Adds the

Re: [pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Magnus Hagander
Thanks, patch applied to 1.4.x and 1.6. Hm, this certainly should be consistent, but I'd guess most files will use a 1-byte system charset, not UTF8, thus wxConvLibc not wxConvUTF8 is the right one. I for one certainly bow to that one. As said before, the encodings dealings is

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Andreas Pflug
Magnus Hagander wrote: Attached patch implements an editor for pgpass.conf/.pgpass modeled on the HBA editor. In doing so it also: Do we need this? .pgpass is maintained automatically from pgAdmin. No it's not :-) Not if you want to use wildcards, for example. Or

Re: [pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Andreas Pflug
Magnus Hagander wrote: Thanks, patch applied to 1.4.x and 1.6. Hm, this certainly should be consistent, but I'd guess most files will use a 1-byte system charset, not UTF8, thus wxConvLibc not wxConvUTF8 is the right one. I for one certainly bow to that one. As said before,

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Magnus Hagander
Do we need this? .pgpass is maintained automatically from pgAdmin. No it's not :-) Not if you want to use wildcards, for example. Or did I miss some way of doing that? Ok. Hope users don't get confused that pgAdmin uses two ways to (partially :-) maintain the file. Users

Re: [pgadmin-hackers] Missing make files, etc

2006-01-23 Thread Susemail
On Sunday 22 January 2006 23:13, Dave Page wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Susemail Sent: 22 January 2006 21:08 To: pgadmin-hackers@postgresql.org Subject: Re: [pgadmin-hackers] Missing make files, etc On Sunday 22

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Andreas Pflug
Magnus Hagander wrote: ly :-) maintain the file. Users are alreayd confused because pgadmin doesn't tell them that the save your password checkbox affects all non-pgadmin applications as well :-P (Yes, I've been bitten myself. And had to explain it to several others that hav ebeen..)

Re: [pgadmin-hackers] Text/HTML files

2006-01-23 Thread Raphaël Enrici
Dave Page wrote: Hi Raph, Night' Dave, I finally got round to converting the pgAdmin files like BUGS.txt to plain text as you requested some time back. I also renamed them to BUGS, LICENSE, README, CHANGELOG etc. for consistency with other packages. Dunno if you need to tweak any of

Re: [pgadmin-hackers] Patch: Config editors

2006-01-23 Thread Dave Page
On 23/1/06 18:55, Andreas Pflug [EMAIL PROTECTED] wrote: Ok. Hope users don't get confused that pgAdmin uses two ways to (partially :-) maintain the file. It'll also be handy for maintaining files other than your own, such as used for your pgAgent service account. /D

Re: [pgadmin-hackers] bugfix: Encoding of config files

2006-01-23 Thread Dave Page
On 23/1/06 18:53, Magnus Hagander [EMAIL PROTECTED] wrote: Thanks, patch applied to 1.4.x and 1.6. Hm, this certainly should be consistent, but I'd guess most files will use a 1-byte system charset, not UTF8, thus wxConvLibc not wxConvUTF8 is the right one. I for one certainly

[pgadmin-hackers] SVN Commit by dpage: r4953 - in trunk/pgadmin3: . src/frm

2006-01-23 Thread svn
Author: dpage Date: 2006-01-23 20:21:03 + (Mon, 23 Jan 2006) New Revision: 4953 Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/src/frm/frmConfig.cpp Log: Use wxConvLibc not wxConvUtf8, per Andreas Modified: trunk/pgadmin3/CHANGELOG

Re: [pgadmin-hackers] Missing make files, etc

2006-01-23 Thread Dave Page
On 23/1/06 19:02, Susemail [EMAIL PROTECTED] wrote: So does this mean the copy of pgadmin3 I have is not corrupted? Yes. Which means that pgAdmin3.cpp must be in there somewhere! Regards, Dave. ---(end of broadcast)--- TIP 1: if

[pgadmin-hackers] SVN Commit by dpage: r4954 - in branches/REL-1_4_0_PATCHES/pgadmin3: . src/frm

2006-01-23 Thread svn
Author: dpage Date: 2006-01-23 20:25:32 + (Mon, 23 Jan 2006) New Revision: 4954 Modified: branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmConfig.cpp Log: Use wxConvLibc, not wxConvUTF8, per Andreas Modified:

Re: [pgadmin-hackers] Text/HTML files

2006-01-23 Thread Dave Page
On 23/1/06 20:02, Raphaël Enrici [EMAIL PROTECTED] wrote: Dave Page wrote: Hi Raph, Night' Dave, I finally got round to converting the pgAdmin files like BUGS.txt to plain text as you requested some time back. I also renamed them to BUGS, LICENSE, README, CHANGELOG etc. for