Re: [pgadmin-hackers] Finnish translation update

2007-09-26 Thread Guillaume Lelarge
Heikki Linnakangas a écrit : > Here is the updated Finnish translation. I translated the tips and guru > hints as well while I was at it. The work seemed quite incomplete > without them, since I immediately bumped into an untranslated hint page, > since I was testing with an SQL_ASCII database. I a

[pgadmin-hackers] SVN Commit by guillaume: r6677 - in trunk/pgadmin3: docs docs/en_US/hints docs/fi_FI docs/fi_FI/hints i18n/fi_FI

2007-09-26 Thread svn
Author: guillaume Date: 2007-09-26 23:49:43 +0100 (Wed, 26 Sep 2007) New Revision: 6677 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6677&view=rev Log: Update finnish's translation. Add finnish's hints. And fix a typo in an english hint. Thanks, Heikki :) Added: trun

[pgadmin-hackers] Patch to enable/disable rule on a table

2007-09-26 Thread Guillaume Lelarge
Hi all, Here is a patch to support this new PostgreSQL 8.3 feature : the possibility to enable and disable a rule on a table. Regards. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/include/schema/pgRule.h ==

[pgadmin-hackers] Viewing data of a zero-column table gives an assertion failure

2007-09-26 Thread Heikki Linnakangas
Viewing data of a table with zero columns triggers this assertion: ./db/pgSet.cpp(222): assert "col < nCols && col >= 0" failed in GetVal(). [in child thread] To reproduce, create a table with no columns, and click "View Data" -> "First 100 rows". This is with an up-to-date SVN checkout. --

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > Heikki Linnakangas wrote: >> There's some strings in calls to wxLogDebug, like "OnTargetComplete() >> called", that are wrapped in _() for translation. Aren't those just for >> developers, and therefore a waste of time to translate? > > Yep. Removed. Here's a few more, though I

Re: [pgadmin-hackers] Patch to add typmod's functions to a type's creation statement

2007-09-26 Thread Dave Page
Added to my patch queue. Thanks, Dave > --- Original Message --- > From: Guillaume Lelarge <[EMAIL PROTECTED]> > To: [email protected] > Sent: 26/09/07, 18:15:25 > Subject: Patch to add typmod's functions to a type's creation statement > > Hi all, > > Here is a patch to sup

[pgadmin-hackers] Patch to add typmod's functions to a type's creation statement

2007-09-26 Thread Guillaume Lelarge
Hi all, Here is a patch to support this new PostgreSQL 8.3 feature : the possibility to add type modifier input and ouput functions to a newly created type. I tried many things but wasn't able to test it. If someone has an example of a use of this statement, can he send it to me or can he test my

[pgadmin-hackers] SVN Commit by guillaume: r6676 - trunk/pgadmin3/pgadmin/dlg

2007-09-26 Thread svn
Author: guillaume Date: 2007-09-26 18:08:43 +0100 (Wed, 26 Sep 2007) New Revision: 6676 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6676&view=rev Log: Send and receive unctions' combobox weren't append correctly. Modified: trunk/pgadmin3/pgadmin/dlg/dlgType.cpp

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Jyrki Wahlstedt wrote: > On 26.9.2007, at 14.26, Heikki Linnakangas wrote: >> Finnish texts do tend to more longer than English. It's not a problem in >> most places, but for example "Rename" in the favourites manager is >> translated to "Nimeä uudelleen", which is quite a bit longer. If we just >>

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > I'd be more interested in the patches so I can update my utilities and > those of developer.pgadmin.org where stringextract tends to be run (I > imagine Guillaume would like a copy too). Ok. Here's two patches to enable that: wx-linenumbers-in-wxrc-1.patch (against wxWidgets SV

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: Dave Page wrote: REINDEX is similar to a drop and recreate of the index in that the index contents are rebuilt from scratch. However, the locking considerations are rather different. REINDEX locks out writes but not reads of the index's parent table. It also takes an ex

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > REINDEX is similar to a drop and recreate of the index in that the index > contents are rebuilt from scratch. However, the locking considerations > are rather different. REINDEX locks out writes but not reads of the > index's parent table. It also takes an exclusive lock on the s

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Guillaume Lelarge
Dave Page a écrit : > Heikki Linnakangas wrote: > [...] >> Meanwhile, anyone interested in the pgadmin3.pot file I have here with >> the file/line numbers in it? I can post it if so.. > > I'd be more interested in the patches so I can update my utilities and > those of developer.pgadmin.org where

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Guillaume Lelarge
Dave Page a écrit : > [Guillaume; I've left some of Heikki's suggestions to your discretion, > please read on...] > Thanks :) >> Attached is a patch to change a few string constructions to be more >> localization-friendly. There's still a lot of troublesome constructs >> like "Cannot drop system

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Jyrki Wahlstedt wrote: On 26.9.2007, at 14.26, Heikki Linnakangas wrote: Dave Page As you know I work in OS X and Windows most of the time and I know there are no sizing issues there in English. Is this something specific to running in Finnish (should that be Fin?), or GTK do you think? FI

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: RECREATE is a pgAdmin extension that drops and recreates an index. What's the advantage of that, compared to normal REINDEX? Quoth the PG docs: REINDEX is similar to a drop and recreate of the index in that the index contents are rebuilt from scratch. However, the

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Jyrki Wahlstedt
On 26.9.2007, at 14.26, Heikki Linnakangas wrote: Dave Page As you know I work in OS X and Windows most of the time and I know there are no sizing issues there in English. Is this something specific to running in Finnish (should that be Fin?), or GTK do you think? FI (or fi) should be enou

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Heikki Linnakangas wrote: Really? . No, that change was backpatched all the way to 8.1 branch, which is the first release with 2PC. The check is in src/backend/access/transam/twophase.c: Rats - seems the test server I was using was 8.2.2. Oh well, easy fix committed. Thanks, Dave. -

[pgadmin-hackers] SVN Commit by dpage: r6675 - trunk/pgadmin3/pgadmin/frm

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 12:34:21 +0100 (Wed, 26 Sep 2007) New Revision: 6675 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6675&view=rev Log: Gah, must update all my test installations of 8.2. Seems that prepared transactions must be committed or rolled back in their

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > [Guillaume; I've left some of Heikki's suggestions to your discretion, > please read on...] > > Heikki Linnakangas wrote: >> When creating a table or index, it would be nice if we checked that the >> value given for fillfactor is valid, within 0-100, in pgAdmin. Would be >> nice

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Dave Page wrote: > Dave Page wrote: >>> When trying to commit/rollback a prepared transaction in a database >>> other than 'postgres', using the "server status" dialog, I always get >>> this error message: >>> >>> ERROR: prepared transaction belongs to another database >>> HINT: Connect to the da

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
Dave Page wrote: When trying to commit/rollback a prepared transaction in a database other than 'postgres', using the "server status" dialog, I always get this error message: ERROR: prepared transaction belongs to another database HINT: Connect to the database where the transaction was prepare

[pgadmin-hackers] SVN Commit by dpage: r6674 - in trunk/pgadmin3/pgadmin: frm include/db include/frm

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 12:09:42 +0100 (Wed, 26 Sep 2007) New Revision: 6674 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6674&view=rev Log: Postgres 8.3 and above require that prepared transactions be committed or rolled back in the database they were prepared in.

[pgadmin-hackers] SVN Commit by dpage: r6673 - trunk/pgadmin3

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 10:31:13 +0100 (Wed, 26 Sep 2007) New Revision: 6673 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6673&view=rev Log: Template update after removing (yes, removing :-) ) so strings that weren't required. Modified: trunk/pgadmin3/pgadmin3

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Dave Page
[Guillaume; I've left some of Heikki's suggestions to your discretion, please read on...] Heikki Linnakangas wrote: Hi, I'm working on the Finnish translation to bring it up-to-date, and bumped into a few minor issues, mostly localization related. This is the first time I'm hacking or even usi

[pgadmin-hackers] SVN Commit by dpage: r6672 - in trunk/pgadmin3/i18n: af_ZA ar_SA bg_BG ca_ES cs_CZ da_DK de_CH de_DE el_GR es_ES fa_IR fi_FI fr_FR gl_ES gu_IN hi_IN hr_HR hu_HU id_ID is_IS it_IT ja_

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 10:28:57 +0100 (Wed, 26 Sep 2007) New Revision: 6672 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6672&view=rev Log: Automatic merge using stringmerge script. Modified: trunk/pgadmin3/i18n/af_ZA/pgadmin3.po trunk/pgadmin3/i18n/ar_SA/pg

[pgadmin-hackers] SVN Commit by dpage: r6671 - in trunk/pgadmin3/pgadmin: debugger dlg

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 10:27:34 +0100 (Wed, 26 Sep 2007) New Revision: 6671 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6671&view=rev Log: Avoid translating debug messages. Per Heikki Linnakangas Modified: trunk/pgadmin3/pgadmin/debugger/dbgPgThread.cpp tru

[pgadmin-hackers] SVN Commit by dpage: r6670 - in trunk/pgadmin3/pgadmin: frm include/frm

2007-09-26 Thread svn
Author: dpage Date: 2007-09-26 10:04:54 +0100 (Wed, 26 Sep 2007) New Revision: 6670 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6670&view=rev Log: Enable/disable the copy quote character option when quoting is enabled/disabled. Per suggestion from Heikki Linnakangas. Mo

[pgadmin-hackers] SVN Commit by guillaume: r6669 - trunk/pgadmin3/i18n/fr_FR

2007-09-26 Thread svn
Author: guillaume Date: 2007-09-26 09:08:50 +0100 (Wed, 26 Sep 2007) New Revision: 6669 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6669&view=rev Log: Update french translation. Modified: trunk/pgadmin3/i18n/fr_FR/pgadmin3.mo trunk/pgadmin3/i18n/fr_FR/pgadmin3.po

Re: [pgadmin-hackers] A bunch of minor issues

2007-09-26 Thread Heikki Linnakangas
Euler Taveira de Oliveira wrote: > Heikki Linnakangas wrote: >> Attached is a patch to change a few string constructions to be more >> localization-friendly. There's still a lot of troublesome constructs > where is the patch? Oh crap. Here.. -- Heikki Linnakangas EnterpriseDB http://www.en