Re: [pgadmin-hackers] PATCH: Save settings regardless of Find&Replace dialog's close method

2014-04-02 Thread Ashesh Vashi
On Thu, Apr 3, 2014 at 1:07 AM, Dave Page wrote: > We don't have a cancel option for Search/Replace. We only have Close - > which is what the X button does, so I think we should save in all cases. > Ok. In that case - the patch looks good to me. > > > On Wed, Apr 2, 2014 at 11:02 AM, Ashesh Vash

Re: [pgadmin-hackers] PATCH: Save settings regardless of Find&Replace dialog's close method

2014-04-02 Thread Dave Page
We don't have a cancel option for Search/Replace. We only have Close - which is what the X button does, so I think we should save in all cases. On Wed, Apr 2, 2014 at 11:02 AM, Ashesh Vashi wrote: > Dave/J.F. > > My thinking for this is little different. > In general, if a user cancels any oper

[pgadmin-hackers] pgAdmin III commit: Greenplum documentation path changes

2014-04-02 Thread Ashesh Vashi
Greenplum documentation path changes Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c7c7c7581516739ee936c516b5587d240444b667 Author: Andreas Scherbaum Modified Files -- pgadmin/pgAdmin3.cpp | 74 +++

Re: [pgadmin-hackers] Documentation patch

2014-04-02 Thread Ashesh Vashi
Done with some minor changes. On Fri, Mar 14, 2014 at 12:53 AM, Andreas 'ads' Scherbaum < [email protected]> wrote: > > Hello, > > > On 03/05/2014 11:47 AM, Akshay Joshi wrote: > >> >> Attached is the modified patch which will fix the compilation issue on >> Windows. >> > > Will someone comm

Re: [pgadmin-hackers] PATCH: Save settings regardless of Find&Replace dialog's close method

2014-04-02 Thread Ashesh Vashi
Dave/J.F. My thinking for this is little different. In general, if a user cancels any operation, he/she does not want the changes. So - we should save the settings only on "Find/Replace/ReplaceAll" action, along with Close (but - not definitely with Cancel operation/Cross button). On Thu, Mar