Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-04 Thread Dave Page
Hi On Tue, Feb 23, 2016 at 5:24 PM, Neel Patel wrote: > Hi, > > Please find attached patch file for the following three nodes. > >- Foreign Data Wrappers >- Foreign Servers >- User Mapping > > With this patch, we have implemented "Dependencies",

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-03-04 Thread Dave Page
A couple of corrections below On Fri, Mar 4, 2016 at 1:39 PM, Dave Page wrote: > Hi > > On Thu, Mar 3, 2016 at 12:49 PM, Surinder Kumar > wrote: >> Hi, >> >> PFA patch for Grant Wizard. >> >> Before applying grant wizard patch: >> >>

Re: [pgadmin-hackers] Event trigges node patch [pgadmin4]

2016-03-04 Thread Dave Page
On Fri, Feb 12, 2016 at 6:32 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch event triggers node. > > Hi It looks like this has bit-rotted. Please update and re-submit - currently it doesn't list triggers in the tree if they're already present, and if you try to

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-03-04 Thread Dave Page
Hi On Thu, Mar 3, 2016 at 12:49 PM, Surinder Kumar wrote: > Hi, > > PFA patch for Grant Wizard. > > Before applying grant wizard patch: > > 1. Apply patch for "wizard JS file" which Khushboo had shared with > Ashesh personally. > I am using

[pgadmin-hackers] pgAdmin 4 commit: Add file missing from previous commit.

2016-03-04 Thread Dave Page
Add file missing from previous commit. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5bf505e822242912e547cb9511796b1bef19067e Modified Files -- docs/en_US/code-review.rst | 55 ++ 1 file

[pgadmin-hackers] pgAdmin 4 commit: Add some code review notes/hints to the docs.

2016-03-04 Thread Dave Page
Add some code review notes/hints to the docs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f6c8fdd6efd6d564ed7781b7ac3892dc1e47f21 Modified Files -- docs/en_US/code-snippet.rst | 113 --

[pgadmin-hackers] pgAdmin 4 commit: Removed the wrong copyright information in the javasc

2016-03-04 Thread Ashesh Vashi
Removed the wrong copyright information in the javascript file, which is owned by pgAdmin IV. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee71cab51e1996f4eb66d828a303dd68584c9ea9 Modified Files --

Re: [pgadmin-hackers] PATCH: Enhancement to backform controls [pgAdmin4]

2016-03-04 Thread Dave Page
Thanks, applied. On Fri, Mar 4, 2016 at 11:40 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to disable edit button functionality conditionally in backgrid. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] pgAdmin 4 commit: Enable/disable edit button functionality conditionall

2016-03-04 Thread Dave Page
Enable/disable edit button functionality conditionally in backgrid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa97b5635e55b3bc65412bed51013c0715698e65 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: Enhancement to backform controls [pgAdmin4]

2016-03-04 Thread Murtuza Zabuawala
Hi, PFA patch to disable edit button functionality conditionally in backgrid. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 4, 2016 at 4:30 PM, Dave Page wrote: > Thanks - committed.

[pgadmin-hackers] pgAdmin 4 commit: Fix an error retrieving dependents and dependencies f

2016-03-04 Thread Dave Page
Fix an error retrieving dependents and dependencies for casts. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4e819c68cb5a6d52e97a5f20a60216af0a24eb2 Author: Sanket Mehta Modified Files --

Re: [pgadmin-hackers] patch for cast module

2016-03-04 Thread Dave Page
Thanks, patch applied. On Tue, Mar 1, 2016 at 7:20 AM, Sanket Mehta wrote: > Hi, > > There was an error in cast module while fetching its dependency and > dependent. > Below is the patch which resolves this issue. > Please review and commit it. > > > > Regards, >

[pgadmin-hackers] pgAdmin 4 commit: Backform control enhancements:

2016-03-04 Thread Dave Page
Backform control enhancements: 1) Unique collection control: we have added 'Edit' button in grid, earlier it was only delete button. 2) Sql field control: We have added control to disabled & visible functionality which were not available. Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: Enhancement to backform controls [pgAdmin4]

2016-03-04 Thread Dave Page
Thanks - committed. On Fri, Mar 4, 2016 at 8:53 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add functionalities as below, > > 1) Unique collection control: we have added 'Edit' button in grid, earlier > it was only delete button. > 2) Sql field

Re: [pgadmin-hackers] Numeric control optionally allow null values [pgadmin4]

2016-03-04 Thread Dave Page
Hi On Fri, Mar 4, 2016 at 6:28 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for numeric and integer control with optionally > null value support. > > Usage: > > 1] Integer > > id: 'fillfactor', label: '{{ _('Fill factor') }}', deps: ['index'],

Re: [pgadmin-hackers] PATCH: Preferences/Options dialog

2016-03-04 Thread Dave Page
And here's the attachment. On Fri, Mar 4, 2016 at 10:27 AM, Dave Page wrote: > > > On Thu, Mar 3, 2016 at 3:40 PM, Ashesh Vashi > wrote: >> >> On Thu, Mar 3, 2016 at 7:09 PM, Dave Page wrote: >>> >>> Hi >>> >>> On Mon, Feb

[pgadmin-hackers] pgAdmin 4 commit: Allow the connection driver to return notices/message

2016-03-04 Thread Dave Page
Allow the connection driver to return notices/messages from the server. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b434431514dd898086ef69079d76ed3eb758ec8 Author: Ashesh Vashi Modified Files --

Re: [pgadmin-hackers] [pgAdmin IV] PATCH: Add support for the notices/messages from the backend server.

2016-03-04 Thread Dave Page
Thanks, committed. On Thu, Mar 3, 2016 at 6:00 PM, Ashesh Vashi wrote: > Hi, > > This patch implements the supports in the connection driver to fetch the > notices/messages returned by the database server. This will be used by > tools like debugger, sql-editor,

Re: [pgadmin-hackers] PATCH: Preferences/Options dialog

2016-03-04 Thread Dave Page
On Thu, Mar 3, 2016 at 3:40 PM, Ashesh Vashi wrote: > On Thu, Mar 3, 2016 at 7:09 PM, Dave Page wrote: > >> Hi >> >> On Mon, Feb 29, 2016 at 6:22 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find the

[pgadmin-hackers] PATCH: Enhancement to backform controls [pgAdmin4]

2016-03-04 Thread Murtuza Zabuawala
Hi, PFA patch to add functionalities as below, 1) Unique collection control: we have added 'Edit' button in grid, earlier it was only delete button. 2) Sql field control: We have added control to disabled & visible functionality which were not available. -- Regards, Murtuza Zabuawala