Re: [pgadmin-hackers][pgAdmin4][Patch]: Load/Save file in query tool

Hi Surinder On 13-May-2016 7:12 pm, "Surinder Kumar" wrote: > > Hi, > > Please find updated patch > > Following are the review comments given by Akshay: > 1. Save button shouldn't enable when data grid is loaded. > 2. CodeMirror text area change event should only

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Pause/Resume replay of WAL functionality

Thanks - committed with small tweaks! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, May 13, 2016 at 12:34 PM, Neel Patel

[pgadmin-hackers] pgAdmin 4 commit: Added functionality to Pause/Resume replay of WAL on

Added functionality to Pause/Resume replay of WAL on the database server. Tweaked a little bit by Ashesh. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4dc7f84761d85c94657a17533ef34e96550c3998 Author: Neel Patel

Re: [pgadmin-hackers] psycopg2 issue when returning password from sqlite db to python [pgadmin4]

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, May 13, 2016 at 3:47 PM, Harshal Dhumal <

[pgadmin-hackers] pgAdmin 4 commit: Always make sure - we convert the psasword to string

Always make sure - we convert the psasword to string in the as_dict function. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14839bf5dedfc5f433b5e82209acc5f18f0a2287 Author: Harshal Dhumal Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Fixed the canDrop function of the node menus does not

Fixed the canDrop function of the node menus does not get called during enable/disable menu checks. Tweaked a little bit by Ashesh. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc91a538e07e545fb8a47d33c6ec3776fe88517e Author: Surinder Kumar

[pgadmin-hackers] pgAdmin 4 commit: Improvise the pgsql driver to keep the utility names

Improvise the pgsql driver to keep the utility names used for different operation like backup, restore, etc within it. Also: * improvised the color combination of the background process logger. * Removed an unnecessary print statement from the get_storage_directory(..) function, also return

[pgadmin-hackers] pgAdmin 4 commit: Improvised the file manager functionalities as per co

Improvised the file manager functionalities as per comments given: * Do not show the drives on windows, if STORAGE_DIR is set. * Do not show non-applicable buttons, whenever no files/directory present in the storage directory. * Showing dimmer under the warning messages for replace/delete. *

[pgadmin-hackers] [pgAdmin4][Patch]: Menu's canDrop as function is not callable

Hi, Please find the attached patch for the issue "Menu's canDrop option as function is not called" I am using canDrop option as function in rule node like below: *canDrop: function(itemData, item, data){ * * //control does't come here* *}* but it does't get called. Please review the patch.

Re: [pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

Hi, PFA updated CREATE Script patch with some bug fixes & added validation. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 12, 2016 at 7:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com>

[pgadmin-hackers] pgAdmin 4 commit: Add some initial dialog docs.

Add some initial dialog docs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db62069a41d9e70edd6149ba030d499b8c1cc45b Author: Susan Douglas Modified Files -- docs/en_US/create_cast.rst

Re: [pgadmin-hackers][pgAdmin4][Patch]: Load/Save file in query tool

Hi, Please find updated patch Following are the review comments given by Akshay: 1. Save button shouldn't enable when data grid is loaded. 2. CodeMirror text area change event should only be enabled when query tool is loaded. On Thu, May 12, 2016 at 1:23 AM, Surinder Kumar <

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Review Comments: - Please replace 'can not' with 'cannot' in all the validation messages. - PG 9.1+ Inheritance issue as below: CREATE TABLE public.table1 ( ) ( ) INHERITS (a) WITH ( OIDS = FALSE ) TABLESPACE pg_default; ALTER TABLE public.table1 OWNER to postgres; brackets

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Fri, May 13, 2016 at 2:01 PM, Sandeep Thakkar wrote: > Thanks Dave. > > Please see inline. > > On Fri, May 6, 2016 at 9:03 PM, Dave Page wrote: >> >> Hi >> >> Thanks. I've applied the path fix patch. The second one needs a little >> work -

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks Dave. Please see inline. On Fri, May 6, 2016 at 9:03 PM, Dave Page wrote: > Hi > > Thanks. I've applied the path fix patch. The second one needs a little > work - I've attached an updated version to work from: > > - I've updated the README, and some of the default

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi Sanket Below are my review comments: - Add button should be disabled in Tokens tab while creating. - Unable to click on down arrow for token select control. - Title should be change from "Create FTS-dictionaries" to "Create FTS -Configuration". - Tree node is not getting

Re: [pgadmin-hackers] PATCH: Initiale backup utility [pgAdmin4]

On Tue, May 3, 2016 at 5:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add backup server/global/database object functionality. > > This patch depends on, > - File manager control patch & job executer. > > > *TODO:* > - Integrate browser tree control

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

Hi, Please find the patch for the following improvements: 1. FileManager won't show Volumes on Windows when STORAGE_DIR is set to None. On Fri, May 13, 2016 at 12:24 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Surinder, > > Thanks - it was committed! > > As discussed

Re: [pgadmin-hackers] PATCH: Graphincal explain integrated in sql editor

Hi, Apart from resolving all the issues mentioned in previous mail, All the explain options and auto rollback/auto commit are also added to preferences dialog. Any change to explains options or auto-rollback/auto-commit in sql editor will directly reflect its corresponding option in preference

[pgadmin-hackers] psycopg2 issue when returning password from sqlite db to python [pgadmin4]

Hi, PFA minor patch for psycopg2 Issue fixed: cast password to string before returning serverManager as_dict() -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Fixed following issues:

Fixed following issues: 1) Grant wizard close issue. 2) Moved grant wizard specific css from wizard.css to grant_wizard.css 3) removed 'ajs_content' css from wizard.css causing padding issue in alertify dialog Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi All, Last patch for FTS configuration does not contain node.ui.js file Kindly ignore it. Here is the new revised patch attached with this mail. Please do review it and let me know if any changes required Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, May 12, 2016 at 4:38

[pgadmin-hackers] pgAdmin 4 commit: Fixed typo for acl in tablespace node

Fixed typo for acl in tablespace node Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=174363c9a7d380b9599fdb029997fa2c925322e0 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: Fixed typo in Tablespace node (pgAdmin4)

Thanks - Committed. On Thu, May 12, 2016 at 8:17 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to correct the typo in tablespace node. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >

Re: [pgadmin-hackers] Change server password [pgadmin4]

On Thu, May 12, 2016 at 11:45 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB > > On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >>

[pgadmin-hackers] pgAdmin 4 commit: Change server password feature

Change server password feature Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4816f5ed125e8c8c60ac80d519d2fbce44ec21ff Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] [pgAdmin4][Patch]: Pause/Resume replay of WAL functionality

Hi, Please find the attached patch file which contains the functionality of "Pause/Resume replay of WAL". Do review it and let us know for any comments. Thanks, Neel Patel WAL_pause_resume_replay.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] Re: Error messages displayed with pgAdmin4.py when user done latest git pull for pgAdmin4

Thanks It's already resolved by Neel and Akshay with minor patch "cStringIO and StringIO module compatibility in python" Regards On Fri, May 13, 2016 at 9:52 AM, Fahar Abbas wrote: > Hi, > > Following error message displayed pgAdmin4.py when user done latest git >