[pgadmin-hackers][patch] Test dependencies and screenshots

Hi Hackers We noticed that the feature test dependencies were removed in a recent patch, so we added them back. We also now create a screenshot with a timestamp when tests fail. This should help with debugging issues in CI. -- Thanks Joao & Tira 0001-Added-feature-test-dependencies.patch Descr

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

You're going to deal with the final review/commit right Ashesh? On Wed, Mar 1, 2017 at 11:41 AM, Murtuza Zabuawala wrote: > Hi, > > Patch looks good to me, Tested with Python3.5(manually) attached screenshot > & Python2.7 (using TestSuite). > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: ht

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

On Wed, Mar 1, 2017 at 10:27 PM, Dave Page wrote: > You're going to deal with the final review/commit right Ashesh? > Yes - I am planning to. > > On Wed, Mar 1, 2017 at 11:41 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > Patch looks good to me, Tested with Python3.5(manually) attached > screen

Re: [pgadmin-hackers] Readme Requirements Fix

Hi On Wed, Mar 1, 2017 at 2:09 PM, Jonas Thelemann wrote: > Good day pgadmin-hackers, > > I just want to suggest to change two lines in the README to fit the new > requirements.txt file. I made (essentially) those changes when I committed the patch - see https://git.postgresql.org/gitweb/?p=pgad

[pgadmin-hackers] Readme Requirements Fix

Good day pgadmin-hackers, I just want to suggest to change two lines in the README to fit the new requirements.txt file. Have a nice evening, Jonas Thelemann diff --git a/README b/README index 3d41ebdd..ad390b00 100644 --- a/README +++ b/README @@ -99,9 +99,7 @@ process is fairly simple - ada

Re: [pgadmin-hackers][patch] Make feature test app teardown more reliable, and tests faster

Awesome - thanks, patch applied. On Tue, Feb 28, 2017 at 10:40 PM, Atira Odhner wrote: > > Hi Hackers, > > We made the following improvements to the test suite: > > Make feature test app teardown more reliable, and tests faster > > - don't spin up app and chromedriver between each test >

[pgadmin-hackers] pgAdmin 4 commit: Make feature test app teardown more reliable, and tes

Make feature test app teardown more reliable, and tests faster - don't spin up app and chromedriver between each test - catching signals also tears down the app - do layout reset between tests, but assume that tests will not leave a modal opened. Use selenium built-in waiting functi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2173: Sequences API test cases are not working in PG9.2 and PPAS9.2

Thanks, patch applied. On Wed, Mar 1, 2017 at 11:43 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM 2173: Sequences API test cases > are not working in PG9.2 and PPAS9.2 > > The query which fetches the privileges was not compatible with Postgres 9.2. > So, To fix

[pgadmin-hackers] pgAdmin 4 commit: Typo fixes.

Typo fixes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59c6be534da0ed612e00c3cb207c656bbe012a12 Modified Files -- .../servers/databases/schemas/synonyms/tests/test_synonym_add.py| 2 +- .../servers/databases/schemas/syno

[pgadmin-hackers] pgAdmin 4 commit: Fix Sequence ACL SQL for PG 9.3/9.2.

Fix Sequence ACL SQL for PG 9.3/9.2. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ddb8bad2019f8d5f0b3583482fcfdd2a5de38f22 Author: Khushboo Vashi Modified Files -- .../schemas/sequences/templates/sequence/sql/default/acl.sql

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Thanks! On Wed, Mar 1, 2017 at 11:36 AM, Akshay Joshi wrote: > Thanks patch applied. > > Fixed one issue where "Data Output" panel was not cleared in case of > error. > > On Tue, Feb 28, 2017 at 7:08 PM, Dave Page wrote: > >> [Adding Akshay] >> >> On Tue, Feb 28, 2017 at 1:37 PM, Dave Page wro

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2173: Sequences API test cases are not working in PG9.2 and PPAS9.2

Hi, Please find the attached patch to fix the RM 2173: Sequences API test cases are not working in PG9.2 and PPAS9.2 The query which fetches the privileges was not compatible with Postgres 9.2. So, To fix this issue I have changed the query little bit. Dave/Ashesh, Please review my query change

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Thanks patch applied. Fixed one issue where "Data Output" panel was not cleared in case of error. On Tue, Feb 28, 2017 at 7:08 PM, Dave Page wrote: > [Adding Akshay] > > On Tue, Feb 28, 2017 at 1:37 PM, Dave Page wrote: > > Thanks Murtuza. > > > > Akshay, can you please review/commit this by

[pgadmin-hackers] pgAdmin 4 commit: Query tool efficiency.Convert the data as a 2D array

Query tool efficiency.Convert the data as a 2D array instead of dict. Fixes #2036 Incremental back off when polling. Fixes #2038 Initial Patch By: Dave Page Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=480e00fddf444b9355613ae80277c5c47a8fe4

[pgadmin-hackers] pgAdmin 4 commit: Ignore Visual Studio code editor files.

Ignore Visual Studio code editor files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d438fec5e8b3fa6ce3713d666239ab8380c6b3e Author: Murtuza Zabuawala Modified Files -- .gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent