Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-26 Thread Khushboo Vashi
Hi Joao & Sarah, On Wed, Apr 26, 2017 at 8:46 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo! > > Thanks for your reply! > > >> *SQL Files:* >>> >>>- Is there a way to avoid conditionals here? >>> >>> >>>- Maybe we can use the same javascript

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-26 Thread Ashesh Vashi
On Wed, Apr 26, 2017 at 9:56 PM, Dave Page wrote: > > > On Wed, Apr 26, 2017 at 4:45 PM, Shirley Wang wrote: > >> >> >> I think the addition of icons and some copy would help: >> [image: Screen Shot 2017-04-26 at 11.28.41 AM.png] >> > > Agreed. > +1 --

[pgadmin-hackers] Issue with SlickGrid

2017-04-26 Thread Joao Pedro De Almeida Pereira
Hello Hackers, While doing some changes to the Query Results we found out that there was a issue with Slick grid. The issue that we found was with the CellSelectModel, behaved differently when pressing Ctrl and Command(Mac). We created a PR with the

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-26 Thread Shirley Wang
Hello! On Wed, Apr 26, 2017 at 4:26 AM Dave Page wrote: > Hi > > [moving to the pgadmin-hackers mailing list as this a pgAdmin feature] > > On Wed, Apr 26, 2017 at 8:20 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> Murtuza and I started

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-26 Thread Dave Page
On Wed, Apr 26, 2017 at 4:45 PM, Shirley Wang wrote: > > > I think the addition of icons and some copy would help: > [image: Screen Shot 2017-04-26 at 11.28.41 AM.png] > Agreed. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-04-26 Thread Joao Pedro De Almeida Pereira
Hello Ashesh, Thanks for reviewing the patch. We added the __init__.py files into templates to convert them into packages so that the tests inside of them can be found by the test runner. Thanks! Joao & Sarah On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi wrote:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-26 Thread Joao Pedro De Almeida Pereira
Hi Khushboo! Thanks for your reply! > *SQL Files:* >> >>- Is there a way to avoid conditionals here? >> >> >>- Maybe we can use the same javascript function to prettify all the >>sizes >> >> >> In case of collection node (ex: Databases), I have implemented this >> functionality via

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-26 Thread Dave Page
Hi [moving to the pgadmin-hackers mailing list as this a pgAdmin feature] On Wed, Apr 26, 2017 at 8:20 AM, Akshay Joshi wrote: > Hi Dave > > Murtuza and I started thinking about "How to add Declarative > Partitioning" support in pgAdmin4. We thought instead of

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-26 Thread Dave Page
Hi! On Tue, Apr 25, 2017 at 9:33 PM, Shirley Wang wrote: > Hello! > > *Update on alerts* > Here are mockups of error and update alert styles, as modeled by > bootstrap. > > Success messages appear > - after running a query > - adding a database (database connected) > > Error