Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-11 Thread Murtuza Zabuawala
Hi Ashesh, As discussed please find updated patch removing hardcoded check for server & server-group node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-11 Thread Surinder Kumar
Hi Dave, Please find updated patch On Thu, May 11, 2017 at 2:29 PM, Dave Page wrote: > Ooops, managed to hit send too soon. > > ... it leads to failed updates such as: > > 2017-05-11 09:55:47,570: SQL pgadmin: Execute (void) for server #1 - > CONN:2096775 (Query-id: 4540472): > UPDATE public.de

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

2017-05-11 Thread Joao Pedro De Almeida Pereira
Hi Murtuza, Since you are adding a new function to the browser.js component, we would encourage you to extract the function out of the templated javascript file so that it can be tested. A good example of this would be the pgadmin/static/js/size_prettify.js. For this specific function we found on

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issues with CSV file download

2017-05-11 Thread Murtuza Zabuawala
Hi Dave, Please find patch to handle non-ascii column names in CSV for Pyhton2. Thanks to Harshal for pointing out the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 8, 2017 at 6:06 PM, Dave Page wrote: > Thanks, p

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-11 Thread Akshay Joshi
Hi Dave On Thu, May 11, 2017 at 6:54 PM, Dave Page wrote: > > > On Thu, May 11, 2017 at 11:35 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Thu, May 4, 2017 at 4:00 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, May 4, 2017 at 10:29 AM, Akshay Joshi < >>> akshay.jo

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-11 Thread Anne Thomas
Akshay, Dave, I'm filling in for Shirley this week. If you are referring to the weekly meeting tomorrow, I'm planning on joining that and can walk through an exercise to help figure out prioritization. Thanks, Anne On Thu, May 11, 2017 at 9:24 AM Dave Page wrote: > On Thu, May 11, 2017 at 11:3

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-11 Thread Dave Page
On Thu, May 11, 2017 at 11:35 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi > > On Thu, May 4, 2017 at 4:00 PM, Dave Page wrote: > >> Hi >> >> On Thu, May 4, 2017 at 10:29 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> On Wed, May 3, 2017 at 5:35

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-11 Thread Joao Pedro De Almeida Pereira
Hello all, This test is trying to check if the sql to retrieve the role dependencies of a object in the database is correct. Using a different user to connect to the database and create tables there is no need for extra setup because the role depedencies table entry is added automatically. Also we

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-11 Thread Akshay Joshi
Hi On Thu, May 4, 2017 at 4:00 PM, Dave Page wrote: > Hi > > On Thu, May 4, 2017 at 10:29 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> On Wed, May 3, 2017 at 5:35 PM, Dave Page wrote: >> >>> Great, thanks. >>> >>> I think it's clear that we need to display the ch

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-11 Thread Dave Page
Hi On Thu, May 11, 2017 at 10:27 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Thu, May 11, 2017 at 2:45 PM, Dave Page wrote: > >> BTW - on a related note, I was seeing this failure in the tests: >> >> FAIL: runTest (pgadmin.feature_tests.pg_data >> type_validation_test.PGDat

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-11 Thread Khushboo Vashi
On Thu, May 11, 2017 at 2:45 PM, Dave Page wrote: > BTW - on a related note, I was seeing this failure in the tests: > > FAIL: runTest (pgadmin.feature_tests.pg_datatype_validation_test.PGDataype > FeatureTest) > Test checks for PG data-types output > -

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-11 Thread Dave Page
BTW - on a related note, I was seeing this failure in the tests: FAIL: runTest (pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest) Test checks for PG data-types output -- Traceback (most recent call last): F

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-11 Thread Dave Page
Hi On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > As we have been facing many issues with different data-type display in > Query Tool output, Dave suggested to write the feature test for the same. > > I have started with some basic set of data-

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-11 Thread Dave Page
Ooops, managed to hit send too soon. ... it leads to failed updates such as: 2017-05-11 09:55:47,570: SQL pgadmin: Execute (void) for server #1 - CONN:2096775 (Query-id: 4540472): UPDATE public.defaults SET data_default_no_nulls = 'asas' WHERE ; 2017-05-11 09:55:47,577: ERROR pgadmin: Failed to e

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-11 Thread Dave Page
Hi There seems to be couple of bugs in this; - When creating a new row with my test table, if I click in the id column, don't change anything, then click in another column, the ID column value changes from [default] to [null], making it impossible to save that row with the default value. In this

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

2017-05-11 Thread Devrim Gündüz
Hi, On Wed, 2017-05-10 at 10:02 -0700, Josh Berkus wrote: > So to make this work, pgadmin-v1-web needs to be a completely separate > package, no? I don't think so, we can define Requires: part separately. Give me some time please, let me push today's releases out first, then next week I can wor

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-11 Thread Khushboo Vashi
On Thu, May 11, 2017 at 12:03 PM, Dave Page wrote: > > > On 11 May 2017, at 07:11, Akshay Joshi > wrote: > > Hi Sarah > > On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear > wrote: > >> Hi Ashkay! >> >> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >>> below error: >>>

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

2017-05-11 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user hides the any node from Preference dialog but the menu(both context/object) still appears in pgAdmin4. RM#2225 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templ