Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave, Please find updated patch with following changes: 1) Locate grid row by div's style attribute 'top'(i.e. 'top:0px' for first row), instead of by div class-name because the order of rendered rows is not always same. 2) Increase the wait timeout of WebDriverWait to 5 seconds in '_compare_

[pgadmin-hackers] [pgAdmin4][PATCH] Display Security Labels in SQL (PPAS9.2+)

Hi, PFA minor patch to fix the issue where Security Labels were not displaying in Reversed engineered schema SQL for PPAS9.2+. RM#1575 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/

Re: [pgadmin-hackers] Process for Creating Translations

Right, you don't need to do anything except wrap strings in the appropriate macros/functions. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company On 2 Jun 2017, at 15:47, Matthew Kleiman wrote: >> I pe

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave! It looks like everything has been addressed with this current patch, aside from the feature test for for edit table tool. If we agree that Surinder can send that patch on a separate thread, is this patch good to be committed? Thanks, Matt On Thu, Jun 1, 2017 at 11:17 AM, Robert Eckhardt

Re: [pgadmin-hackers] Process for Creating Translations

> > I periodically update the translation templates, and then put a shout > out to the translators. I try to minimise that though - I don't want > to be pinging them every other commit for obvious reasons. Thanks for the response, Dave. To clarify, we should continue to wrap English text in the g

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

We are working on this now. Should I open a bug or a feature in redmine to track this work publicly or just keep it in our backlog only? On Thu, Jun 1, 2017 at 11:11 AM, Dave Page wrote: > > > On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman > wrote: > >> Hi Hackers! >> >> We noticed that there

[pgadmin-hackers] [pgAdmin4][PATCH] To make $ quoting consistent

Hi, PFA patch to make to $ quoting consistent. in Function node RM#1525 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/9.2_plus/

[pgadmin-hackers] [pgAdmin4][Patch][RM_2448]: Multiple button presses to switch boolean fields

Hi The behaviour for checkbox click will go "false -> true -> null ->" Please find attached patch and review. Thanks, Surinder Kumar RM_2448.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://w

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the validation in Types node

Hi, PFA patch to fix the validation issues with Range & External type in Types node. RM#1795 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.py b/web