Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-02 Thread Dave Page
ted. It was because the comparison > for (defaultValue == null) return true if defaultValue is undefined. Hence > _.isNull(value) is used to fix this. > > *Feature Test cases:* > > - Introduced a new method create_table_with_query(server, db_name, query) > in test_utils.py which executes the

[pgadmin-hackers] pgAdmin 4 commit: Ensure errors thrown when deleting rows in the query

2017-05-02 Thread Dave Page
Ensure errors thrown when deleting rows in the query tool in edit mode are shown properly. Fixes #2356 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93df5e3e54ee2546e618531a4dedbe44d8659bde Author: Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Delete row server error not shown to GUI user

2017-05-02 Thread Dave Page
cription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-02 Thread Dave Page
gt; > > > -- > Regards, > Navnath Gadakh > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.

Re: [pgadmin-hackers][Patch] Rename feature test server

2017-05-02 Thread Dave Page
erver for the feature tests. > > Thanks! > Joao & Sarah > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page B

[pgadmin-hackers] pgAdmin 4 commit: Use a different server name for unit vs. feature test

2017-05-02 Thread Dave Page
Use a different server name for unit vs. feature tests to avoid some observed conflicts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4acecfa59a650369f14e1f61db8816e4eb13718a Author: Sarah McAlear Modified Files

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Dave Page
t; The issue that we found was with the CellSelectModel, behaved >>>>>> differently when pressing Ctrl and Command(Mac). We created a PR >>>>>> <https://github.com/6pac/SlickGrid/pull/100> with the change to >>>>>> changes the behavior of the plugin. >>>>>> >>>>>> When this PR is applied to the SlickGrid library we need to apply it >>>>>> to the current version of SlickGrid that we have vendorized. >>>>>> According to the libraries.txt file we are in version 2.2.4 of the >>>>>> library but a diff between our code and the libraries version 2.2.4 shows >>>>>> differences in the code. >>>>>> >>>>>> Did we do any change to SlickGrid library that is vendorized? Or is >>>>>> just the information in libraries.txt that is incorrect? >>>>>> Does anyone know any problem if we bump the version of SlickGrid to >>>>>> the newer version after the PR is applied? >>>>>> >>>>>> Thanks >>>>>> Joao >>>>>> >>>>> >>>>> >>>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
ically grouped around their inheritance > properties. > > How might you propose grouping them (based on the way they work in Postgres)? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
what I had in mind, yes. There are certain object types that would need to be rendered under the partitions themselves instead of the parent though. > > > On Thu, Apr 27, 2017 at 1:44 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Wed, Apr 26, 2017 at

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
On Wed, Apr 26, 2017 at 6:36 PM, Shirley Wang <sw...@pivotal.io> wrote: > Hello! > > On Wed, Apr 26, 2017 at 4:26 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> [moving to the pgadmin-hackers mailing list as this a pgAdmin feature] >>

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-26 Thread Dave Page
On Wed, Apr 26, 2017 at 4:45 PM, Shirley Wang <sw...@pivotal.io> wrote: > > > I think the addition of icons and some copy would help: > [image: Screen Shot 2017-04-26 at 11.28.41 AM.png] > Agreed. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-26 Thread Dave Page
ioning. > > OK. > The above implementation may take more time, so it might possible that we > may not be able to finish it by 14th May (deadline). > It would be nice to have it by then, but the true deadline will be a later beta (TBD, but probably beta 2 which is sufficiently far off). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-26 Thread Dave Page
ink to the project. https://www.figma.com/file/ > UjGekp34w6iBizjlGu2D4ccp/4.21pgAdmin-styles-Page-1 > > Let me know what you think. > I'll have a play with it. Initial thoughts (after literally 5 minutes) are that it seems like it could be very useful. I particularly like the asset library. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Dave Page
; > > Visually we saw a difference between "Databases" statistics and a specific > database statistics. In "Databases" statistics the "Size" is "7.4 MB" but > when you are in the specific database the "Size" is "7420 kB

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-25 Thread Dave Page
tches. FYI, here are the docs for both: http://getbootstrap.com/components/#alerts http://alertifyjs.com/notifier.html -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Dave Page
ling list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

2017-04-25 Thread Dave Page
min-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-04-25 Thread Dave Page
er side cursors in the future when we have more ability to parse the query string before executing it (something we will want to do when we merge query tool/edit grid functionality). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Dave Page
to contact the author of the container then really. I don't know how that has been configured. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Dave Page
it possible to change it? > Can you provide more info on your config, for both pgAdmin and whatever webserver you're using? This doesn't happen for me on Apache. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-24 Thread Dave Page
Thanks - patch applied! On Mon, Apr 24, 2017 at 2:43 PM, Sarah McAlear <smcal...@pivotal.io> wrote: > Oh, good catch! Here's a new patch with all the lines in place. > > Thanks, > Joao & Sarah > > On Thu, Apr 20, 2017 at 12:05 PM, Dave Page <dp...@pgadmin.org>

[pgadmin-hackers] pgAdmin 4 commit: Only display the header row in SlickGrid where column

2017-04-24 Thread Dave Page
Only display the header row in SlickGrid where columns actually exist. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f718e1f49c95460b828c397ce36c1e2ea37a0031 Author: Joao Pedro De Almeida Pereira Modified

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility

2017-04-24 Thread Dave Page
3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214 (missed some f

2017-04-24 Thread Dave Page
Initial support for PG 10.0, per #2214 (missed some files) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a449be784e8fa6ee719aa97bcb8b5e514fc7150e Author: Akshay Joshi Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214

2017-04-24 Thread Dave Page
Initial support for PG 10.0, per #2214 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59834fba310722b0c45bdcb3bfc9eb0a8ac4d9aa Author: Akshay Joshi Modified Files --

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

2017-04-24 Thread Dave Page
just opened an issue in their > github <https://github.com/pypa/pip/issues/4453>. > > Thanks > Joao & Oliver > > On Fri, Apr 21, 2017 at 5:20 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi, >> >> Unfortunately I've had to revert this as the Jenkins CI bui

[pgadmin-hackers] pgAdmin 4 commit: Update test requirements for the latest rev of Chrome

2017-04-24 Thread Dave Page
Update test requirements for the latest rev of Chrome. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3eb92f7ea3abf3c6cb21d6f1dc391a300095026c Author: Joao Pedro De Almeida Pereira Modified Files --

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-04-24 Thread Dave Page
h > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-04-24 Thread Dave Page
t via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-24 Thread Dave Page
ote: > >> That is strange. >> >> I tested on PG9.6 and it was working properly, What is the your PG >> version? >> >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterpri

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

2017-04-24 Thread Dave Page
admin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Table column edit breaks when using column level permissions

2017-04-24 Thread Dave Page
2335 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgre

Re: [pgadmin-hackers] QT dependances of the web version?

2017-04-24 Thread Dave Page
yland, which > is around 250MB of packages which aren't needed or wanted on a server. > > If not, I'll look for a way to build pgadmin without having the QT modules. > The web package shouldn't have any dependencies on anything related to Qt/Xorg. iirc, it should only depend on Python s

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

2017-04-24 Thread Dave Page
n't writable by the apache user, either. > > There isn't an easy fix for this; on a default Fedora or CentOS system, > the only directory the apache user has read/write to is /tmp, as far as > I know. > > Ideas? This is covered in the docs: https://www.pgadmin.org/docs4/1.x/server_deploym

Re: [pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

2017-04-24 Thread Dave Page
iguration recommended in the pgadmin docs. Is > there a reason it doesn't need it? That's definitely required, otherwise you will end up with multiple DB connection managers and have no way for client sessions to maintain affinity with the right one. -- Dave Page Blog: http://pgsnake.blogspot

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

2017-04-21 Thread Dave Page
or: -c cmd --help error: option --chromedriver-version not recognized On Fri, Apr 21, 2017 at 9:54 AM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > > On Thu, Apr 20, 2017 at 11:03 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal

[pgadmin-hackers] pgAdmin 4 commit: Revert "Update Chromedriver version for Chrome 58."

2017-04-21 Thread Dave Page
Revert "Update Chromedriver version for Chrome 58." This reverts commit 70832286bcee0a02eb6acca67a58878954fda861. The Jenkins CI doesn't like this at all. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Revert "Ensure PIP is the latest version when running

2017-04-21 Thread Dave Page
Revert "Ensure PIP is the latest version when running the CI tests." This reverts commit bf1f4aefa686554fa24ac2fbcf1457aa9de4eccf. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f6ffaaff98f117e69c34c7bc30dd7f61b971c9ae Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Ensure PIP is the latest version when running the CI

2017-04-21 Thread Dave Page
Ensure PIP is the latest version when running the CI tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf1f4aefa686554fa24ac2fbcf1457aa9de4eccf Modified Files -- ci/run_python_tests.sh | 1 + 1 file changed, 1 insertion(+)

[pgadmin-hackers] pgAdmin 4 commit: Enable horizontal scrolling in the treeview. Fixes #2

2017-04-21 Thread Dave Page
Enable horizontal scrolling in the treeview. Fixes #2339 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=618d9bc7a96a91686c562c04b6885a437db05c4f Author: Khushboo Vashi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

2017-04-21 Thread Dave Page
> On Tue, Apr 18, 2017 at 7:25 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Unfortunately I had to revert this, as I found it was preventing >> treeview nodes from being collapsed again. I'm running in Google >> Chrome on Mac, if that helps narrow down the problem. >

[pgadmin-hackers] pgAdmin 4 commit: Update Chromedriver version for Chrome 58.

2017-04-21 Thread Dave Page
Update Chromedriver version for Chrome 58. Note: If you had previously installed the old driver you need to uninstall and install again it. $ pip uninstall chromedriver_installer $ pip install -r regression/requirements.txt Branch -- master Details ---

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

2017-04-21 Thread Dave Page
gt; > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

2017-04-21 Thread Dave Page
one. I suspect you will need to do 1-3 though. For a source/pip installation (would a pure Python installation be a better basis for a container?), the docs at https://www.pgadmin.org/docs4/1.x/server_deployment.html should cover everything (patches to improve are always welcome of course). -- D

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-20 Thread Dave Page
Hi On Thu, Apr 20, 2017 at 7:39 PM, Shirley Wang <sw...@pivotal.io> wrote: > Hi! > > On Thu, Apr 20, 2017 at 4:18 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang <sw...@pivotal.io> wrote: >

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-20 Thread Dave Page
the bottom border from the entire header row, which makes the transition from the header ro to the first data row look very odd (especially in the first row header, which essentially merges into the top-left "select all" cell). Screenshot attached. Can you get the line back in place, but so it

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-20 Thread Dave Page
s I can see, this doesn't work as expected. The "bad" column is interpreted as numeric[] on my machine, which I assume needs to be added to the list as well? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-20 Thread Dave Page
for 20 years now is the formatting/capitalisation of the "pgAdmin" name. You might want to stop using pg_Admin :-p -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

2017-04-19 Thread Dave Page
On Wed, Apr 19, 2017 at 11:44 AM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi, > > On Wed, 2017-04-19 at 09:31 +0100, Dave Page wrote: >> > 1.0.8, which comes from EPEL. >> >> Urgh. Way too old. In the CI system, we use 1.4.9 for Python 2.6 and >>

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

2017-04-19 Thread Dave Page
On Tue, Apr 18, 2017 at 6:40 PM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi Dave, > > On Tue, 2017-04-18 at 14:34 +0100, Dave Page wrote: >> What Sphinx version do you have? > > 1.0.8, which comes from EPEL. Urgh. Way too old. In the CI system, we use 1.4.9 fo

[pgadmin-hackers] pgAdmin 4 commit: Prevent the top-left logo from changing colour when c

2017-04-18 Thread Dave Page
Prevent the top-left logo from changing colour when clicked. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=929a43c9faf116c45b6c0e6121e4c0fec76bcdaa Author: Jonas Thelemann Modified Files --

Re: [pgadmin-hackers] CSS Focus Bug Fix

2017-04-18 Thread Dave Page
tings, > Jonas Thelemann > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enterpri

[pgadmin-hackers] pgAdmin 4 commit: Re-order Makefile targets for readability.

2017-04-18 Thread Dave Page
Re-order Makefile targets for readability. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=649b064cf3ffab020d62b8b0ea5c20719b3f9047 Author: Jonas Thelemann Modified Files -- Makefile | 56

Re: [pgadmin-hackers] Translation Docs Update & DE Fixes

2017-04-18 Thread Dave Page
nas > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http:

[pgadmin-hackers] pgAdmin 4 commit: German translation update.

2017-04-18 Thread Dave Page
German translation update. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e127cf4fa117c1b81554a3c236790272912b469 Author: Jonas Thelemann Modified Files -- .../translations/de/LC_MESSAGES/messages.mo

[pgadmin-hackers] pgAdmin 4 commit: Translation doc update:

2017-04-18 Thread Dave Page
Translation doc update: - ...anonymized the language codes (ISO 639-1, $LANG) - ...clarified the "Updating and Merging" description and removed the examples as they were pretty useless in my eyes. Correct me if they had a meaning. - ...anonymized the bash user - ...updated the "New Language"

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

2017-04-18 Thread Dave Page
Unfortunately I had to revert this, as I found it was preventing treeview nodes from being collapsed again. I'm running in Google Chrome on Mac, if that helps narrow down the problem. On Tue, Apr 18, 2017 at 2:01 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > >

[pgadmin-hackers] pgAdmin 4 commit: Revert "Ensure the treeview can be scrolled horizonta

2017-04-18 Thread Dave Page
Revert "Ensure the treeview can be scrolled horizontally. Fixes #2339" This reverts commit 78c25cef21dcffed695494caa93c3e16b3114b47 which apparently prevents tree nodes being collapsed. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2318: Fixed Foreign Table column order

2017-04-18 Thread Dave Page
tgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers m

[pgadmin-hackers] pgAdmin 4 commit: Order foreign table columns correctly. Fixes #2318

2017-04-18 Thread Dave Page
Order foreign table columns correctly. Fixes #2318 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d6add13c06bbd92a581a6044b2efc92cfa29df0 Author: Khushboo Vashi Modified Files --

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

2017-04-18 Thread Dave Page
On Tue, Apr 18, 2017 at 2:10 PM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi Dave, > > On Tue, 2017-04-18 at 09:12 +0100, Dave Page wrote: >> Yeah, we see that with Python 2.6. Don't worrk about it. > > Ok, but this is treated as an error, and the build stops the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

2017-04-18 Thread Dave Page
ke changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-

[pgadmin-hackers] pgAdmin 4 commit: Ensure the treeview can be scrolled horizontally. Fix

2017-04-18 Thread Dave Page
Ensure the treeview can be scrolled horizontally. Fixes #2339 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78c25cef21dcffed695494caa93c3e16b3114b47 Author: Khushboo Vashi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-04-18 Thread Dave Page
Thanks, patch applied. On Fri, Apr 14, 2017 at 4:20 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Sat, Apr 1, 2017 at 12:12 PM, Dave Page <dp...@pgadmin.org> wrote: &

[pgadmin-hackers] pgAdmin 4 commit: Ensure database driver names and description strings

2017-04-18 Thread Dave Page
Ensure database driver names and description strings can be translated. Fixes #2190 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a3007b7335d73cb2042cf4b2d3939b69ae4bcaac Author: Khushboo Vashi Modified

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-18 Thread Dave Page
We will change the styling of this patch as part of that work. > > Best, > George and Matt > > > > > > > On Mon, Apr 10, 2017 at 11:13 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Mon, Apr 10, 2017 at 4:01 PM, Matthew Klei

[pgadmin-hackers] pgAdmin 4 commit: Allow column or row selection in the query tool. Fixe

2017-04-18 Thread Dave Page
Allow column or row selection in the query tool. Fixes #2216 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d663d553c55fbb5cdbe172d5c8780b777815de00 Author: Matthew Kleiman Modified Files --

[pgadmin-hackers] pgAdmin website commit: Correct link to downloads, per Devrim.

2017-04-18 Thread Dave Page
Correct link to downloads, per Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=10f2959b2442f1896b458d916e9c58b268d673ce Modified Files -- download/index.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

2017-04-18 Thread Dave Page
gards, > -- > Devrim Gündüz > EnterpriseDB: http://www.enterprisedb.com > PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer > Twitter: @DevrimGunduz , @DevrimGunduzTR -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.en

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-18 Thread Dave Page
gt; less flat. Yes - the last point above for example; the info bar has been made gray so it a) flattens the look and b) stops it standing out. I would argue that absolutely needs to be a prominent colour; maybe not the blue it currently is, but certainly something that makes it clearly visible. Paste

[pgadmin-hackers] pgAdmin website commit: Bump available version

2017-04-13 Thread Dave Page
Bump available version Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=13e6624154124e9fd41a15b4e8796a77e6c05cf9 Modified Files -- versions.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via

[pgadmin-hackers] pgAdmin website commit: Correct pgAgent URL

2017-04-13 Thread Dave Page
Correct pgAgent URL Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=839a90070963221e4cf7ae5cfdd91de2ae5b06f5 Modified Files -- download/pgagent.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[pgadmin-hackers] pgAdmin website commit: Release 1.4. Restructure FTP site at the same t

2017-04-13 Thread Dave Page
Release 1.4. Restructure FTP site at the same time to get rid of legacy paths that make little sense now. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=92be1b882a4f2f55ef183fe5474d2eeb9b413613 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_4 has been created.

2017-04-13 Thread Dave Page
Tag REL-1_4 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_4 Log Message --- Tag 1.4 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] Thoughts on allowing PGAdmin4 config file override

2017-04-13 Thread Dave Page
stro.py (intended for packagers): https://www.pgadmin.org/docs4/1.x/server_deployment.html#configuration -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-12 Thread Dave Page
at least data output in from query results is >> > un-editable, I know right clicking on a table in the browser to "view >> ... >> > data/rows" outputs an editable table) >> >> When we first released pgAdmin 4 we forgot to right-justify numbers. >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Thanks, applied. On Wed, Apr 12, 2017 at 1:52 PM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find rebased patch. > > On Wed, Apr 12, 2017 at 5:44 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Can you rebase this please

[pgadmin-hackers] pgAdmin 4 commit: Remove some unused events.

2017-04-12 Thread Dave Page
Remove some unused events. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bbc05051cc852e558ebcdf5a83644b97f09a82a Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
ttp://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Apr 12, 2017 at 5:50 PM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>> Hi Dave, >>> >>> PFA rebased patch. >>> >>&g

[pgadmin-hackers] pgAdmin 4 commit: Update inode info when refreshing treeview nodes. Fix

2017-04-12 Thread Dave Page
Update inode info when refreshing treeview nodes. Fixes #2336 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=019c1302cb863094eb3494391580a77dd02ad4dd Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Align labels with switches properly.

2017-04-12 Thread Dave Page
Align labels with switches properly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbee76eac88cbeab47d245087be2abdb38ffcd08 Author: Akshay Joshi Modified Files -- web/pgadmin/static/css/pgadmin.css

Re: [pgadmin-hackers] [pgAdmin4][Patch] Align Switch control with the text

2017-04-12 Thread Dave Page
-- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
za Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Can you rebase this please? On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar &g

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:22 PM, Navnath Gadakh <navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the revised patch. > > On Mon, Apr 10, 2017 at 1:43 PM, Dave Page <dave.p...@enterprisedb.com> > wrote: >> >&g

[pgadmin-hackers] pgAdmin 4 commit: Include passed test results in the JSON output from t

2017-04-12 Thread Dave Page
Include passed test results in the JSON output from the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62716c4193c4434b002682126b634b29d70d1870 Author: Navnath Gadakh Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
stgreSQL Company > > On Mon, Apr 10, 2017 at 6:43 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Can you create an RM case for this please? >> >> Thanks. >> >> On Mon, Apr 10, 2017 at 2:11 PM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterpri

[pgadmin-hackers] pgAdmin 4 commit: Fix binary search algorithm so new treeview nodes are

2017-04-12 Thread Dave Page
Fix binary search algorithm so new treeview nodes are added in the correct position. Fixes #2331 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd9efd811c7845d9dc985b66f8d33497f2f4bfa Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-11 Thread Dave Page
refreshed data, so why clear it? > Also, on server disconnect, an unused event 'server-disconnected' is being > triggered. > instead it should trigger ''pgadmin:server:disconnect'event. Please submit that as a separate cleanup patch. Thanks. -- Dave Page Blog: http://pgsnake.blo

[pgadmin-hackers] Candidate builds for 1.4

2017-04-10 Thread Dave Page
$SUBJECT can be found here: https://developer.pgadmin.org/~dpage/ Please yelp ASAP if there are any serious packaging problems. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Adjust windows resources so they work consistently.

2017-04-10 Thread Dave Page
Adjust windows resources so they work consistently. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c435154aca919ee6ff37cd12fc4fb1c9e663be2 Modified Files -- runtime/pgAdmin4.pro | 11 --- 1 file changed, 4 insertions(+), 7

[pgadmin-hackers] pgAdmin 4 commit: Fix application icon in mingw builds.

2017-04-10 Thread Dave Page
Fix application icon in mingw builds. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=665ec460521e875bfd0a6782d616a79a293ab7b7 Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Bump version numbers for release.

2017-04-10 Thread Dave Page
Bump version numbers for release. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdf292964ba708bfc4fe0d2d80f7e72048e765f0 Modified Files -- runtime/Info.plist | 4 ++-- web/config.py | 4 ++-- 2 files changed, 4 insertions(+),

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-10 Thread Dave Page
ke changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
> end; <== Added ; and its working fine > > until not FindNext(FindRec); > > > > > > > On Mon, Apr 10, 2017 at 3:01 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Attached. >> >> On Mon, Apr 10, 2017 at 10:26 AM, Paresh More < >> par

[pgadmin-hackers] pgAdmin 4 commit: Ensure the web/ directory is cleared before upgrading

2017-04-10 Thread Dave Page
Ensure the web/ directory is cleared before upgrading Windows installations. Fixes #2187 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b86fa15dbce58df7be87035ae8cac6cd3f4ee98a Author: Paresh More Modified

[pgadmin-hackers] pgAdmin 4 commit: Recover properly if a database is renamed externally.

2017-04-10 Thread Dave Page
Recover properly if a database is renamed externally. Fixes #2077 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=024b97479dde8ce231532a5f79fb6600cbea0923 Author: RAJASEKAR G Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix a regression framework issue with Python 2.6.

2017-04-10 Thread Dave Page
Fix a regression framework issue with Python 2.6. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e81478e3fa4d73793179861fe3ffc0e4958569 Author: Navnath Gadakh Modified Files --

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-10 Thread Dave Page
y >> columns are copied. Although pressing this button won't do anything unless >> rows have been copied to the clipboard, this might prove confusing to users. >> I am going to look at disabling this button until rows are in the clipboard. >> I will let you know if I have anyt

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
Attached. On Mon, Apr 10, 2017 at 10:26 AM, Paresh More <paresh.m...@enterprisedb.com> wrote: > Hello Dave, > > Can you please send me C:\Users\dpage\Documents\pg > admin4\pkg\win32\installer.iss file > > On Mon, Apr 10, 2017 at 2:30 PM, Dave Page <dp...@pgadmin.org&g

<    1   2   3   4   5   6   7   8   9   10   >