Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

HI Dave, Please find the patch for the added feature test for handling of RM#1928 datatype issue, other misc changes are for PEP-8. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 7:21 PM, Dave Page <

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

Hi, PFA minor patch to fix the issue in Grant wizard, In IE browser grant wizard do not close if user tries to close it by clicking Cancel button or Close button. RM#2142 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

[pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

ise SQL Panel area. *** Do not click on SQL area *** 5) You will see truncated sql. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqledi

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

Hi, PFA patch to fix the issue in Table node where it was not displaying reversed engineered sql for Trigger(s) properly, if trigger function associated with that trigger has parameters. RM#2043 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi Shirley, The new UI looks awesome :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 6:58 PM, Shirley Wang <sw...@pivotal.io> wrote: > Hi Murtuza, > > This was before we had checkboxes removed a

[pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

Hi, PFA patch to fix the handling of double precision[] type. RM#1928 Steps to re-produce: Below given query fails to render result in Query tool, SELECT ARRAY[1, 'nan', 3]::float[]; -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

Hi, PFA minor patch to fix the issue in query tool result polling causing exception, *ValueError: too many values to unpack* RM#2470 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/driver/psycopg2/__init__

[pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

in browser. RM#1890 Other misc changes are for PEP-8. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py b/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Synonym node EPAS9.2

Hi, PFA patch to fix the issue in Synonym node for EPAS9.2+ where Packages are not displaying as a target objects. RM#1813 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in procedure debugging in EPAS

Hi, PFA patch to fix the issue where debugger module is not throwing proper error for unsupported argument mode type in procedure. RM#1466 @Neel, Can you please do quick review of this patch? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] [pgAdmin4][PATCH] To make $ quoting consistent

Hi, PFA patch to make to $ quoting consistent. in Function node RM#1525 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/9.2_plus

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the validation in Types node

Hi, PFA patch to fix the validation issues with Range & External type in Types node. RM#1795 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.p

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the spacing issue in SQL for Event trigger

Hi, PFA minor patch to fix the issue of extra spacing in generated SQL in Event trigger. RM#1229 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/event_triggers/__init__.py

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > > On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Please include Type nod

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi Khushboo, Please include Type node and Foreign Table node in your fix :-) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > &

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in index or exclusion contrarians node

Hi, PFA patch to fix the issue in index or exclusion contrarians node where it was throwing "can't execute an empty query" error due to incorrect validation logic for edit mode. RM#2113 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Co

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

Hi, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 9:13 PM, Dave Page <dp...@pgadmin.org> wrote: > On Mon, May 29, 2017 at 10:31 AM, Murtuza Zabuawala > <

[pgadmin-hackers] [pgAdmin4][Patch] To display proper SQL for Procedure node

Hi, PFA patch to fix to display procedure options like IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED in SQL (Reverse Engineered). RM#2280 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

[pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

Hi, PFA attach patch to add property into trigger node to display if trigger is enabled or disabled in Properties panel and also in dialog. RM#2386 Also used node-list-by-name control instead of muti-select control for listing table columns to simplify the logic. -- Regards, Murtuza Zabuawala

Re: [pgadmin-hackers] feature test timeouts

ary == PG_95: 5 tests passed 1 test failed: PGDataypeFeatureTest (Test checks for PG data-types output) 0 tests skipped == Please check output in file: /

[pgadmin-hackers] [pgAdmin4] [PATCH] Allow user to create ENUM type without any label

Hi, PFA patch to address below, 1) Allow user to create ENUM type without any labels. 2) Allow user to add new label to existing enum type which do not have any existing labels. RM#2426 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary key order when view data

testing, we were not passing database id in properties.sql which is required for Select and Insert script to work. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables

[pgadmin-hackers] [pgAdmin4] [PATCH] To fix error in SQL panel

Hi, PFA patch to fix the issue which due to python side validations, at many places it was assumed that we will always get a row from query result. RM#2427 *Note:* Almost all the database level nodes are affected by this patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

tree is coupled with their respective inner function calls and recursive in nature due to aciTree API implementation for making function calls in orderly manner. @Ashesh, Any thoughts on this? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in server group node

Hi, PFA minor patch to fix the in server group node, If you user creates/update server group name which is already present in tree then it fails and it does not provide clear informative error message regarding failure. Issue found during testing node rename issue :) RM#2414 -- Regards, Murtuza

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in server stats sql (PPAS9.2)

pg_stat_activity Fixes RM#1831 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/sql/9.2_plus/stats.sql b/web/pgadmin/browser/server_groups/servers/templates/servers/sql

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in function node

Hi, PFA patch to fix the issue in function node where it was displaying wrong query if function returns table. RM#1851 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

++ Attaching patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 16, 2017 at 12:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in FTS dictionar

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

Hi, PFA patch to fix the issue in FTS dictionary as below, 1) Strip the quotes from the options. 2) Template is not shown in properties views if it is not in a system schema. RM#1126 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

always get one row from database. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:57 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Dave, Yes, It is existing one only, We did not touch on any part of sorting algorithm in this patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:24 PM, Dave Page <dp...@pgadmin.org> wrote: &g

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Harshal, We are using https://github.com/javve/natural-sort for sorting nodes which is implemented by Ashesh. @Ashesh, Any suggestion on this? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:07 PM, Harshal

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

Hi, PFA minor patch to add object validation in table node for SQL and Properties tab . RM#2395 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Ashesh, Please find updated patch as discussed. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > As d

Re: [pgadmin-hackers] backports.csv

Hi Dave, I am not sure on this. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 12, 2017 at 5:32 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi Murtuza, > > Your recent addition of backports.csv

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

Hi, Please find updated patch with changes as per comments given by Joao. @Joao, Thank you for reviewing the patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 11, 2017 at 8:19 PM, Joao Pedro De Almeida Pereira

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Ashesh, As discussed please find updated patch removing hardcoded check for server & server-group node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala < murtuza

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issues with CSV file download

Hi Dave, Please find patch to handle non-ascii column names in CSV for Pyhton2. Thanks to Harshal for pointing out the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 8, 2017 at 6:06 PM, Dave Page <dp...@pgadmin.

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

Hi, PFA patch to fix the issue where user hides the any node from Preference dialog but the menu(both context/object) still appears in pgAdmin4. RM#2225 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node

Hi, Please find updated patch. Updated logic to convert name only if name is of type int/long/float (Python2) or of type int/float (Python3) instead of blindly convert it to string. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue

[pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

Hi, Please find patch to fix the issue handling BOM characters in user files when they load their sql files in query tool. RM#2369 FYI, I have attached sample BOM file in redmine for testing. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issues with CSV file download

Hi, Please find the patch to fix the issues in CSV file download feature, 1) To handle non-ascii filenames which we set from table name RM#2314 2) To handle non-ascii query data RM#2353 3) To dump JSON type columns properly in csv RM#2360 Please review. -- Regards, Murtuza Zabuawala

Re: [pgadmin-hackers] Fix for csv download issue [RM2253] [RM2214] [pgadmin4]

Please hold on on this patch, I am also working on same type of issue. I think my patch would cover RM#2253 & RM#2360 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 8, 2017 at 2:30 PM, Harshal Dhumal < hars

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

).toBe(0); > expect(column.toRow).toBe(9); > }) > }); > > > > Since we are finishing up this feature anyway, if this bug can wait > another week, we can take it into our backlog and address it and submit the > fix with our next patch. > > > Thanks! >

[pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/selection/column_selector.js b/web/pgadmin/static/js/selection/column_selector.js index c89b3fa..5260fc3 100644 --- a/web/pgadmin/static/js/selection

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Backup in other langauge

Hi, PFA patch to fix the issue in Backup module where it was not working if user changes its preference language other than english. RM#2354 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/backup/templates

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with NodeAjaxControl data caching

Hi, PFA patch to fix the issue in NodeAjaxControl caching with cache-node field and I've also added cache-node field in Trigger & Event trigger node so that whenever user creates new Trigger Function we get new data from server in NodeAjaxControl. RM#2242 Please review. -- Regards, Mur

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Ashesh, PFA updated patch for the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > On Mon, Apr 24, 2017 at 4:43 PM, D

Re: [pgadmin-hackers] Issue with SlickGrid

No, we didn't. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 4:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Thanks for the explanation. Based on w

Re: [pgadmin-hackers] Issue with SlickGrid

+++ Reference: https://www.postgresql.org/message-id/CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala

Re: [pgadmin-hackers] Issue with SlickGrid

ADME file. Apologies we missed to update this change in README. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hack

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

Hi, PFA patch to fix the issue where we were not correctly providing default parameters to respective argument(s). RM#2350 Affected node, 1) Functions 2) Trigger Function 3) Procedures (EPAS) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi, PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 <https://redmine.postgresql.org/projects/pgadmin4/repository/revisions/7dd9efd811c7845d9dc985b66f8d33497f2f4bfa> commit . RM#2355 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprise

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

anager module as well for the same issue. So affected modules are, - Query tool - File Manager Please review. RM#2347 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/templates/file_mana

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

regression with some large arbitrary numbers due to which it was converting it to numeric[] and numeric[] is already handled in our code. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 20, 2017 at 7:18 PM, Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

That is strange. I tested on PG9.6 and it was working properly, What is the your PG version? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 20, 2017 at 7:06 PM, Dave Page <dp...@pgadmin.org> wrote: > > >

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

> > Hi, > > PFA minor patch to fix the the issue with bigint[] array values as JS > truncates long numbers from array object. > RM#2272 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >

[pgadmin-hackers] [pgAdmin4][PATCH] Table column edit breaks when using column level permissions

Hi, PFA patch to fix the issue in table node where it breaks column edit when user provides column level permissions. RM#2335 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/static/js

Re: [pgadmin-hackers] [question]

is just to manage servers in groups in browser tree that the main purpose, is unique regardless of server-group id that's why you are getting proper response. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 7:21

Re: [pgadmin-hackers] [question]

multiple entries of a same server with different name in sqltite database. /browser//children/// /browser/database/children/1/1/12641 Here is OID of connected database. We follow this same URL object mapping almost everywhere in pgAdmin4. -- Regards, Murtuza Zabuawala EnterpriseDB: http

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Hi Dave, Apologies for previous patch, please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 5:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Please disregard previous patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 5:50 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA rebased patch. > &

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Hi Dave, PFA rebased patch. Thanks, Murtuza On Wed, Apr 12, 2017 at 5:45 PM, Dave Page <dp...@pgadmin.org> wrote: > Can you rebase this please? > > On Tue, Apr 11, 2017 at 2:04 PM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > >

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Hi, PFA minor patch to fix the issue where we were not updating inode information on refresh. RM#2336 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Sure, https://redmine.postgresql.org/issues/2331 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 10, 2017 at 6:43 PM, Dave Page <dp...@pgadmin.org> wrote: > Can you create an RM case for this please? > > Tha

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

Hi, PFA patch to fix the issue in browser tree where it was adding new nodes at wrong place due to wrong conditions in the logic. Thanks to Ashesh for helping me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 7, 2017 at 2:13 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > Murtuza - please fix it asap. > > -- > > Thanks & Regards, > &

Re: [pgadmin-hackers] i18n GER, suggestions, questions

On Thu, Apr 6, 2017 at 1:40 PM, Dave Page wrote: > On Thu, Apr 6, 2017 at 2:27 AM, Jonas Thelemann > wrote: > > Thanks for committing! :) > > > >>> i18n-trim.diff > >>> > >>> Removed two linebreaks to improve translation experience. > >> > >> Hmm,

[pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

is reproducible on any collection node which is not loaded) 4) You will see that only newly added node is displayed in browser tree -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b

[pgadmin-hackers] [pgAdmin4][PATCH] Error running restore/backup etc utilities in WSGI mode

on Apr 03 05:22:26.641958 2017] [wsgi:error] [pid 72351:tid 140303938864896] [remote ::1:28430] AttributeError: 'module' object has no attribute '__file__' In WSGI, we get sys.modules['__main__'] as built-in object. '__main__': , 'pgadmin.browser.server_groups.servers.databases.schemas.tables.rules': ,

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi, PFA minor add-on patch for README. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > Patch l

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Ashesh, Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > Hi Joao & Sarah, > > I have asked Murtuza

[pgadmin-hackers] [pgAdmin4][PATCH] To fix dialog help in browser tab/window

Hi, PFA patch to fix the issue where "Dialog Help" was broken in case where query tool/Debugger opens in new browser tab. RM#2310 *Note:* Object help might not work as well when used in new browser tab but for that we might need to find a way to pass node & server information in new browser tab

[pgadmin-hackers] [pgAdmin4][Patch] To fix the issues in SQL editor module & Functions node

SQL tab. RM#2246 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/fun

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of Import/Export in linux runtime

by user for Backup/Restore/Import/Export. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgAdmin4.py b/web/pgAdmin4.py index c738287..6025514 100644 --- a/web/pgAdmin4.py +++ b/web/pgAdmin4.py @@ -100,7 +100,9

[pgadmin-hackers] [pgAdmin4][PATCH] Minor condition code improvement

Hi, PFA minor patch for condition check improvement. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/datagrid/templates/datagrid/js/datagrid.js b/web/pgadmin/tools/datagrid/templates/datagrid/js/datagrid.js

[pgadmin-hackers] [PATCH][pgAdmin4] To fix the issue in server-group deletion

Hi, PFA patch to fix the issue in ServerGroup node, where servers associated to server group were not deleted when user deletes server-group. RM#2212 Also fixed the gif file url in file manager(changes included in the patch). -- Regards, Murtuza Zabuawala EnterpriseDB: http

[pgadmin-hackers] [PATCH][pgAdmin4] To show indeterminate state for [null] value for boolean

Hi, PFA minor patch to fix the issue where it was not showing indeterminate state for [null] value for boolean when we enter value in new row. RM#2153 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2153.patch Description: Binary

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Hi Dave, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 8:34 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Feb 27, 2017 at 10:25 AM, Mu

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

++ Forgot to add one more :-) Also fix button inconstancy issue with pgAdmin4 About dialog (changes included in RM_2036.patch file). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 3:55 PM, Murtuza Zabuawala

[pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

where we are unable to right click on browser tree if we set Debug = False in config_local.py file, this was because of typo as path for css was changed to '/js/' to '/vendor/'. (separate patch RM#2213) Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] pgAdmin4 mirror issues [pgAdmin4]

RM created, https://redmine.postgresql.org/issues/2200 https://redmine.postgresql.org/issues/2201 https://redmine.postgresql.org/issues/2202 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 23, 2017 at 4:12 PM, Dave Page <

[pgadmin-hackers] [pgAdmin4][PATCH] Columns with no size display incorrectly in the Query Tool

Hi, Please find minor patch to fix the issue where we were displaying incorrect size if columns has no size defined in the Query Tool. RM#2151 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2151.patch Description: Binary data

[pgadmin-hackers] [pgAdmin4][PATCH] Handling of non-ascii with Python2.7

non ascii words then it breaks in Python2.7. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index 86a02e6..b9750e8 100644 --- a/web/pgadmin/__init__.py +++ b/web/pgadmin

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

specifically if you are only targeting Syntax highlighting for Query Tool then, - web/pgadmin/tools/sqleditor/static/css/sqleditor.css to override any CSS related changes specific to pgAdmin4. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][patch] We can see tables in Greenplum!

Case is used for """ *Result:* runTest runTest (pgadmin.xxx) ... ok Unittest framework strip the doc string with "\n" and get the string at 0th index so in case of Comment Style-2 it will be empty, so no description will be displayed. So use *Comment Style-1* when you

[pgadmin-hackers] [pgAdmin4][PATCH] To handle "char" type in column node

:* import simplejson as json print(json.loads('"char"')) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/__init__.py b/web/pgadmin/browser/se

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi Dave, Please find a fix for the same, attribute length was set to False instead of None. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Sure, Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi Murtuza, > > I clearly neglected to run the regression tests with this patch, and

[pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

Hi, PFA patch to fix the issue with Graphical Explain plan functionality which was breaking for INSERT/UPDATE/DELETE explain plans. RM#2133 *Issue:* It was due to typo in imageMapper object. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] Regarding Import and Export Issue

It's a bug with windows system & already reported https://redmine.postgresql.org/issues/1679 It will be taken care in future release. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 2, 2017 at 12:02 PM, <vinay.m...@eapi

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi, Please find updates patch for the same. RM#2076 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Jan 31, 2017 at 5:19 AM, Mu

Re: [pgadmin-hackers] Issues with PgAdmin4

ws at your desired destination. Ref: https://www.pgadmin.org/docs4/1.x/query_tool.html -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Feb 3, 2017 at 3:24 AM, Tania <palta...@gmail.com> wrote: > Hi, > > I like the

Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

Thanks Dave. Tested and working fine. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 7:20 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala &g

[pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

Hi, PFA minor patch to display value '0' in Read only text editor. RM#2138 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/slickgrid/slick.pgadmin.editors.js b/web/pgadmin/static/js/slickgrid

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

Hi Dave, PFA updated patch, issue was conn.release(did=did) was removing all connection for same database from connection manager. We have now created new connection for offline updates using "conn_id" parameter instead of did. Please review. -- Regards, Murtuza Zabuawala Enterpri

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

Hi Dave, Please find minor patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote: > On Tue, Jan 31, 2017 at 10:36 AM, Murtuza Zabuawala > <

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

Hi Dave, Even I tested against Python3.5 but did not receive any such error and I tried again after your mail but still did not receive error. murtuza@vm:~/pgadmin4/web/regression$ python3 --version Python 3.5.0 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] Regarding Import and Export Issue

is the actual result on running the above steps i.e. the bug behavior. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 1:10 PM, <vinay.m...@eapindia.in> wrote: > Hello > > I have issue for the

[pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

quot;", line 658, in exec_module File "", line 764, in get_code File "", line 724, in source_to_code File "", line 222, in _call_with_frames_removed File "/../../pgadmin4/web/pgadmin/utils/tests/test_versioned_template_loader.py", line 50 exce

  1   2   3   4   5   >