Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Sandeep Thakkar
in PG server and EPAS Meta. On Wed, Oct 19, 2016 at 4:35 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Oct 19, 2016 at 1:57 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Patch applied. >> >> Fahar, can you please

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Sandeep Thakkar
do as you suggest and migrate existing values for >>> SECURITY_PASSWORD_SALT, given that there's clearly some other per user and >>> per installation/database salting going on anyway. New installations can >>> have the random value for SECURITY_PASSWORD_SALT. >>> >> We do not need to generate the random SECURITY_PASSWORD_SALT during >> upgrade mode, which was wrong added in my addon patch. >> >> Please find the updated patch. >> >> Otherwise - looks good to me. >> Please commit the new patch (if you're ok with the change). >> >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> I don't believe SECURITY_KEY and CSRF_SESSION_KEY are issues either, as >>> they're used for purposes that are essentially ephemeral, and thus can be >>> changed during an upgrade. >>> >>> Adding Magnus as I'd appreciate any thoughts he may have. >>> >>> Patch attached - please review (Ashesh, but others too would be >>> appreciated)! >>> >>> Thanks. >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sandeep Thakkar

Re: [pgadmin-hackers] Patches

2016-06-16 Thread Sandeep Thakkar
On Thu, Jun 16, 2016 at 7:04 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > > > > >> > I have attached the patch (pgadminpro.patch) to fix this. >

Re: [pgadmin-hackers] Patches

2016-06-16 Thread Sandeep Thakkar
On Thu, Jun 16, 2016 at 3:19 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Hi, > > > > I created virtual environment and tried building pgadmin on my Mac with &

[pgadmin-hackers] Patches

2016-06-16 Thread Sandeep Thakkar
refer the actual directory) and instead create a sym link. There might be other way to fix this, but I found this to be easy. :) Thanks! -- Sandeep Thakkar pgadmin-macbuild.patch Description: Binary data pgadminpro.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-07 Thread Sandeep Thakkar
el the requirement of it. > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com/> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi&

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-06 Thread Sandeep Thakkar
we > don't support back-branches long term anyway. > > Does anyone think we need to support side-by-side RPM/DEB installation of > multiple major versions of pgAdmin? Devrim? Hamid? > > The config file would be part of the web package. > > On Mon, Jun 6, 2016 at

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-06 Thread Sandeep Thakkar
tpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a > section on configuring that. > > > > On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Yeah, I got the point. To distinguish between v1 and v2, we can hav

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-06 Thread Sandeep Thakkar
th your suggested code - I just want to make > sure we need it. > > > On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Do you mean to say when a python app is launched, it imports some modules >> automatically and

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-03 Thread Sandeep Thakkar
e > system - doesn't it know where it's site-packages are already? I could see > us needing this is we were using a distro-independent build of Python and > wanted to find the OS site-packages location, but we're not. > > > On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar < > s

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-03 Thread Sandeep Thakkar
Hi Dave, how about changes in the pgadmin4 source code for conf.py and Server.cpp? Looks okay? On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Thanks Dave. > > On Fri, Jun 3, 2016 at 2:08 PM, Dave Page <dp...@pgadmin.org> wrote:

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-03 Thread Sandeep Thakkar
Thanks Dave. On Fri, Jun 3, 2016 at 2:08 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Hi Devrim, Hi Dave, > > > > I have updated the patch. The earl

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-02 Thread Sandeep Thakkar
-web-1.0_dev-1.rhel7.noarch* -- Thanks! On Thu, Jun 2, 2016 at 6:29 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi > > Few changes in the updated patch: > - added the missing modules in the specfile. The unavailable modules are > still commented. > - add

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-06-02 Thread Sandeep Thakkar
okay. Thanks again! On Thu, Jun 2, 2016 at 6:37 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Thanks Dave! > > > > I saw the runtime code and ob

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-06-02 Thread Sandeep Thakkar
t; the location of the venv in the appbundle). > > On Tue, May 31, 2016 at 6:37 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Hi Dave, > > > > > > On Tue, May 31, 2016 at 9:29 PM, Dave Page <dp...@pgadmin.org> wrote: > >> > &

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-02 Thread Sandeep Thakkar
Hi Few changes in the updated patch: - added the missing modules in the specfile. The unavailable modules are still commented. - added changelog in specfile - added dependency of pgadmin4-doc on pgadmin4-web On Wed, Jun 1, 2016 at 2:57 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-06-01 Thread Sandeep Thakkar
ndle? 2. Should web rpm require doc rpm? I guess so, otherwise online help won't work. Right? On Fri, May 27, 2016 at 6:35 PM, Dave Page <dp...@pgadmin.org> wrote: > [Adding Devrim] > > On Fri, May 27, 2016 at 1:55 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrot

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-31 Thread Sandeep Thakkar
/'//g"` ? > > yes, I have used the couple of more variables that gives proper understanding. Thanks! I have attached the updated patch. (runtime changes remains same). > > On Tue, May 31, 2016 at 1:19 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com&g

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-31 Thread Sandeep Thakkar
Somehow the patch skipped the Makefile changes. Attached is the updated patch. On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Thanks. I have fixed all the issues. > > Regarding the app not running from within the DMG for th

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-30 Thread Sandeep Thakkar
Page <dp...@pgadmin.org> wrote: > > > > > > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar > > <sandeep.thak...@enterprisedb.com> wrote: > >> > >> Sure. Thanks. > >> > >> There is a typo in pkg/mac/build.sh. i.e > >>

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-05-27 Thread Sandeep Thakkar
On Mon, May 9, 2016 at 6:35 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Initial eyeball review comments below... > > On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Hi Team, Dave, >> >>

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-23 Thread Sandeep Thakkar
gt; > and also the tree for $QTDIR/lib > > Attached. > > Also, my config database now seems to be trashed since I ran "make > appbundle" :-( > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: htt

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-19 Thread Sandeep Thakkar
gets > (No such file or directory) > complete-bundle.sh failed > make: *** [appbundle] Error 1 > > On Thu, May 19, 2016 at 6:34 AM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Hi Dave > > > > I have added the 'docs' target in the /Makefile. This targ

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-19 Thread Sandeep Thakkar
;dp...@pgadmin.org> wrote: > > > On Tuesday, May 17, 2016, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have fixed the issues. Attached is the updated patch. >> >> The docs are built as part of 'appbundle' targe

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-18 Thread Sandeep Thakkar
:20 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Okay, so the patch needs a little change because of the change in the > versioning for pgAdmin. Will update it. > > Paresh, please take a note of it. > > On Tue, May 17, 2016 at 4:24 PM, Sandeep

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-18 Thread Sandeep Thakkar
Okay, so the patch needs a little change because of the change in the versioning for pgAdmin. Will update it. Paresh, please take a note of it. On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I have fixed the i

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-17 Thread Sandeep Thakkar
On Tue, May 17, 2016 at 4:52 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Tuesday, May 17, 2016, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have fixed the issues. Attached is the updated patch. >>

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-17 Thread Sandeep Thakkar
i, May 13, 2016 at 6:41 PM, Dave Page <dp...@pgadmin.org> wrote: > On Fri, May 13, 2016 at 2:01 PM, Sandeep Thakkar > <sandeep.thak...@enterprisedb.com> wrote: > > Thanks Dave. > > > > Please see inline. > > > > On Fri, May 6, 2016 at 9:03 PM, Dave

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-13 Thread Sandeep Thakkar
idgets.framework/Versions/5/QtWebKitWidgets > to QtWebKitWidgets > error: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: > can't open file: > Contents/Frameworks/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets > (No such file or directory

[pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-04-22 Thread Sandeep Thakkar
not for the already absolute path (ex. ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web). Well, I'm not a developer and the patch is just an attempt to resolve the issue related to packaging. Please feel free to change it as required for better. Thanks. -- Sandeep Thakkar Le

[pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-04-18 Thread Sandeep Thakkar
--- pgadmin4-fixpath-mac.patch - This is for runtime/Server.cpp to fix the path where the runtime looks for web application path in app bundle. Kindly review and suggest the changes required. Thanks. -- Sandeep Thakkar pgadmin4-fixpath-mac.patch Description: Binary data pgadmin4-mac

Re: [pgadmin-hackers] Patch for builddocs.bat

2015-03-04 Thread Sandeep Thakkar
Sorry, the patch contained the unnecessary newline in the condition. This is fixed and the patch is attached. On Wed, Feb 25, 2015 at 6:44 PM, Dave Page dp...@pgadmin.org wrote: Thanks - patch applied. On Wed, Feb 25, 2015 at 6:09 AM, Sandeep Thakkar sandeep.thak...@enterprisedb.com wrote

[pgadmin-hackers] Patch for builddocs.bat

2015-02-24 Thread Sandeep Thakkar
Hi We dynamically build wxWidgets and hence the hhp2cached.exe is present in %WXWIN%\utils\hhp2cached\*vc_mswudll* instead of %WXWIN%\utils\hhp2cached\*vc_mswu* Attached is the patch for builddocs.bat that will work with both static and dynamic builds. -- Sandeep Thakkar Lead Software

[pgadmin-hackers] Fix for complete-bundle.sh

2014-11-20 Thread Sandeep Thakkar
i386 So, the grep fails there. Attached herewith is the patch that should work for Mach-O i386 executable and as well as Mach-O executable i386 outputs. -- Sandeep Thakkar pgadmin.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

Re: [pgadmin-hackers] pgAdmin 1.16.1 source code

2012-12-03 Thread Sandeep Thakkar
the PostgreSQL 9.2 installers tomorrow (don't update the older branches though). Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sandeep Thakkar Senior Software Engineer

Re: [pgadmin-hackers] pgAdmin 1.16.1 source code

2012-12-03 Thread Sandeep Thakkar
LC_ALL=en_US.UTF-8 export LANG=en_US.UTF-8 On Tue, Dec 4, 2012 at 9:07 AM, Sandeep Thakkar sandeep.thak...@enterprisedb.com wrote: Sure. I'll update the pgAdmin for PostgreSQL 9.2. Thanks. On Mon, Dec 3, 2012 at 10:43 PM, Dave Page dp...@pgadmin.org wrote: I've uploaded the pgAdmin