Re: [pgadmin-hackers][patch] Move to Alembic migration system

Awesome, thank you for adding that back in! On Sun, Apr 23, 2017 at 11:17 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> >> We review the patch, just noticed

Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We review the patch, just noticed a spelling issue so we regenerated the > patch. > Thanks. Your patch was missing README changes. :-) Committed after adding the necessary ch

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Hackers, We review the patch, just noticed a spelling issue so we regenerated the patch. Thanks Joao & Oliver On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi wrote: > Hi Joao & Oliver, > > On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrot

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Joao & Oliver, On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > @Ashesh thanks for the feedback > > Here is the reviewed patch with the suggestions of Ashesh. > > Disclaimer: We added a new patch file with the changes >

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Hackers, @Ashesh thanks for the feedback Here is the reviewed patch with the suggestions of Ashesh. Disclaimer: We added a new patch file with the changes Thanks Joao & Oliver On Thu, Apr 20, 2017 at 10:56 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Apr 20, 2017

Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Ashesh, > > Did you had time to review this patch? > Yes - I did. Please my review comments: Everytime I start pgAdmin 4, I am getting now the following message: "pgAdmin 4 - Application

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Ashesh, Did you had time to review this patch? Thanks Joao & Oliver On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear wrote: > Great, thank you so much! > > On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, Apr 12, 2017 at 7:07 PM, Sarah

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Great, thank you so much! On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi wrote: > > On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear > wrote: > >> Hi Hackers! >> > Hi Sarah, > >> >> Is there an update on this? >> > We will look in to it end of this week. > I was not rushing to it, because - Dave w

Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear wrote: > Hi Hackers! > Hi Sarah, > > Is there an update on this? > We will look in to it end of this week. I was not rushing to it, because - Dave was preparing for the 1.4 release. -- Thanks, Ashesh > > Thanks, > Sarah & Joao > > On Fri, Apr 7, 2

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Hackers! Is there an update on this? Thanks, Sarah & Joao On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear wrote: > Hi Ashesh! > > Good catch. Looks like there was an override of the input function that > didn't get moved to the new file, causing the input with the @ to fail. We > also added

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Ashesh! Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work. Thanks! Joao & Sarah On Mon, Apr 3, 2017 at 8:41 AM,

Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi wrote: > Hi Jaoao, Sarah, > > I've tried to run on fresh machine, it failed with the below error: > And - I have noticed - the headers are missing in new files. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Jaoao, Sarah, I've tried to run on fresh machine, it failed with the below error: *$ python setup.py* *NOTE: Configuring authentication for SERVER mode.* *Enter the email address and password to use for the initial pgAdmin user account:* *Email address: ashesh.va...@enterprisedb.com * *Trace

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi, We've updated Murtuza's README change to be more consistent with other instructions - adding a colon and newline. -Matt and George On Fri, Mar 31, 2017 at 10:47 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor add-on patch for README. > > -- > Regards,

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi, PFA minor add-on patch for README. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > Patch looks good to me. > > -- > Rega

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Ashesh, Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi wrote: > Hi Joao & Sarah, > > I have asked Murtuza to review the patch today. > He will update me by EOD. >

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Joao & Sarah, I have asked Murtuza to review the patch today. He will update me by EOD. If all goes well, I will commit the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Dave and Ashesh, Do you still need us to provide more information about this patch or is it ready to be merged? Thanks Joao On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We found out a issue using Python 3 relat

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Hackers, We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached. Also we would like to know the status of this. Thanks Joao & Sarah On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear wrote: > Hi! > > We realized that this change

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi! We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers. Thanks! Joao & Sarah On Thu, Mar 16, 2017 at 9:31 AM, Dave Page wrote: > Ashesh, can you review/commit t

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Ashesh, can you review/commit this please? One thing I notice on a quick look through is that the file headers are missing everywhere. They should be present in all source files, except where they would bloat the data transfer from client to server. On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Hackers! It looks like our previous patch messed up some logging. Please use this one instead. Thanks, Joao & Sarah On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear wrote: > Hi Hackers! > > Here's a patch to move to current db migration system to use Alembic. > Instructions to create new mi

[pgadmin-hackers][patch] Move to Alembic migration system

Hi Hackers! Here's a patch to move to current db migration system to use Alembic. Instructions to create new migrations are in the README. Thanks! Joao & Sarah 0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pg