Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-03-01 Thread Dave Page
Thanks! On Wed, Mar 1, 2017 at 11:36 AM, Akshay Joshi wrote: > Thanks patch applied. > > Fixed one issue where "Data Output" panel was not cleared in case of > error. > > On Tue, Feb 28, 2017 at 7:08 PM, Dave Page wrote: > >> [Adding Akshay]

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-03-01 Thread Akshay Joshi
Thanks patch applied. Fixed one issue where "Data Output" panel was not cleared in case of error. On Tue, Feb 28, 2017 at 7:08 PM, Dave Page wrote: > [Adding Akshay] > > On Tue, Feb 28, 2017 at 1:37 PM, Dave Page wrote: > > Thanks Murtuza. > > > >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-28 Thread Dave Page
[Adding Akshay] On Tue, Feb 28, 2017 at 1:37 PM, Dave Page wrote: > Thanks Murtuza. > > Akshay, can you please review/commit this by EOD tomorrow please, > making any required changes as needed? My queue is just too long at > the moment - and we need it in as soon as possible

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-28 Thread Dave Page
Thanks Murtuza. Akshay, can you please review/commit this by EOD tomorrow please, making any required changes as needed? My queue is just too long at the moment - and we need it in as soon as possible to maximise testing time. Thanks. On Tue, Feb 28, 2017 at 10:33 AM, Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-28 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 8:34 PM, Dave Page wrote: > Hi > > On Mon, Feb 27, 2017 at 10:25 AM, Murtuza Zabuawala >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-27 Thread Dave Page
Hi On Mon, Feb 27, 2017 at 10:25 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to reduce the size of query result set by converting it into 2D > array result set. > RM#2036 > RM#2038 > > Additionally, > 1) I had to change some logic in Debugger module to

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-27 Thread Murtuza Zabuawala
++ Forgot to add one more :-) Also fix button inconstancy issue with pgAdmin4 About dialog (changes included in RM_2036.patch file). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 3:55 PM, Murtuza Zabuawala <

[pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

2017-02-27 Thread Murtuza Zabuawala
Hi, PFA patch to reduce the size of query result set by converting it into 2D array result set. RM#2036 RM#2038 Additionally, 1) I had to change some logic in Debugger module to handle 2D array result set from async query (changes included in patch). 2) While testing I also found one issue