Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-20 Thread Guillaume Lelarge
Dave Page a écrit : > On Wed, Nov 19, 2008 at 11:21 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >> Can you take a quick look at this new patch? Thanks. I'll commit it if >> you find it good enough. > > Thanks - that looked good, so I've committed it (as I only too a > couple of clicks :-

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-20 Thread Dave Page
On Wed, Nov 19, 2008 at 11:21 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > Can you take a quick look at this new patch? Thanks. I'll commit it if > you find it good enough. Thanks - that looked good, so I've committed it (as I only too a couple of clicks :-p ). I did increase the default

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-19 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Nov 6, 2008 at 11:15 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Still a hack but it works. It even works with GTK. The patch attached >> removes the WXMAC ifdef. >> I also found on Windows that the check boxes for different privileges on the privil

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-14 Thread Dave Page
On Thu, Nov 6, 2008 at 11:15 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > Still a hack but it works. It even works with GTK. The patch attached > removes the WXMAC ifdef. > >>> I also found on Windows that the check boxes for different privileges >>> on the privilege panes are touching each

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-14 Thread Dave Page
On Fri, Nov 14, 2008 at 6:01 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Guillaume Lelarge a écrit : >> Dave Page a écrit : >>> [...] >>> On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <[EMAIL PROTECTED]> wrote: On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wr

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-14 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : > Dave Page a écrit : >> [...] >> On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <[EMAIL PROTECTED]> wrote: >>> On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge >>> <[EMAIL PROTECTED]> wrote: Thanks. I still don't like this hack. I hope I'll soon better understand >>

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-06 Thread Guillaume Lelarge
Dave Page a écrit : > [...] > On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <[EMAIL PROTECTED]> wrote: >> On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge >> <[EMAIL PROTECTED]> wrote: >>> Thanks. I still don't like this hack. I hope I'll soon better understand >>> this issue to replace the ugly co

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-05 Thread Dave Page
On Wed, Nov 5, 2008 at 5:39 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > Well, actually, I want to finish this book : "The Art of SQL", Stéphane > Faroult with Peter Robson, O'Reilly. Quite interesting, even if I > already know most of it. Do you know some books about database > internals?

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-05 Thread Guillaume Lelarge
Dave Page a écrit : > On Wed, Nov 5, 2008 at 5:11 PM, Guillaume Lelarge > [...] >> Till PostgreSQL 8.4 beta, I'll only work on pgAdmin. First on your bug >> report, then on the server status window and last on i18n. > > Sounds ambitious :-). > Yeah, but I didn't say I will do all of this :) At l

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-05 Thread Dave Page
On Wed, Nov 5, 2008 at 5:11 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> Hi Guillaume, >> >> Did you see the message below? Don't worry if you did - I just want to >> ensure it didn't get lost! >> > > Sorry for not answering sooner. I've seen it, I've printed it so that

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-05 Thread Guillaume Lelarge
Dave Page a écrit : > Hi Guillaume, > > Did you see the message below? Don't worry if you did - I just want to > ensure it didn't get lost! > Sorry for not answering sooner. I've seen it, I've printed it so that I cannot forget it, I just didn't find time (and courage) to work on it. Till Postg

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-11-05 Thread Dave Page
Hi Guillaume, Did you see the message below? Don't worry if you did - I just want to ensure it didn't get lost! On Mon, Oct 27, 2008 at 8:23 AM, Dave Page <[EMAIL PROTECTED]> wrote: > On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Thanks. I still don't like th

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-27 Thread Dave Page
On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Thanks. I still don't like this hack. I hope I'll soon better understand > this issue to replace the ugly code with a good one. You're going to hate this - but I just tested Gevik's work on Windows, and seem to be see

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-19 Thread Guillaume Lelarge
Dave Page a écrit : > [...] > Nice work!! So, let's please get this applied so we can put it to bed. > A couple of minor fixes: > > - In dlgFunction::Go @367, you have: > > returncode = dlgSecurityProperty::Go(modal); > > returncode = dlgSecurityProperty::Go(modal); > > Copy/paste error

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-18 Thread Dave Page
On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Here is a new (complete) patch. I don't like at all what I did but it > seems to fix your issues. OK, here we go dlgTable: Existing table: OK New table: OK dlgSequence: Existing sequence: OK New sequence: OK

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-17 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Sorry for giving you so many testing work... :-/ > > No problem. > >> Here is a new (complete) patch. I don't like at all what I did but it >> seems to fix your issues. > > Well I haven't bee

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-17 Thread Dave Page
On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > Sorry for giving you so many testing work... :-/ No problem. > Here is a new (complete) patch. I don't like at all what I did but it > seems to fix your issues. Well I haven't been able to test it yet (I'm currentl

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-16 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Oct 9, 2008 at 5:30 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: > >> OK, problem was in the CreateColumns function, file >> pgadmin/ctl/ctlListView.cpp. Complete patch attached. > > Okey-doke. So the latest testing shows: > > dlgTable: > [...] > dlgView: > >

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-10 Thread Dave Page
On Thu, Oct 9, 2008 at 5:30 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > OK, problem was in the CreateColumns function, file > pgadmin/ctl/ctlListView.cpp. Complete patch attached. Okey-doke. So the latest testing shows: dlgTable: Existing table: Privileges listview may missing until resi

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-09 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : > Dave Page a écrit : >> On Tue, Oct 7, 2008 at 1:26 PM, Guillaume Lelarge >> <[EMAIL PROTECTED]> wrote: >>> It seems I finally get something working. But not yet for dlgFunction. >>> Can you take a look at it? I just want to know if I haven't break other >>> things. If

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-08 Thread Guillaume Lelarge
Dave Page a écrit : > On Tue, Oct 7, 2008 at 1:26 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> It seems I finally get something working. But not yet for dlgFunction. >> Can you take a look at it? I just want to know if I haven't break other >> things. If it works, I will commit this patch

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-08 Thread Dave Page
On Tue, Oct 7, 2008 at 1:26 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > It seems I finally get something working. But not yet for dlgFunction. > Can you take a look at it? I just want to know if I haven't break other > things. If it works, I will commit this patch and work on the > dlgFuncti

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-08 Thread Guillaume Lelarge
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> Message-ID: <[EMAIL PROTECTED]> X-Sender: [EMAIL PROTECTED] Received: from frpar-46plp-vipfw.publicis.fr [81.200.176.13] with HTTP/1.1 (POST); Wed, 08 Oct 2008 15:29:01 +0200 User-Agent: RoundCube Webmail/0.1-rc

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-08 Thread Dave Page
On Tue, Oct 7, 2008 at 1:26 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > It seems I finally get something working. But not yet for dlgFunction. > Can you take a look at it? I just want to know if I haven't break other > things. If it works, I will commit this patch and work on the > dlgFuncti

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-07 Thread Guillaume Lelarge
Dave Page a écrit : > On Thu, Oct 2, 2008 at 12:05 AM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Dave Page a écrit : >>> [...] >>> I found a couple of small bugs in the new layout code for dlgFunction: >>> >>> - The Privileges (and SQL) panes don't size themselves properly when >>> viewing

Re: [pgadmin-hackers] Buglets in dlgFunction

2008-10-01 Thread Guillaume Lelarge
Dave Page a écrit : > [...] > I found a couple of small bugs in the new layout code for dlgFunction: > > - The Privileges (and SQL) panes don't size themselves properly when > viewing an existing function, until the dialogue is manually resized > - The privilege checkboxes are touching the role co