Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Dave Page
On Tue, Mar 28, 2017 at 2:04 PM, Sarah McAlear wrote: > There should be 2 additional lines in the babel.cfg file. We can see them > when we download the patch from the email. The additional lines are > > +[javascript: **/templates/about/**.js] > +[javascript: **/templates/dashboard/**.js] > > Than

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
There should be 2 additional lines in the babel.cfg file. We can see them when we download the patch from the email. The additional lines are +[javascript: **/templates/about/**.js] +[javascript: **/templates/dashboard/**.js] Thanks! On Tue, Mar 28, 2017 at 1:56 PM, Dave Page wrote: > Hi > >

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Dave Page
Hi Was that the correct patch? I don't see the changes you describe. On Tue, Mar 28, 2017 at 12:29 PM, Sarah McAlear wrote: > Good catch. We looked into this and it appears that the language > interpretation that is defined in the babel.cfg only picks up one definition > per file. Since we are i

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
Good catch. We looked into this and it appears that the language interpretation that is defined in the babel.cfg only picks up one definition per file. Since we are in the process of moving things over to the new gettext() functionality, it looks like we will have to be more specific in the config

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Dave Page
Hi On Mon, Mar 27, 2017 at 2:06 PM, Sarah McAlear wrote: > Hi Hackers, > Sorry about that, we attached the wrong patch file. Attaching the correct > one It no longer errors, but it's still not working correctly - after running an extract, there are no strings from about.js or dashboard.js in the

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Sarah McAlear
Hi Hackers, Sorry about that, we attached the wrong patch file. Attaching the correct one Thanks Joao & Sarah On Mon, Mar 27, 2017 at 1:58 PM, Dave Page wrote: > Hi > > On Mon, Mar 27, 2017 at 11:33 AM, Sarah McAlear > wrote: > > Hi Hackers! > > > > We updated the documentation and included th

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Dave Page
Hi On Mon, Mar 27, 2017 at 11:33 AM, Sarah McAlear wrote: > Hi Hackers! > > We updated the documentation and included the ability to generate the > messages.pot files again. We changed the file and function from translate.js > to gettext.js to be consistent with Python and also to have it automat

Re: [pgadmin-hackers] Javascript translations

2017-03-27 Thread Sarah McAlear
Hi Hackers! We updated the documentation and included the ability to generate the messages.pot files again. We changed the file and function from translate.js to gettext.js to be consistent with Python and also to have it automatically picked up without having to add extensions to Pybabel. See pat

Re: [pgadmin-hackers] Javascript translations

2017-03-26 Thread Dave Page
Hi On Thu, Mar 23, 2017 at 1:58 PM, Atira Odhner wrote: > Thanks Dave. > >> 1) String extraction no longer picks up strings in JS files. I guess >> we may need a custom extractor for babel? > > > Yeah, that's a good point. I didn't think about that. I'll put that in my > team's backlog coming up.

Re: [pgadmin-hackers] Javascript translations

2017-03-24 Thread Dave Page
Thanks, applied - though I changed it to "sources/translate" and "t" as the function name as that's what's been used so far. On Thu, Mar 23, 2017 at 5:58 PM, Atira Odhner wrote: > Thanks Dave. > >> 1) String extraction no longer picks up strings in JS files. I guess >> we may need a custom extrac

Re: [pgadmin-hackers] Javascript translations

2017-03-23 Thread Atira Odhner
Thanks Dave. 1) String extraction no longer picks up strings in JS files. I guess > we may need a custom extractor for babel? Yeah, that's a good point. I didn't think about that. I'll put that in my team's backlog coming up. Here's a patch for the docs. On Thu, Mar 23, 2017 at 8:37 AM, Dave

[pgadmin-hackers] Javascript translations

2017-03-23 Thread Dave Page
Hi Tira, I've been spending spare minutes starting to move the JS translations to use your new mechanism with an aim to minimising the Jinja rendering. Unfortunately, I found a couple of issues; can you look into them please? 1) String extraction no longer picks up strings in JS files. I guess we