Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-11-01 Thread Vinicius Santos
Hello, I implemented a function for the two buttons Asc and Desc, so that the maintenance is easier. Take a look and tell me what you think. Thanks. 0003-Implementation-Nulls-First-option-on-dlgEditGridOpti.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-11-01 Thread Guillaume Lelarge
On Tue, 2011-11-01 at 08:47 -0200, Vinicius Santos wrote: Hello, I implemented a function for the two buttons Asc and Desc, so that the maintenance is easier. Take a look and tell me what you think. Well, I don't like the UI. It takes too much space for only one information. I would

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-11-01 Thread Vinicius Santos
Well, I don't like the UI. It takes too much space for only one information. I would better like a combobox, with the two choices. I thought so too. I agree with you. Moreover, it simply doesn't work on Linux. I've got an assertion failure on OnPaint for the list. I actually don't

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-11-01 Thread Guillaume Lelarge
On Tue, 2011-11-01 at 12:07 -0200, Vinicius Santos wrote: Well, I don't like the UI. It takes too much space for only one information. I would better like a combobox, with the two choices. I thought so too. I agree with you. OK. Moreover, it simply doesn't work on Linux. I've got

[pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Vinicius Santos
Hello, I implemented an option Nulls First in the ordering screen. It's just a checkbox for versions = 8.3 of PostgreSQL. What do you think?

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Guillaume Lelarge
On Thu, 2011-10-27 at 08:43 -0200, Vinicius Santos wrote: Hello, I implemented an option Nulls First in the ordering screen. It's just a checkbox for versions = 8.3 of PostgreSQL. What do you think? Which ordering screen? -- Guillaume http://blog.guillaume.lelarge.info

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Guillaume Lelarge
On Thu, 2011-10-27 at 17:21 -0200, Vinicius Santos wrote: Which ordering screen? dlgEditGridOptions. Beside the button wxID_REMOVE. Nope, would be better if it was a radiobox below the column name. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Guillaume Lelarge
Don't forget the list! On Thu, 2011-10-27 at 17:31 -0200, Vinicius Santos wrote: Nope, would be better if it was a radiobox below the column name. Humm. I did not think at radiobox, because this feature is only available from 8.3. And? I don't get your point here. The version it first

Fwd: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Vinicius Santos
I did not realize again ... Nope, would be better if it was a radiobox below the column name. Humm. I did not think at radiobox, because this feature is only available from 8.3.

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Vinicius Santos
And? I don't get your point here. The version it first appeared doesn't affect the UI. Ok. But for versions 8.3, I disable the radiobox, right? Since the query: SELECT column FROM table ORDER BY column NULLS FIRST would not work on these versions.

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Guillaume Lelarge
On Thu, 2011-10-27 at 18:47 -0200, Vinicius Santos wrote: Yes. Our UI guideline is to disable (and not hide) widgets when the option is not available (whatever the reason). Ok. Do you agree with implementation ? I agree with the idea. I'll agree with the implementation once I'll read

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Guillaume Lelarge
On Thu, 2011-10-27 at 17:39 -0200, Vinicius Santos wrote: And? I don't get your point here. The version it first appeared doesn't affect the UI. Ok. But for versions 8.3, I disable the radiobox, right? Yes. Our UI guideline is to disable (and not hide) widgets when the option is not

Re: [pgadmin-hackers] Option Nulls First in the ordering screen.

2011-10-27 Thread Vinicius Santos
Yes. Our UI guideline is to disable (and not hide) widgets when the option is not available (whatever the reason). Ok. Do you agree with implementation ? Can I submit the patch tomorrow?