Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-15 Thread Dave Page
Thanks, applied. On Wed, Jun 15, 2016 at 8:06 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add stats on Sequences/Function/Trigger functions collection > nodes. > Please review. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-15 Thread Murtuza Zabuawala
Hi, PFA patch to add stats on Sequences/Function/Trigger functions collection nodes. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 1:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-14 Thread Murtuza Zabuawala
Hi Dave, I copied pgAdmin3 behaviour, I’ll implement it in pgAdmin4 :) Thanks, Murtuza > On 13-Jun-2016, at 5:51 pm, Dave Page wrote: > > On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala > wrote: >> The strange effects that leads to. >> >> >>> On 13-Jun-2016, at 4:55 pm, Dave Page wrote

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-13 Thread Dave Page
On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala wrote: > The strange effects that leads to. > > >> On 13-Jun-2016, at 4:55 pm, Dave Page wrote: >> >> Hi >> >> On Mon, Jun 13, 2016 at 12:18 PM, Murtuza Zabuawala >> wrote: >>> Hi Dave, >>> >>> I tried with fresh install of 9.4 version but stil

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
The strange effects that leads to. > On 13-Jun-2016, at 4:55 pm, Dave Page wrote: > > Hi > > On Mon, Jun 13, 2016 at 12:18 PM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> I tried with fresh install of 9.4 version but still not able to re-produce >> the issue, I also tried switching python

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-13 Thread Dave Page
Hi On Mon, Jun 13, 2016 at 12:18 PM, Murtuza Zabuawala wrote: > Hi Dave, > > I tried with fresh install of 9.4 version but still not able to re-produce > the issue, I also tried switching python version 2.7/3.5 but still no luck. > I also checked with Neel & Surinder on their system but still no

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
Hi Dave, I tried with fresh install of 9.4 version but still not able to re-produce the issue, I also tried switching python version 2.7/3.5 but still no luck. I also checked with Neel & Surinder on their system but still not able to re-produce the issue. Regards, Murtuza > On 10-Jun-2016, a

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-10 Thread Dave Page
On Thu, Jun 9, 2016 at 9:21 AM, Murtuza Zabuawala wrote: > Hi Ashesh/Dave, > > I tried setting 'track_functions' to false in postgresql.conf. but then I am > not able to start server got error saying false is not correct argument > (Version: PG 9.5). > Then I also set it to all and try running fun

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-08 Thread Dave Page
On Wed, Jun 8, 2016 at 6:54 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Can you please share steps to re-produce RM#1316, I’m not able to re-produce > it on my side. Please see Ashesh's response. > Meanwhile, PFA patch for RM#1315 :-) Thanks, pushed. -- Dave Page Blog: http://pgsnake.blogspot

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Ashesh Vashi
On Wed, Jun 8, 2016 at 11:24 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Can you please share steps to re-produce RM#1316, I’m not able to > re-produce it on my side. > Please set 'track_functions' to false in postgresql.conf. And, then open pgAdmin 4, browse

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Murtuza Zabuawala
Hi Dave, Can you please share steps to re-produce RM#1316, I’m not able to re-produce it on my side. Meanwhile, PFA patch for RM#1315 :-) Regards, Murtuza On 07-Jun-2016, at 5:52 pm, Dave Page wrote: Thanks. I've pushed this with changes to reformat some of the SQL, and ensure the column hea

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Dave Page
Thanks. I've pushed this with changes to reformat some of the SQL, and ensure the column headers are properly cased. There is one outstanding bug though - if an object is selected for which the stats query doesn't return any rows (e.g. track_functions = false), then weird things happen - you get a

[pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Murtuza Zabuawala
Hi, PFA patch to add Statistics functionality to below nodes, - Table - Function - Procedure - Trigger Function - Sequence - Index - Column - Primary Key - Unique constraint - Exclusion constraint (RM#1299) --- Additionally, attaching two separate patc