Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

2016-07-22 Thread Harshal Dhumal
Hi, PFA rebased patch for RM1293 and RM1294. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find updated patch:

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

2016-06-06 Thread Surinder Kumar
Hi, Please find updated patch: *Issue*: Code changes are not consistent with the present code in functions/__init__.py, like don't rename variable func_def to func_defintion until it is required. Review comment given by Ashesh personally. Please review. On Fri, Jun 3, 2016 at 3:31 PM, Surinder

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

2016-06-03 Thread Surinder Kumar
Hi, Please find attached patch for: 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node 2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions Explanation: Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

2016-06-02 Thread Surinder Kumar
Please ignore this patch. I will send another patch. On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for RM#1293. > Add support to display GRANT privilege query in SQL Pane. > > Please review. > > Thanks, > Surinder