Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-08 Thread Guillaume Lelarge
Le mardi 8 décembre 2009 à 20:27:57, Magnus Hagander a écrit : > 2009/12/7 Dave Page : > > On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge > > > > wrote: > >> Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : > >>> On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge > >>> > >>> wrote: >

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-08 Thread Guillaume Lelarge
Le mardi 8 décembre 2009 à 20:27:13, Magnus Hagander a écrit : > 2009/12/7 Guillaume Lelarge : > > Le lundi 7 décembre 2009 à 10:41:09, Dave Page a écrit : > >> On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge > >> > >> wrote: > >> > Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : > >

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-08 Thread Magnus Hagander
2009/12/7 Dave Page : > On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge > wrote: >> Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : >>> On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge >>> >>> wrote: >>> > We should probably drop this patch. I'll keep it in its git branch, >>> > be

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-08 Thread Magnus Hagander
2009/12/7 Guillaume Lelarge : > Le lundi 7 décembre 2009 à 10:41:09, Dave Page a écrit : >> On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge >> >> wrote: >> > Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : >> >> On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge >> >> >> >> wrote: >>

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-07 Thread Guillaume Lelarge
Le lundi 7 décembre 2009 à 10:41:09, Dave Page a écrit : > On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge > > wrote: > > Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : > >> On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge > >> > >> wrote: > >> > We should probably drop this patc

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-07 Thread Dave Page
On Sat, Dec 5, 2009 at 9:02 PM, Guillaume Lelarge wrote: > Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : >> On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge >> >> wrote: >> > We should probably drop this patch. I'll keep it in its git branch, >> > because I love the git branches an

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-05 Thread Guillaume Lelarge
Le vendredi 4 décembre 2009 à 18:44:29, Dave Page a écrit : > On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge > > wrote: > > We should probably drop this patch. I'll keep it in its git branch, > > because I love the git branches and I hate losing something I wrote. > > > :-) > > Perhaps you sh

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Guillaume Lelarge
Le vendredi 4 décembre 2009 à 18:43:47, Dave Page a écrit : > On Fri, Dec 4, 2009 at 5:33 PM, Guillaume Lelarge > > wrote: > > I see a use case for having both. If someone uses a lot the > > statement_timeout option, he'll be annoyed to put it in the text box > > every time he launches the query

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Dave Page
On Fri, Dec 4, 2009 at 5:38 PM, Guillaume Lelarge wrote: > We should probably drop this patch. I'll keep it in its git branch, because I > love the git branches and I hate losing something I wrote. :-) Perhaps you should publish your git tree (or select branches from it) to git.postgresql.org?

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Dave Page
On Fri, Dec 4, 2009 at 5:33 PM, Guillaume Lelarge wrote: > I see a use case for having both. If someone uses a lot the statement_timeout > option, he'll be annoyed to put it in the text box every time he launches the > query tool. Just save the value in the toolbar using sysSettings. >> Why sav

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Guillaume Lelarge
Le vendredi 4 décembre 2009 à 14:17:01, Dave Page a écrit : > On Fri, Dec 4, 2009 at 1:09 PM, Magnus Hagander wrote: > > I think the use-case is to have a default value for people who may > > otherwise send off a query that takes way too long? But in that case, > > it's probably better implemented

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Guillaume Lelarge
Le vendredi 4 décembre 2009 à 10:52:33, Dave Page a écrit : > On Fri, Dec 4, 2009 at 9:41 AM, Guillaume Lelarge > > wrote: > > Hi, > > > > Someone, on a french PostgreSQL forum, ask me for a statement timeout UI > > in the query tool. Here is what I've done so far: > > > > * add a config in the

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Dave Page
On Fri, Dec 4, 2009 at 1:09 PM, Magnus Hagander wrote: > I think the use-case is to have a default value for people who may > otherwise send off a query that takes way too long? But in that case, > it's probably better implemented as a default value on the server > side, no? If you decide someth

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Magnus Hagander
On Fri, Dec 4, 2009 at 10:52, Dave Page wrote: > On Fri, Dec 4, 2009 at 9:41 AM, Guillaume Lelarge > wrote: >> Hi, >> >> Someone, on a french PostgreSQL forum, ask me for a statement timeout UI in >> the query tool. Here is what I've done so far: >> >>  * add a config in the Query tab of the Opti

Re: [pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Dave Page
On Fri, Dec 4, 2009 at 9:41 AM, Guillaume Lelarge wrote: > Hi, > > Someone, on a french PostgreSQL forum, ask me for a statement timeout UI in > the query tool. Here is what I've done so far: > >  * add a config in the Query tab of the Options window; >  * add a textbox in the toolbar of the query

[pgadmin-hackers] Set statement timeout in the query tool

2009-12-04 Thread Guillaume Lelarge
Hi, Someone, on a french PostgreSQL forum, ask me for a statement timeout UI in the query tool. Here is what I've done so far: * add a config in the Query tab of the Options window; * add a textbox in the toolbar of the query tool; * each query executed will first get the old statement_timeou