Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Thanks, applied. On Mon, Feb 6, 2017 at 6:12 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find a fix for the same, attribute length was set to False instead of > None. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi Dave, Please find a fix for the same, attribute length was set to False instead of None. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Sure, Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Feb 4, 2017 at 7:34 PM, Dave Page wrote: > Hi Murtuza, > > I clearly neglected to run the regression tests with this patch, and > unfortunately

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi Murtuza, I clearly neglected to run the regression tests with this patch, and unfortunately it looks like it broke them. Can you look at this ASAP please? runTest (pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase) This function

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Thanks - patch applied. On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala wrote: > Hi, > > Please find updates patch for the same. > RM#2076 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi, Please find updates patch for the same. RM#2076 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. This seems to display "timestamp(0) with[out] timezone" columns correctly in both the properties panel and dialog now, but the size is still ignored if I try to add

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 30, 2017 at 8:07 PM, Dave Page wrote: > Can you rebase this please? > > Thanks. > > On Mon, Jan 30, 2017 at 5:37 AM, Murtuza

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Can you rebase this please? Thanks. On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zabuawala wrote: > Hi, > > Please find a patch to fix the issue in timestamp & time type when user > tries to provide scale/lengt to them. > I did some refactoring in code to handle