Re: [pgadmin-hackers] Migrating this list to PGLister on Friday, June 16th, 1300 UTC

2017-06-16 Thread Stephen Frost
Greetings, again! As an FYI, I am beginning the migration of this list now. You may see emails to this list be paused for a period of time, but none is expected to be lost. Thanks! Stephen * Stephen Frost ([email protected]) wrote: > Greetings! > > The PostgreSQL Infrastructure team will be

Re: [pgadmin-hackers] pgAdmin 4 commit: Add support for detachable tabs to the runtime.

2017-06-16 Thread Robert Eckhardt
gt; runtime/back.png | Bin 448 -> 290 bytes > runtime/close.png | Bin 587 -> 346 bytes > runtime/forward.png | Bin 445 -> 270 bytes > runtime/pgAdmin4.cpp | 15 +- > runtime/pgAdmin4.qrc | 1 + > runtime/qss/pgadmin4.qss | 3 + > 12 fil

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #185

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python27/185/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #179

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python35/179/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #182

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python36/182/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #175

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/175/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #185

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python33/185/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #302

2017-06-16 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/302/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix runtime support under Qt4

2017-06-16 Thread Dave Page
+--- runtime/pgAdmin4.cpp | 2 ++ 3 files changed, 15 insertions(+), 7 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #178

2017-06-16 Thread pgAdmin 4 Jenkins
de URL) SynonymGetTestCase (Fetch synonym Node URL) ResourceGroupsGetTestCase (Get resource groups) ResourceGroupsAddTestCase (Add resource groups) EDB Postgres AS 9.6: 163 tests passed 0 tests failed 0 tests skipped pgA

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #174

2017-06-16 Thread pgAdmin 4 Jenkins
ake target `clean'. Stop. Project MESSAGE: Building for QT4... Project MESSAGE: Using QWebKit... Project MESSAGE: Project MESSAGE: ** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #184

2017-06-16 Thread pgAdmin 4 Jenkins
vised that Qt 5.5.0 or later is used to build the pgAdmin runtime. Project MESSAGE: * Project MESSAGE: Project MESSAGE: Building for Linux/Mac... Project MESSAGE: Using /bin/python-config Project MESSAGE: Python2 de

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #181

2017-06-16 Thread pgAdmin 4 Jenkins
is used to build the pgAdmin runtime. Project MESSAGE: * Project MESSAGE: Project MESSAGE: Building for Linux/Mac... Project MESSAGE: Using /bin/python-config Project MESSAGE: Python2 detected. /usr/lib64/qt4/bi

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #301

2017-06-16 Thread pgAdmin 4 Jenkins
ing QWebKit... Project MESSAGE: Project MESSAGE: ** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used to build the pgAdmin ru

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #184

2017-06-16 Thread pgAdmin 4 Jenkins
** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used to build the pgAdmin runtime. Project MESSAGE: * Project MESSAGE: Project MESSAGE: Building for Linux/

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #177

2017-06-16 Thread pgAdmin 4 Jenkins
MESSAGE: Using QWebKit... Project MESSAGE: Project MESSAGE: ** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used to build the pgAdmin ru

[pgadmin-hackers] pgAdmin 4 commit: Ensure the feature tests use the correct test setting

2017-06-16 Thread Dave Page
| 2 -- web/pgadmin/__init__.py| 5 + web/regression/runtests.py | 5 - web/setup.py | 3 ++- 4 files changed, 11 insertions(+), 4 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

2017-06-16 Thread Dave Page
> Thanks, > Khushboo > > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter:

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #173

2017-06-16 Thread pgAdmin 4 Jenkins
ake target `clean'. Stop. Project MESSAGE: Building for QT4... Project MESSAGE: Using QWebKit... Project MESSAGE: Project MESSAGE: ** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #180

2017-06-16 Thread pgAdmin 4 Jenkins
et `clean'. Stop. Project MESSAGE: Building for QT4... Project MESSAGE: Using QWebKit... Project MESSAGE: Project MESSAGE: ** WARNING ** Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used to bui

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #183

2017-06-16 Thread pgAdmin 4 Jenkins
t Qt 5.5.0 or later is used to build the pgAdmin runtime. Project MESSAGE: * Project MESSAGE: Project MESSAGE: Building for Linux/Mac... Project MESSAGE: Using /bin/python-config Project MESSAGE: Python2 detected.

[pgadmin-hackers] pgAdmin 4 commit: Add support for detachable tabs to the runtime.

2017-06-16 Thread Dave Page
dmin4.qss | 3 + 12 files changed, 937 insertions(+), 226 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Harshal Dhumal
> >> ==== > == > >> >> ERROR: runTest > >> >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) > >> >> Query tool feature test > >>

[pgadmin-hackers] pgAdmin 4 commit: Using client-side implementation of 'url_for' in the

2017-06-15 Thread Ashesh Vashi
Using client-side implementation of 'url_for' in the settings module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=900ccebb50bdc448da5adad55fb513815b0a7b82 Modified Files -- web/pgadmin/settings/_

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

2017-06-15 Thread Josh Berkus
On 05/11/2017 12:54 AM, Devrim Gündüz wrote: > > Hi, > > On Wed, 2017-05-10 at 10:02 -0700, Josh Berkus wrote: >> So to make this work, pgadmin-v1-web needs to be a completely separate >> package, no? > > I don't think so, we can define Requires: part separa

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
== >> >> ERROR: runTest >> >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) >> >> Query tool feature test >> >> ------ >&g

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Harshal Dhumal
gt; >> different one each time. In the last two runs, I got: > >> > >> == > >> ERROR: runTest > >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) > >> Query tool feature test > >> -

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
-- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py", >> line 40, in setUp >> self.before() >>

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #171

2017-06-15 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/171/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the use

2017-06-15 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the user management module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c140b3f58980b6f1bba01e4ed8b7006fbd74af4 Modified Files -- web/pgadmin/tools/user_management/_

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #170

2017-06-15 Thread pgAdmin 4 Jenkins
se (Add resource groups) ResourceGroupsDeleteTestCase (Delete resource groups) ResourceGroupsGetTestCase (Get resource groups) ResourceGroupsPutTestCase (Put resource groups) pgAdmin 4 - Application Initialisation == N

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the imp

2017-06-15 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the import/export module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e65b605912194808a2530cc644367137240d1003 Modified Files -- web/pgadmin/tools/import_export/_

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mai

2017-06-15 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the maintenance module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07580b844466e55c825178ce0385c82c57dff149 Modified Files -- web/pgadmin/tools/maintenance/_

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-15 Thread Dave Page
gt;>>> >>>> On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear >>>> wrote: >>>> > Hi Hackers! >>>> > >>>> > This patch includes a new pane in the history tab that displays the >>>> > full >>>> > f

[pgadmin-hackers] pgAdmin 4 commit: Fix Yarn tasks for Windows

2017-06-15 Thread Dave Page
| 4 ++-- web/regression/javascript/fake_endpoints.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Minor typo in web/config.py

2017-06-15 Thread Dave Page
Thanks, patch applied. On Thu, Jun 15, 2017 at 12:24 PM, Johan Van de Wauw wrote: > There is a minor typo in the web/config.py > > patch attached > > Kind Regards, > Johan > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To

[pgadmin-hackers] pgAdmin 4 commit: Fix a typo in the config file

2017-06-15 Thread Dave Page
(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-15 Thread Sarah McAlear
a new pane in the history tab that displays the >>> full >>> > formatted query and meta data about the query. >>> > >>> > Thanks! >>> > Shruti & Sarah >>> > >>> > >>> > >>> > >>

[pgadmin-hackers] Minor typo in web/config.py

2017-06-15 Thread Johan Van de Wauw
aptor address. -- 2.1.4 -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

2017-06-15 Thread Khushboo Vashi
rather set environment variable PGADMIN_TESTING_MODE to check the testing status and accordingly set the TEST_SQLITE_PATH (i.e. Database path for testing). Thanks, Khushboo diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index 5a74927..14e84c8 100644 --- a/web/pgadmin/__init__.py

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Surinder Kumar
that i added untracked file to tracked. >> >> On Thu, Jun 15, 2017 at 4:10 PM, Dave Page wrote: >> >>> Hi >>> >>> Was this patch generated against a WIP branch? I get: >>> >>> (pgadmin4)piranha:pgadmin4 dpage$ git apply >>> ~/Do

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
s this patch generated against a WIP branch? I get: >> >> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_que >> ry_tool.patch >> error: web/pgadmin/static/js/setup_connection.js: No such file or >> directory >> >> On Thu, Jun 15, 2017 a

[pgadmin-hackers] pgAdmin 4 commit: Fix script options which were inadvertently broken in

2017-06-15 Thread Dave Page
Fix script options which were inadvertently broken in the query tool tab naming patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a87585665049fb67ca9d51fd949b3bd7d25b077 Author: Surinder Kumar Modified Files -- web/pgadmin

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Surinder Kumar
page$ git apply ~/Downloads/fix_scripts_in_ > query_tool.patch > error: web/pgadmin/static/js/setup_connection.js: No such file or > directory > > On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < > [email protected]> wrote: > >> Hi >> >> PF

[pgadmin-hackers] pgAdmin 4 commit: Add double precision[] tests to the query tool.

2017-06-15 Thread Dave Page
| 77 -- 1 file changed, 58 insertions(+), 19 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

2017-06-15 Thread Dave Page
> > tool, >> > SELECT ARRAY[1, 'nan', 3]::float[]; >> > >> > -- >> > Regards, >> > Murtuza Zabuawala >> > EnterpriseDB: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> > >> > >>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

2017-06-15 Thread Murtuza Zabuawala
8 > > > > Steps to re-produce: Below given query fails to render result in Query > tool, > > SELECT ARRAY[1, 'nan', 3]::float[]; > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Ent

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

2017-06-15 Thread Dave Page
egards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/

[pgadmin-hackers] pgAdmin 4 commit: Fix canceling of Grant Wizard on Windows. Fixes #2142

2017-06-15 Thread Dave Page
/grant_wizard/js/grant_wizard.js| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
Hi Was this patch generated against a WIP branch? I get: (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_query_tool.patch error: web/pgadmin/static/js/setup_connection.js: No such file or directory On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < surinder

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-15 Thread Dave Page
o a new thread as it doesn't seem related to >> these changes? > > Something in these changes caused it to start manifesting, but I agree > the underlying issue was probably there anyway. I'm happy to move to a > different thread. I've created a ticket for this: h

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

2017-06-15 Thread Murtuza Zabuawala
/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js b/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js index fd0a4e5..f79fb2f 100644 --- a/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js +++ b/web/pgadmin/tools/grant_wizard/templates

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-14 Thread Surinder Kumar
; --- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=57d866f7b70996a82a881b20248c3285ab3a6900 >> Author: Surinder Kumar >> >> Modified Files >> -- >> web/pgadmin/browser/templates/browser/js/node.js | 4 +- >&g

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-14 Thread Harshal Dhumal
l.org/gitweb?p=pgadmin4.git;a=commitdiff;h= > 57d866f7b70996a82a881b20248c3285ab3a6900 > Author: Surinder Kumar > > Modified Files > -- > web/pgadmin/browser/templates/browser/js/node.js | 4 +- > web/pgadmin/static/css/webcabin.overrides.css | 13 +

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Sarah McAlear
gt; your team been able to look at that yet? >> >> On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear >> wrote: >> > Hi Hackers! >> > >> > This patch includes a new pane in the history tab that displays the full >> > formatted query and meta data ab

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Robert Eckhardt
s a new pane in the history tab that displays the full > > formatted query and meta data about the query. > > > > Thanks! > > Shruti & Sarah > > > > > > > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin

[pgadmin-hackers] Migrating this list to PGLister on Friday, June 16th, 1300 UTC

2017-06-14 Thread Stephen Frost
Greetings! The PostgreSQL Infrastructure team will be migrating the project's mailing lists from the existing system (an ancient and unmaintained piece of software called "majordomo2") to a newly developed mailing list system (known as "PGLister"), which better addresses the needs of the PostgreSQ

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Dave Page
wrote: > Hi Hackers! > > This patch includes a new pane in the history tab that displays the full > formatted query and meta data about the query. > > Thanks! > Shruti & Sarah > > > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Harshal Dhumal
>>>> sqleditor backend (python code). >> >>>>> @Dave should I include python unit test cases in this patch? >> >>>> >> >>>> >> >>>> We do have some feature tests that hit the query tool - Murtuza wrote >> >>>> some anti-XSS validation tests for example, and Khushboo has been >> working on >> >>>> some datatype rendering tests. >> >>>> >> >>>> As a general rule, I prefer we focus more on feature tests now than >> the >> >>>> API tests - they cover the whole app end-to-end of course. The >> disadvantages >> >>>> are: >> >>>> >> >>>> - The treeview isn't reliable enough for me to enable those tests on >> the >> >>>> CI server yet. >> >>>> >> >>>> - They can take a long time to run, so we need to test multiple >> things >> >>>> at once wherever possible. That means minimising browser reloads, or >> new >> >>>> instances of tools like the Query Tool - or even the number of >> queries >> >>>> executed through the query tool as part of a test. >> >>>> >> >>>> That said, yes, if there are specific things that are not covered by >> >>>> Murtuza and Khushboo's work, we should test them. For example, >> loading all >> >>>> rows when the user selects all, running/rendering EXPLAIN, >> auto-commit vs. >> >>>> auto-rollback (and combinations thereof). >> >>>> >> >>>> The standard moving forwards should be to include feature tests for >> new >> >>>> functionality and Jasmine tests for algorithmic JS code. >> >>>> >> >>>> I also agree with Joao on the modularisation of JS code. Testable and >> >>>> reusable code should be in "library" files, and we should work to >> minimise >> >>>> the amount of JS templates - for the most part, that means moving to >> the >> >>>> client-side translation mechanism which Tira worked on, and I've >> done some >> >>>> early migration work. >> >>>> >> >>>> Thanks. >> >>>> >> >>>> >> >>>> -- >> >>>> Dave Page >> >>>> Blog: http://pgsnake.blogspot.com >> >>>> Twitter: @pgsnake >> >>>> >> >>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>> The Enterprise PostgreSQL Company >> >>> >> >>> >> >> >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list ([email protected]) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> > >

[pgadmin-hackers] Invitation to a Community Developer Forum

2017-06-14 Thread Matthew Kleiman
RYyZLQTrOGI3rPhd9m8/edit?usp=sharing> to record items that you would like to discuss. Looking forward to seeing you all! - Pivotal pgAdmin Team Google Calendar invite <https://www.google.com/calendar/render?action=TEMPLATE&text=pgAdmin%20Hackers%20Community%20Forum&dates=20170629T120

[pgadmin-hackers] pgAdmin 4 commit: Add some more Makefile targets for running different

2017-06-14 Thread Dave Page
(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Ashesh Vashi
>>>> As a general rule, I prefer we focus more on feature tests now than > the > >>>> API tests - they cover the whole app end-to-end of course. The > disadvantages > >>>> are: > >>>> > >>>> - The treeview isn't reliable enough for me to enable those tests on > the > >>>> CI server yet. > >>>> > >>>> - They can take a long time to run, so we need to test multiple things > >>>> at once wherever possible. That means minimising browser reloads, or > new > >>>> instances of tools like the Query Tool - or even the number of queries > >>>> executed through the query tool as part of a test. > >>>> > >>>> That said, yes, if there are specific things that are not covered by > >>>> Murtuza and Khushboo's work, we should test them. For example, > loading all > >>>> rows when the user selects all, running/rendering EXPLAIN, > auto-commit vs. > >>>> auto-rollback (and combinations thereof). > >>>> > >>>> The standard moving forwards should be to include feature tests for > new > >>>> functionality and Jasmine tests for algorithmic JS code. > >>>> > >>>> I also agree with Joao on the modularisation of JS code. Testable and > >>>> reusable code should be in "library" files, and we should work to > minimise > >>>> the amount of JS templates - for the most part, that means moving to > the > >>>> client-side translation mechanism which Tira worked on, and I've done > some > >>>> early migration work. > >>>> > >>>> Thanks. > >>>> > >>>> > >>>> -- > >>>> Dave Page > >>>> Blog: http://pgsnake.blogspot.com > >>>> Twitter: @pgsnake > >>>> > >>>> EnterpriseDB UK: http://www.enterprisedb.com > >>>> The Enterprise PostgreSQL Company > >>> > >>> > >> > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Dave Page
eral rule, I prefer we focus more on feature tests now than the >>>> API tests - they cover the whole app end-to-end of course. The >>>> disadvantages >>>> are: >>>> >>>> - The treeview isn't reliable enough for me to enable those tests on the

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
rate menu option, with a simple dialogue to let the user choose the >> table to attach. >> >> The reason for that is that Attach is an action not a property. On the >> Properties panels we expect any changes we make to be the same the next >> time the dialogue is opened -

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Ashesh Vashi
you next open the Properties > dialogue, those partitions will be listed in the partition list, not the > Attach list. > > >> Please review the design. Suggestions/Comments are welcome. >> >> >> On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt >> wrote:

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-14 Thread Dave Page
t from Google) but would take some time to pick >> > the >> > appropriate one. >> > >> > Option 2 would be the best option for now. We should stick with >> > Helvetica >> > and Arial until we have more time to choose the right font. >> >> Sounds good to me. >> >> Surinder, can you make that change please? And update any other font >> definitions in our CSS to have the same fallback? > > Added fonts Arial, Verdana as fallback in pgadmin.styles.css file. Also used > text-12 class for datagrid element. >> >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure text editors render in an appropriate place on

2017-06-14 Thread Dave Page
Ensure text editors render in an appropriate place on the results grid. Fixes #2477 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdc9eed51479e0057420f116f4b3b7425a12f377 Author: Surinder Kumar Modified Files -- web/pgadmin

[pgadmin-hackers] pgAdmin 4 commit: Un-break the feature tests. Fixes from Surinder and m

2017-06-14 Thread Dave Page
Un-break the feature tests. Fixes from Surinder and myself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b4a8ed89c9374fa9e0f9c0eb190662979d0bb6b Author: Surinder Kumar Modified Files -- web/pgadmin/feature_tests

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-14 Thread Dave Page
_name] - [db_name] - [table_name] >> >> >> >> These names are more meaningful instead of "Query - #'. helpful while >> >> switching to panel tabs. >> >> >> >> 3) If panel is inactive and its title is quite long, show >>

[pgadmin-hackers] pgAdmin 4 commit: Fix the JS Bundler test to work when there are multip

2017-06-14 Thread Dave Page
-- .../javascript/tests/test_javascript_bundler.py| 106 ++--- 1 file changed, 50 insertions(+), 56 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-14 Thread Dave Page
ass, the second execution of the bundler test fails with: >> >> == >> FAIL: runTest >> (pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase) >> scenario name: JavascriptBundler

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
Properties dialogue, those partitions will be listed in the partition list, not the Attach list. > Please review the design. Suggestions/Comments are welcome. > > > On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt > wrote: > >> >> >> On Tue, Jun 6, 2017 at 4:32 AM, Dave Pag

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #159

2017-06-13 Thread pgAdmin 4 Jenkins
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://je

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #291

2017-06-13 Thread pgAdmin 4 Jenkins
gadmin.org/job/pgadmin4-master-python26/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_code == 200 AssertionError ==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #162

2017-06-13 Thread pgAdmin 4 Jenkins
a node -- Traceback (most recent call last): File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python35/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in set

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #158

2017-06-13 Thread pgAdmin 4 Jenkins
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.p

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #165

2017-06-13 Thread pgAdmin 4 Jenkins
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.p

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #169

2017-06-13 Thread pgAdmin 4 Jenkins
..] File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_code == 200 AssertionError =

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar
On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang wrote: > > > On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < > [email protected]> wrote: > >> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: >> >>> Awesome!! This is super helpful :) >>> >>> Does this affect a new query window

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #166

2017-06-13 Thread pgAdmin 4 Jenkins
gadmin.org/job/pgadmin4-master-python35/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_code == 200 AssertionError ==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #285

2017-06-13 Thread pgAdmin 4 Jenkins
gadmin.org/job/pgadmin4-master-python26/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.pgadmin.org/job/pgadmin4-master-p

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #167

2017-06-13 Thread pgAdmin 4 Jenkins
..] File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python36/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_code == 200 AssertionError =

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #161

2017-06-13 Thread pgAdmin 4 Jenkins
l tabs. Fixes #2482 -- [...truncated 270.64 KB...] File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert respons

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Shirley Wang
On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < [email protected]> wrote: > On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: > >> Awesome!! This is super helpful :) >> >> Does this affect a new query window (currently the title is 'Query - >> untitled')? >> > ​Yes, in this ca

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar
t;> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab. >> >> Also tested with preference settings > Open query tool in new tab. It >> works!!. >> >> Please find attached patch >> >> Thanks >> Surinder >> >> -- >> Sent via pgadmin-hackers mailing list ([email protected]) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Surinder Kumar
>> otherwise display full title. > >> > >> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab. > >> > >> Also tested with preference settings > Open query tool in new tab. It > >> works!!. > >> > >> Ple

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-13 Thread Shirley Wang
needs to be >> done to complete that. >> Please review the design. Suggestions/Comments are welcome. >> >> >> On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt >> wrote: >> >>> >>> >>> On Tue, Jun 6, 2017 at 4:32 AM, Dave Page wrote: >>

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #156

2017-06-13 Thread pgAdmin 4 Jenkins
gadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #163

2017-06-13 Thread pgAdmin 4 Jenkins
gadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #290

2017-06-13 Thread pgAdmin 4 Jenkins
..] File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_code == 200 AssertionError =

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #165

2017-06-13 Thread pgAdmin 4 Jenkins
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python36/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://je

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-13 Thread Robert Eckhardt
t;> >> On Tue, Jun 6, 2017 at 4:32 AM, Dave Page wrote: >> >>> >>> For roll up this pattern seems obvious, identify the n partitions you >>>> need/want to combine and then run a job to combine them. >>>> >>> >>> You&

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Shirley Wang
of tab. > > Also tested with preference settings > Open query tool in new tab. It > works!!. > > Please find attached patch > > Thanks > Surinder > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page
is(...), >> otherwise display full title. >> >> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab. >> >> Also tested with preference settings > Open query tool in new tab. It >> works!!. >> >> Please find attached patch >> &g

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #288

2017-06-13 Thread pgAdmin 4 Jenkins
_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_c

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #287

2017-06-13 Thread pgAdmin 4 Jenkins
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ws/web/pgadmin/browser/server_groups/servers/databases/schemas/views/tests/test_views_get.py";,> line 47, in setUp server_response = server_utils.connect_server(self, self.server_id) File "<https://je

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Joao Pedro De Almeida Pereira
. > JavascriptBundlerTestCase) > scenario name: JavascriptBundlerTestCase > -- > Traceback (most recent call last): > File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/ > tests/test_javascript_bundle

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #167

2017-06-13 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python35/167/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #167

2017-06-13 Thread pgAdmin 4 Jenkins
_response = server_utils.connect_server(self, self.server_id) File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/tests/utils.py";,> line 32, in connect_server assert response.status_c

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #171

2017-06-13 Thread pgAdmin 4 Jenkins
See <https://jenkins.pgadmin.org/job/pgadmin4-master-python33/171/display/redirect?page=changes> -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

  1   2   3   4   5   6   7   8   9   10   >