Re: [pgadmin-hackers] PgAgent Patch

2015-04-17 Thread Sanket Mehta
Hi Mehmet, I have modified the patch as explained below: After carefully reviewing the patch, we found that there is a memory leak while error file handling. after opening the file in write mode using freopen(), we again open the same file in read mode using fopen(). at this time we are just ope

Re: [pgadmin-hackers] PgAgent Patch

2015-04-17 Thread Mehmet Emin KARAKAŞ
Hi Sanket, I test the patch on windows7 and Ubuntu 14.10. It's working fine. 2015-04-17 12:54 GMT+03:00 Sanket Mehta : > Hi Mehmet, > > I have modified the patch as explained below: > > After carefully reviewing the patch, we found that there is a memory leak > while error file handling. > > aft

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-17 Thread Dave Page
On Fri, Apr 17, 2015 at 12:55 PM, Ronan Dunklau wrote: > > Please find attached a WIP patch "reifying" the module API. > > The main browser/server_groups/server structure has been converted to his API, > whereas the test, help and about modules have not. > > The following changes were made: > > -