[pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

Hi, PFA patch to fix the issue of jsonb type rendering issue in runtime. RM#1404 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1404.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresq

[pgadmin-hackers] pgAdmin 4 commit: Revert "Display busy indicators in a much more consis

Revert "Display busy indicators in a much more consistent way. Fixes #1242" This reverts commit 7fbefa507bd1251609d4dae15158bd7ca6f9b618 which seems to be missing things. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1222681888c102f3dccf5432c

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes

Hi On Mon, Jun 27, 2016 at 7:09 PM, Surinder Kumar wrote: > Hi Dave, > > I have seen following changes are missed in the code checked in: > 1) "Code to avoid unnecessary reloads & displaying spinner" for Properties, > SQL & Statistics tab is missing. > whereas the code for depends and dependabil

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes

On Wed, Jun 29, 2016 at 3:13 PM, Dave Page wrote: > Hi > > On Mon, Jun 27, 2016 at 7:09 PM, Surinder Kumar > wrote: > > Hi Dave, > > > > I have seen following changes are missed in the code checked in: > > 1) "Code to avoid unnecessary reloads & displaying spinner" for > Properties, > > SQL & S

[pgadmin-hackers] pgAdmin 4 commit: Show a loading indicator until things are ready to ro

Show a loading indicator until things are ready to rock. Fixes #1400 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d0c160fb8105815bedd09a4b68dabb5f0b5675b Author: Surinder Kumar Modified Files -- web/pgadmin/browser/templates/br

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1400 - Application loading indicator

Thanks - applied! On Tue, Jun 28, 2016 at 10:29 AM, Surinder Kumar wrote: > Hi, > > Please find the patch for RM#1400 > > We are implementing require.onResourceLoad function of require.js, which > loads one by one > JS modules recursively and hide spinner when all modules are loaded > completely.

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

Hi On Tue, Jun 28, 2016 at 12:30 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where 'serial' like types were not listed under > type combobox while creating new table/column. > RM#1393 This changes the display text of all integer columns with a dependency to the respective s

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala wrote: > Yes Dave, I agree that downloading files has been supported in browsers since > long . > > But in general we send request & then receives files from web server but in > our case we are fetching our data from Backbone models & then conv

Re: [pgadmin-hackers] Patch for RM1399 [pGADMIN4]

Thanks, applied. On Tue, Jun 28, 2016 at 3:34 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue rm1399 > > Issue: Sometimes codemirror does not render properly in SQL tab > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise Postgre

[pgadmin-hackers] pgAdmin 4 commit: Fix intermittent CodeMirror rendering issue. Fixes #1

Fix intermittent CodeMirror rendering issue. Fixes #1399 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9396cb03d58039012ca7a631aa2b0d34a74f9dc8 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/templates/browser/js/bro

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself. https://webkit.org/status/#feature-download-attribute > On 29-Jun-2016, at 3:40 p

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

Hi On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue of jsonb type rendering issue in runtime. > RM#1404 I'm not convinced this is a good fix for a couple of reasons: 1) You're only applying the fix if we're running in the runtime. The runtime uses

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Neel is just adding the ability to save a file rather than display it. His work won't add the APIs to do client-side downloads - though it will be needed to support that. On Wed, Jun 29, 2016 at 11:22 AM, Murtuza Zabuawala wrote: > Yes, It will not work in runtime as well but I think Neel is work

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes

Hi, Please find the v2 patch for RM#1242 *Change:* 1) Removed the busy indicators from the dashboard, stats, properties, deps etc. 2) Also merged the changes of patch "busy icon not centered". Apart from this, In Runtime environment busy indicators are not visible while rendering of Debugger and

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

Hi Dave, As suggested please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 29, 2016 at 3:37 PM, Dave Page wrote: > Hi > > On Tue, Jun 28, 2016 at 12:30 PM, Murtuza Zabuawala > wrote: > > Hi, > > > > PF

[pgadmin-hackers] pgAdmin 4 commit: Consistent busy indication. Fixes #1242

Consistent busy indication. Fixes #1242 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53434030c1fe82cac0607a1934e164dece9fd664 Author: Surinder Kumar Modified Files -- .../browser/templates/browser/js/browser.js| 6 --- .

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes

Thanks, applied. On Wed, Jun 29, 2016 at 11:49 AM, Surinder Kumar wrote: > Hi, > > Please find the v2 patch for RM#1242 > Change: > 1) Removed the busy indicators from the dashboard, stats, properties, deps > etc. > 2) Also merged the changes of patch "busy icon not centered". > > Apart from this

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

That's the same patch! On Wed, Jun 29, 2016 at 11:54 AM, Murtuza Zabuawala wrote: > Hi Dave, > > As suggested please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 29, 2016 at 3:37 PM, Dave

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala wrote: > Yes, It will not work in runtime as well but I think Neel is working for > fix in run time for this issue, We might able to fix it in run time but > issue persists in Safari unless they add support in browser itself. > > https://webkit.o

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

Apologies, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 29, 2016 at 4:49 PM, Dave Page wrote: > That's the same patch! > > On Wed, Jun 29, 2016 at 11:54 AM, Murtuza Zabuawala > wrote: > > Hi Da

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Hi Dave, As per discussion over mail i have created separate config files for credentials and test data. PFA patch for same. Kindly, review and let me know for modifications. On 27 June 2016 at 15:10, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 27 June 2016 at 13:24, D

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA upadated patch for RM1336 Issue fixed: Query tool shortcuts weren't working on mac runtime. Also changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" dialog in runtime. -- *Harshal Dhumal* *Software

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal wrote: > Hi, > > PFA upadated patch for RM1336 > > Issue fixed: Query tool shortcuts weren't working on mac runtime. Also > changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> > Alt+Shift+N as Ctrl+Shift+A was conflicting with short

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, Here is updated patch for RM1336 Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

[pgadmin-hackers] pgAdmin 4 commit: Offer the various serial pseudo-types as column type

Offer the various serial pseudo-types as column type options. Fixes #1393 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8246fc56e8303fe436544e0a6edb0e9fc0d4d8b5 Author: Murtuza Zabuawala Modified Files -- .../server_groups/server

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

Thanks! Patch applied. On Wed, Jun 29, 2016 at 12:23 PM, Murtuza Zabuawala wrote: > Apologies, > > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 29, 2016 at 4:49 PM, Dave Page wrote

[pgadmin-hackers] pgAdmin 4 commit: Use Alt+Shift for runtime shortcuts to avoid collisio

Use Alt+Shift for runtime shortcuts to avoid collisions with app shortcuts. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8c9ccc93932512f4ffa547896f9c6280f5b19e7 Modified Files -- runtime/BrowserWindow.cpp | 6 +++--- 1 file chang

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Wed, Jun 29, 2016 at 7:32 PM, Harshal Dhumal wrote: > Hi, > > Here is updated patch for RM1336 > > Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show > "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A I updated the runtime to use Alt+Shift+A, as well

[pgadmin-hackers] pgAdmin 4 commit: Prefix the version number with 'v' in the Loading mes

Prefix the version number with 'v' in the Loading message. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d795f37fe51ef53ea07d8ededdf0d10b4b94ee65 Modified Files -- web/pgadmin/browser/templates/browser/index.html | 2 +- 1 file cha

[pgadmin-hackers] pgAdmin 4 commit: Localise the loading message.

Localise the loading message. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4504f1dc21dce695b21fbba6a0d6cfe9b63a381 Modified Files -- web/pgadmin/browser/templates/browser/index.html | 2 +- 1 file changed, 1 insertion(+), 1 delet

[pgadmin-hackers] pgAdmin 4 commit: Use a standard colour for error highlighting.

Use a standard colour for error highlighting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0282ef79929a06a89b73cff16a9661a8a9d48790 Modified Files -- web/pgadmin/tools/sqleditor/static/css/sqleditor.css | 3 +-- 1 file changed, 1