Hi,

Here is updated patch for RM1336

Fixed query tool shortcuts issue in Mac runtime and changed shortcut to
show "About" dialog in runtime from Ctrl+Shift+A ----> Alt+Shift+A

-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 11:41 PM, Dave Page <dp...@pgadmin.org> wrote:

> Hi
>
> On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal
> <harshal.dhu...@enterprisedb.com> wrote:
> > Hi,
> >
> > PFA upadated patch for RM1336
> >
> > Issue fixed: Query tool shortcuts weren't working on mac runtime. Also
> > changed shortcut key for "Explain analyze" from Ctrl+Shift+A --->
> > Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about"
> > dialog in runtime.
>
> Thanks - but let's change the runtime and go back to Ctrl+Shift+A in
> the app. The About box in the runtime is really unimportant.
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp
index 5419c0e..684cb27 100644
--- a/runtime/BrowserWindow.cpp
+++ b/runtime/BrowserWindow.cpp
@@ -125,7 +125,7 @@ void BrowserWindow::createActions()
     connect(exitShortcut, SIGNAL(activated()), this, SLOT(close()));
 
     // About box
-    aboutShortcut = new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_A), this);
+    aboutShortcut = new QShortcut(QKeySequence(Qt::ALT + Qt::SHIFT + Qt::Key_A), this);
     aboutShortcut->setContext(Qt::ApplicationShortcut);
     connect(aboutShortcut, SIGNAL(activated()), this, SLOT(about()));
 }
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 92579f1..2a269c0 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -176,7 +176,7 @@ define(
         "click #btn-explain-buffers": "on_explain_buffers",
         "click #btn-explain-timing": "on_explain_timing",
         "change .limit": "on_limit_change",
-        "keyup": "keyAction"
+        "keydown": "keyAction"
       },
 
       // This function is used to render the template.
@@ -1020,7 +1020,7 @@ define(
             // char e/E
             // Execute query.
             this.on_flash(ev);
-          } else if(ev.keyCode == 88){
+          } else if(ev.keyCode == 88) {
             // char x/X
             // Explain query.
             this.on_explain(ev);
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to