Re: [pgadmin-hackers] [pgadmin4] Edb package support.

Hi Harshal, Please see below review comments. 1. Please make one line space between every SQL block as per pgAdmin 4 standard. 2. The RE SQL of package is not correct. The package name is displayed twice as shown below CREATE OR REPLACE PACKAGE enterprisedb.empinfo IS edb.empinfo is emp_name

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Hi Dave, Please find updated patch with auto scrolling & also fixed duplicate messages issue. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 17, 2016 at 7:09 PM, Dave Page wrote: > Hi > > On

[pgadmin-hackers] [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

Hi *Issue:* The table column data is incomplete for columns having more character lengths. *Solution:* Extends *Backgrid.Cell* and add '*mouseover*' event. On mouse over, check if cell content is larger than the cell width, then add tooltip to the column by setting cell content in the title attri

[pgadmin-hackers] pgAdmin 4 commit: Fix WSGI support.

Fix WSGI support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=050937a32abf75e4c08b18044c695d9621b4cc86 Modified Files -- docs/en_US/server_deployment.rst | 19 +-- web/config.py| 5 - web/p

[pgadmin-hackers] Fixes RM #1453 Reduce menu bar height

Hi All I have fixed the RM #1453 "Reduce menu bar height". As per comment in the RM, I have kept size to 40px. Attached is the patch file, please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixed typo in security labels macro Fixes #1457

Fixed typo in security labels macro Fixes #1457 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e0a61f5564bb9b2dcf7fa90fc7f36d9c748ac5b Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/templates/macros/schemas/sec

Re: [pgadmin-hackers] PATCH: Fixed typo in security labels macro (pgAdmin4)

Thanks, patch applied. On Fri, Jul 29, 2016 at 6:30 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix typo in security labels macro. > > RM#1457 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise P

[pgadmin-hackers] New table - column order changes

Hi, I hope this is the place for pgAdmin4 issues. On beta 4 in the "Create Table" dialogue, I've noticed new columns I add will sometimes jump to the top of the column list. If needed I'll try to get a minimal example. Ohad

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

Hi, On Wed, Aug 17, 2016 at 11:19 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA initial patch for SlickGrid integration in query tool. > This is looking awesome! I think there are some tweaks to make, but performance-wise, it's blowing away the old code. My tes

[pgadmin-hackers] pgAdmin 4 commit: Reduce main menu height a little. Fixes #1453

Reduce main menu height a little. Fixes #1453 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b1b60bc2b7e994e824f82c3232c52dc9e9e16e5 Author: Akshay Joshi Modified Files -- web/pgadmin/browser/templates/browser/index.html | 4 ++-

Re: [pgadmin-hackers] Fixes RM #1453 Reduce menu bar height

Thanks, applied. On Thu, Aug 18, 2016 at 2:55 PM, Akshay Joshi wrote: > Hi All > > I have fixed the RM #1453 "Reduce menu bar height". As per comment in the > RM, I have kept size to 40px. Attached is the patch file, please review it > and let me know the review comments. > > -- > *Akshay Joshi*

[pgadmin-hackers] pgAdmin 4 commit: Properly display messages from the server in the quer

Properly display messages from the server in the query tool. Fixes #1523 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6391c7e9b26e5e10bb38a4d90f4503a4cb3e63f Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqledit

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Thanks, applied. On Thu, Aug 18, 2016 at 10:21 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find updated patch with auto scrolling & also fixed duplicate > messages issue. > Please review. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.c

Re: [pgadmin-hackers] [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

Hi On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar wrote: > Hi > > Issue: > The table column data is incomplete for columns having more character > lengths. > > Solution: > Extends Backgrid.Cell and add 'mouseover' event. On mouse over, check if > cell content is larger than the cell width, then

[pgadmin-hackers] pgAdmin 4 commit: Ensure PG/EPAS configuration warnings are shown appro

Ensure PG/EPAS configuration warnings are shown appropriate for the server type. Fixes #1563 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=013ff1090e4b084166077a9e43196a91d7e17e24 Author: Murtuza Zabuawala Modified Files -- web/

Re: [pgadmin-hackers] PATCH: To fix the issue in configuration error message (pgAdmin4)

Thanks, patch applied. On Thu, Aug 18, 2016 at 7:24 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user was getting same error message for PG > & PPAS bin path configuration. > RM#1563 > > Issue: The condition to check server type was not working as expected in > Backup/R

Re: [pgadmin-hackers] [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

On Aug 18, 2016 9:42 PM, "Dave Page" wrote: > > Hi > > On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar > wrote: > > Hi > > > > Issue: > > The table column data is incomplete for columns having more character > > lengths. > > > > Solution: > > Extends Backgrid.Cell and add 'mouseover' event. On mo