[pgadmin-hackers] pgAdmin 4 commit: Improve binary path settings hint.

2016-09-07 Thread Dave Page
Improve binary path settings hint. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd139bc83e9df1fbf6ccf7eafa8a676ef594d983 Modified Files -- web/pgadmin/browser/server_groups/servers/types.py | 2 +- 1 file changed, 1 insertion(+),

[pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi, PFA patch to add more confirmations in query tool before taking any actions which might cause lose changes, - Clearing editor - Clearing history - Load file data RM#1666 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server

2016-09-07 Thread Surinder Kumar
Hi while closing query tool, the following error is display on python console. File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/tools/datagrid/__init__.py", line 270, in close manager.release(did=cmd_obj.did, conn_id=cmd_obj.conn_id) File "/Users/surinder/Documents/Projects/p

[pgadmin-hackers] [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query

2016-09-07 Thread Surinder Kumar
Hi *This patch contains following changes:* 1) Set focus on query tool once loaded. 2) While switching b/w panels find active tab and set focus on query tool. 3) Remove whitespace from file. This will allow user to switch b/w panels without insisting user to click on query tool. Please find atta

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Dave Page
Hi On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add more confirmations in query tool before taking any actions > which might cause lose changes, > - Clearing editor > - Clearing history > - Load file data > RM#1666 > > Please review. Can you tweak it so that

Re: [pgadmin-hackers] Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server

2016-09-07 Thread Dave Page
Thanks - applied. On Wed, Sep 7, 2016 at 12:38 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > while closing query tool, the following error is display on python console. > > File > "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/tools/datagrid/__init__.py", > li

[pgadmin-hackers] pgAdmin 4 commit: Fix typo in connection handler.

2016-09-07 Thread Dave Page
Fix typo in connection handler. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da21cabb1e6459fe073f010ce0473399a956ea5b Author: Surinder Kumar Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++-- 1 file changed

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query

2016-09-07 Thread Dave Page
Hi This doesn't apply - can you rebase it please? Thanks. On Wed, Sep 7, 2016 at 12:46 PM, Surinder Kumar wrote: > Hi > > This patch contains following changes: > 1) Set focus on query tool once loaded. > 2) While switching b/w panels find active tab and set focus on query tool. > 3) Remove whi

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Sure I'll do it, But I thought like let user traverse through file manager (he may or may not select any file to load) and warn only if he/she try to load file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at 6:30 P

[pgadmin-hackers] PATCH: wrong sql in function node (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi, PFA patch to fix an issue where function node displaying wrong SQL for a function returning a SETOF record, the display is wrong: it displays: RETURNS SETOF "SETOF record" instead of RETURNS SETOF record RM#1631 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The En

[pgadmin-hackers] pgAdmin 4 commit: Fix SQL generation for functions that return SETOF ..

2016-09-07 Thread Dave Page
Fix SQL generation for functions that return SETOF ... Fixes #1631 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35d3c396de26c2fd5586a7d3af0d699a02a9b062 Author: Murtuza Zabuawala Modified Files -- .../schemas/functions/templates

Re: [pgadmin-hackers] PATCH: wrong sql in function node (pgAdmin4)

2016-09-07 Thread Dave Page
Thanks, applied. On Wed, Sep 7, 2016 at 2:27 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix an issue where function node displaying wrong SQL for a > function returning a SETOF record, the display is wrong: > > it displays: > RETURNS SETOF "SETOF record" > > instead of > RETURNS SETOF re

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Dave Page
I think it's better to warn them as early as possible, as we do in pgAdmin 3 (actually, there we just prompt them to save the changes, but I think either is fine). On Wed, Sep 7, 2016 at 2:04 PM, Murtuza Zabuawala wrote: > Sure I'll do it, But I thought like let user traverse through file manager

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query

2016-09-07 Thread Surinder Kumar
Hi Please find updated patch with below changes: 1. A code block is formatted, previously not aligned. 2. rebased the patch. 3. Remove trailing whitespace. On Wed, Sep 7, 2016 at 6:33 PM, Dave Page wrote: > Hi > > This doesn't apply - can you rebase it please? > > Thanks. > > On Wed, Sep 7, 201

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query

2016-09-07 Thread Dave Page
Thanks - applied. On Wed, Sep 7, 2016 at 3:27 PM, Surinder Kumar wrote: > Hi > > Please find updated patch with below changes: > 1. A code block is formatted, previously not aligned. > 2. rebased the patch. > 3. Remove trailing whitespace. > > On Wed, Sep 7, 2016 at 6:33 PM, Dave Page wrote: >>

[pgadmin-hackers] pgAdmin 4 commit: Ensure the query tool editor has focus when the tab i

2016-09-07 Thread Dave Page
Ensure the query tool editor has focus when the tab is selected or when first shown so the user can immediately type/execute. Fixes #1581 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f13de8b86b0e83f4aa96ecd9f0ae8844a1d8a7ae Author: Surinder

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at 7:30 PM, Dave Page wrote: > I think it's better to warn them as early as possible, as we do in > pgAdmin 3 (actua