[pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Akshay Joshi
Hi All Please find the attached patch to fix the RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1807.patch Description: Binary data -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue of column order in Primary Key/Index constraints (pgAdmin4)

2016-12-16 Thread Murtuza Zabuawala
Hi Dave, Please find updates patch for the same. RM#1842 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Nov 25, 2016 at 3:37 PM, Dave Page wrote: > On Thu, Nov 24, 2016 at 9:57 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > P

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

2016-12-16 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Dec 12, 2016 at 3:30 PM, Dave Page wrote: > Hi > > On Fri, Dec 9, 2016 at 11:37 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch to fix the RM 1780: Rendering glitches in > the > > query editor line

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2016-12-16 Thread Ashesh Vashi
Hi Dave, On Mon, Dec 12, 2016 at 4:01 PM, Dave Page wrote: > Hi, > > On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch to resolve the issue reported in RM #1679 >> >> >> Th

[pgadmin-hackers] round function doesn't work properly

2016-12-16 Thread Jacek Jastrzębski
Hi, I just wanted you to know that when you round the number to 2 decimal places, and the 2 decimal digit is 0, it drops the 0 (which it shouldn't I guess) cheers, Jacek

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Dave Page
Hi On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi wrote: > Hi All > > Please find the attached patch to fix the RM #1807 Query Tool Does Not > Recognize When File Changes Have Been Saved. > If I open a file with the patch applied, and make a change (add a space to the end), it's correctly detect

[pgadmin-hackers] pgAdmin 4 commit: Show index columns in the correct order in RE-SQL. Fi

2016-12-16 Thread Dave Page
Show index columns in the correct order in RE-SQL. Fixes #1842 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1431dfcb01462a281c37cdde57408feba75db8b9 Author: Murtuza Zabuawala Modified Files -- .../tables/templates/index/sql/9.1_

Re: [pgadmin-hackers] PATCH: To fix the issue of column order in Primary Key/Index constraints (pgAdmin4)

2016-12-16 Thread Dave Page
Thanks - patch applied! On Fri, Dec 16, 2016 at 9:03 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find updates patch for the same. > RM#1842 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Nov 25, 2016 at 3:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-12-16 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the regression bug due to this (RM 1801) fix. Issue: While creating database, gets an error while changing the tab to SQL tab. Thanks, Khushboo On Fri, Dec 9, 2016 at 5:29 PM, Dave Page wrote: > Thanks, patch applied. > > On Fri, Dec 9, 2016 at

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-16 Thread Neel Patel
Hi Dave, Please find attached patch file with the fix of below suggestion. - If the directory that has been remembered no longer exists, then find closest parent directory to set last remembered directory. Do review it and let us know for comments. Thanks, Neel Patel On Fri, Dec 9, 2016

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Akshay Joshi
Hi Dave On Fri, Dec 16, 2016 at 5:22 PM, Dave Page wrote: > Hi > > On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> Please find the attached patch to fix the RM #1807 Query Tool Does Not >> Recognize When File Changes Have Been Saved. >> >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Dave Page
Hi On Fri, Dec 16, 2016 at 12:46 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Fri, Dec 16, 2016 at 5:22 PM, Dave Page wrote: > >> Hi >> >> On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> Please find the a

[pgadmin-hackers] pgAdmin 4 commit: Properly size the SQL Editor gutter as the width of t

2016-12-16 Thread Dave Page
Properly size the SQL Editor gutter as the width of the line numbers increases. Fixes #1780 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ea9919073e30a7eee3154095357ea76800e388 Author: Khushboo Vashi Modified Files -- web/pgad

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

2016-12-16 Thread Dave Page
Thanks, patch applied! On Fri, Dec 16, 2016 at 9:12 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Dec 12, 2016 at 3:30 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Dec 9, 2016 at 11:37 AM, Khushboo Vashi >> wrote: >> > Hi, >> > >>

Re: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

2016-12-16 Thread Dave Page
On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to allow SQL field Backform Control to wrap code. > There is no open RM for this, it's just a small enhancement to control (PFA > screenshot for reference). Wouldn't this be better as an option under File->Prefere

[pgadmin-hackers] pgAdmin 4 commit: Fix regression when generating SQL for new databases,

2016-12-16 Thread Dave Page
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1d571902da939cd9799665f24e885e43a58ca119 Author: Khushboo Vashi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-12-16 Thread Dave Page
Thanks, patch applied. On Fri, Dec 16, 2016 at 12:02 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the regression bug due to this (RM > 1801) fix. > > Issue: While creating database, gets an error while changing the tab to SQL > tab. > > Thanks, > Khushboo > > > > > >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Akshay Joshi
On Fri, Dec 16, 2016 at 6:28 PM, Dave Page wrote: > Hi > > On Fri, Dec 16, 2016 at 12:46 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Dec 16, 2016 at 5:22 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi < >>> akshay.jo

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-16 Thread Dave Page
Hi On Fri, Dec 16, 2016 at 12:08 PM, Neel Patel wrote: > Hi Dave, > > Please find attached patch file with the fix of below suggestion. > > If the directory that has been remembered no longer exists, then find > closest parent directory to set last remembered directory. > > Do review it and let u

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2016-12-16 Thread Dave Page
On Fri, Dec 16, 2016 at 1:24 PM, Akshay Joshi wrote: > > > On Fri, Dec 16, 2016 at 6:28 PM, Dave Page wrote: > >> Hi >> >> On Fri, Dec 16, 2016 at 12:46 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Fri, Dec 16, 2016 at 5:22 PM, Dave Page wrote: >>>

Re: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

2016-12-16 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch with suggested changes, I only thought of SqlFieldControl but yes we can use the same configuration everywhere. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Dec 16, 2016 at 6:38 PM, D

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

2016-12-16 Thread Dave Page
Hi Khushboo I just noticed this broke block folding in the editor, as it doesn't leave enough room in the gutter for the arrows. See the attached screenshots from the query tool (note that the mis-placed arrows cannot be toggled). Can you fix this ASAP please? I haven't reverted your patch. Plea

[pgadmin-hackers] pgAdmin 4 commit: Allow users to enable wrapping of code in SQL boxes.

2016-12-16 Thread Dave Page
Allow users to enable wrapping of code in SQL boxes. Fixes#2025 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fc8f040ff6a3023fdb7ed5afd17ae3508f41d24 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

2016-12-16 Thread Dave Page
Thanks, patch applied. On Fri, Dec 16, 2016 at 2:29 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch with suggested changes, I only thought of SqlFieldControl > but yes we can use the same configuration everywhere. > > Please review. > > > -- > Regards, > Murtuza Zabuawala > Enterpri

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-12-16 Thread Harshal Dhumal
Hi Dave, Please find updated patch below for direct file navigation. I have covered all of above mentioned case. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Nov 25, 2016 at 4:09 PM, Dave Page wrote: > Hi >

[pgadmin-hackers] Please unsubscribe me!

2016-12-16 Thread Marcos Azevedo (a.k.a psylinux)
Please unsubscribe me! -- *Marcos Azevedo*