Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 7:28 AM, Surinder Kumar wrote: > Hi Dave, > > On Mon, Jan 30, 2017 at 6:18 PM, Dave Page wrote: >> >> On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar >> wrote: >> > Hi Dave, >> > >> > Please find updated patch. >> > >> > On Mon, Jan 16, 2017 at 10:01 PM, Dave Page wrote:

[pgadmin-hackers] Issues with PgAdmin4

2017-02-03 Thread Tania
Hi, I like the new interface, until I realized how sensitive the windows/tabs are! Gets docked and undocked at weird times and then docking them back to original position is so hard. Are there any tips or tricks to that to make my life easier? I work with PgAdmin all the time at my job and this

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Dave Page
Akshay, I'll leave you to review/commit this. Please ensure that any tickets that patches close have the target version set to 1.2 (if they don't, please update them). That way the roadmap will reflect all the changes in the release. Thanks. On Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi < khushb

[pgadmin-hackers] pgAdmin 4 commit: Allow direct navigation (i.e. typing of paths) in the

2017-02-03 Thread Dave Page
Allow direct navigation (i.e. typing of paths) in the file manager. Fixes #1911 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ef26a528b6b3045873302036d1a294e58c3ae85 Author: Harshal Dhumal Modified Files -- web/pgadmin/misc/file

Re: [pgadmin-hackers] Issues with PgAdmin4

2017-02-03 Thread Murtuza Zabuawala
You can try "Reset Layout" option. Ref: https://www.pgadmin.org/docs4/dev/pgadmin_menu_bar.html You can copy paste rows, To copy rows from query tool, first select rows you want to copy then click on "Copy button" (refer screenshot) Now you can "Paste" the copied rows at your desired destination.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Akshay Joshi
Hi Dave On Fri, Feb 3, 2017 at 3:10 PM, Dave Page wrote: > Akshay, I'll leave you to review/commit this. Please ensure that any > tickets that patches close have the target version set to 1.2 (if they > don't, please update them). That way the roadmap will reflect all the > changes in the releas

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi wrote: > Hi Dave > > On Fri, Feb 3, 2017 at 3:10 PM, Dave Page wrote: > >> Akshay, I'll leave you to review/commit this. Please ensure that any >> tickets that patches close have the target version set to 1.2 (if they >> don't, please update them). Th

[pgadmin-hackers] pgAdmin 4 commit: 1) Wrong tablespace displayed in table properties. Fi

2017-02-03 Thread Akshay Joshi
1) Wrong tablespace displayed in table properties. Fixes #2069 2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2ac6fc6a79

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Akshay Joshi
Thanks Khushboo. Patch applied. On Fri, Feb 3, 2017 at 3:37 PM, Dave Page wrote: > > > On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Feb 3, 2017 at 3:10 PM, Dave Page wrote: >> >>> Akshay, I'll leave you to review/commit this.

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-03 Thread Murtuza Zabuawala
Hi, Please find updates patch for the same. RM#2076 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala > wrote: > > Hi Dave, > >

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for functions missing. Fix: Incorporated the PARALLEL SAFE support for the functions and procedures for PostgreSQL 9.6. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/_

Re: [pgadmin-hackers] Regarding Import and Export Issue

2017-02-03 Thread Murtuza Zabuawala
It's a bug with windows system & already reported https://redmine.postgresql.org/issues/1679 It will be taken care in future release. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 2, 2017 at 12:02 PM, wrote: > Hi, > > Detai

Re: [pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-02-03 Thread Neel Patel
Hi Dave, Please find attached updated patch with the fix of mentioned issue. Do review it and let us know for comments. Thanks, Neel Patel On Mon, Jan 30, 2017 at 5:44 PM, Dave Page wrote: > Hi > > On Fri, Jan 27, 2017 at 10:30 AM, Neel Patel > wrote: > > Hi, > > > > Please find attached pat

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Akshay Joshi
Hi Dave I have reviewed the patch and after applying it output in pgAdmin4 CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry) RETURNS boolean LANGUAGE 'sql' COST 100.0 *IMMUTABLE NOT LEAKPROOF * *PARALLEL SAFE* AS $function$ SELECT $1 OPERATOR(publ

Re: [pgadmin-hackers] pgAdmin4 regression setup

2017-02-03 Thread Navnath Gadakh
Hi Ikram, I will look into it. Thanks. On Wed, Feb 1, 2017 at 3:02 PM, Ikram Khan wrote: > Hi, > > As discussed with Navnath, Regression is working fine for Linux with > currently generating installer for pgadmin4 i.e. edb-pgadmin4-1.1-1-linux- > x64.run > > For windows I am unable to run

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Dave Page
I doubt the order matters, but feel free to change it if it bugs you :-) On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi wrote: > Hi Dave > > I have reviewed the patch and after applying it output in pgAdmin4 > > CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 > geometry) >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-03 Thread Dave Page
Thanks - patch applied. On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala wrote: > Hi, > > Please find updates patch for the same. > RM#2076 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Feb 1, 2017 at 3:08 PM, D

[pgadmin-hackers] pgAdmin 4 commit: Handle sized time/timestamp columns correctly. Fixes

2017-02-03 Thread Dave Page
Handle sized time/timestamp columns correctly. Fixes #2076 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf8c3c41809231e848da2f6b7daf500e1a63e2ff Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/tables/__

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Khushboo Vashi
On Fri, Feb 3, 2017 at 7:02 PM, Dave Page wrote: > I doubt the order matters, but feel free to change it if it bugs you :-) > > I have tried to create the function with both SQL commands. There is no bug, its just in pgAdmin4, if its not leakproof then we mentioned 'NOT LEAKPROOF' in the SQL. So

[pgadmin-hackers] pgAdmin 4 commit: Handle saved directories that no longer exist gracefu

2017-02-03 Thread Dave Page
Handle saved directories that no longer exist gracefully. Fixes #2110 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c17e201a92b03404065fd6518f8d33593d64e7a7 Author: Neel Patel Modified Files -- web/pgadmin/misc/file_manager/__ini

Re: [pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-02-03 Thread Dave Page
Thanks - applied! On Fri, Feb 3, 2017 at 12:33 PM, Neel Patel wrote: > Hi Dave, > > Please find attached updated patch with the fix of mentioned issue. > > Do review it and let us know for comments. > > Thanks, > Neel Patel > > On Mon, Jan 30, 2017 at 5:44 PM, Dave Page wrote: >> >> Hi >> >> On

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Fri, Feb 3, 2017 at 7:02 PM, Dave Page > wrote: > >> I doubt the order matters, but feel free to change it if it bugs you :-) >> >> > I have tried to create the function with both SQL commands. > The

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-02-03 Thread Ashesh Vashi
Hi Dave, Please find the patch with fix for the 2144. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Feb 3, 2017 at 11:02 AM, Fahar Abb

Re: [pgadmin-hackers] pg3 vs pg4 for macOS

2017-02-03 Thread Anthony DeBarros
I've been using both pgAdmin3 and 4 on MacOS Sierra. Based on watching the dev team's activity over the last few months, the forthcoming pgAdmin 4 version 1.2 will be a big improvement and address many common issues/requests from users, including bugs regarding file saving and navigating files that

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-02-03 Thread Atira Odhner
Hi Dave, Here is a new patch which includes the following: - randomized ports - delete the acceptance_test_db database in setup in case a prior run failed - fixed size browser window Cheers, Tira & George On Tue, Jan 31, 2017 at 11:25 AM, Dave Page wrote: > Hi George, > > I just tried to do so

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-03 Thread Surinder Kumar
Hi Dave, Please find updated patch and review. On Fri, Feb 3, 2017 at 2:43 PM, Dave Page wrote: > On Fri, Feb 3, 2017 at 7:28 AM, Surinder Kumar > wrote: > > Hi Dave, > > > > On Mon, Jan 30, 2017 at 6:18 PM, Dave Page wrote: > >> > >> On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar > >> wro